From 40a75379b7db93f2d595ebf4780a10ba243da9c5 Mon Sep 17 00:00:00 2001 From: Cacodemon345 Date: Fri, 4 Mar 2022 13:25:51 +0600 Subject: [PATCH 1/3] qt: XT IDE should be XTA --- src/qt/qt_harddrive_common.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qt/qt_harddrive_common.cpp b/src/qt/qt_harddrive_common.cpp index fa08f7f2c..a47e036c7 100644 --- a/src/qt/qt_harddrive_common.cpp +++ b/src/qt/qt_harddrive_common.cpp @@ -28,7 +28,7 @@ void Harddrives::populateBuses(QAbstractItemModel *model) { model->removeRows(0, model->rowCount()); model->insertRows(0, 6); model->setData(model->index(0, 0), "MFM/RLL"); - model->setData(model->index(1, 0), "XT IDE"); + model->setData(model->index(1, 0), "XTA"); model->setData(model->index(2, 0), "ESDI"); model->setData(model->index(3, 0), "IDE"); model->setData(model->index(4, 0), "ATAPI"); @@ -97,7 +97,7 @@ QString Harddrives::BusChannelName(uint8_t bus, uint8_t channel) { busName = QString("MFM/RLL (%1:%2)").arg(channel >> 1).arg(channel & 1); break; case HDD_BUS_XTA: - busName = QString("XT IDE (%1:%2)").arg(channel >> 1).arg(channel & 1); + busName = QString("XTA (%1:%2)").arg(channel >> 1).arg(channel & 1); break; case HDD_BUS_ESDI: busName = QString("ESDI (%1:%2)").arg(channel >> 1).arg(channel & 1); From 5e4cb50da0d5533cc171d604fbe42571f6f944c0 Mon Sep 17 00:00:00 2001 From: Cacodemon345 Date: Fri, 4 Mar 2022 13:26:10 +0600 Subject: [PATCH 2/3] qt: Default to 0:0 if bus is full --- src/qt/qt_harddiskdialog.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qt/qt_harddiskdialog.cpp b/src/qt/qt_harddiskdialog.cpp index 3e933ddab..94731cca2 100644 --- a/src/qt/qt_harddiskdialog.cpp +++ b/src/qt/qt_harddiskdialog.cpp @@ -705,6 +705,7 @@ void HarddiskDialog::on_comboBoxBus_currentIndexChanged(int index) { break; } + if (chanIdx == 0xFF) chanIdx = 0; ui->comboBoxChannel->setCurrentIndex(chanIdx); } From d695ca3cc9c38af71ca250e26cbfcc1c571943fc Mon Sep 17 00:00:00 2001 From: Cacodemon345 Date: Fri, 4 Mar 2022 14:00:24 +0600 Subject: [PATCH 3/3] qt: Don't normalize paths on non-Windows --- src/qt/qt_platform.cpp | 2 ++ src/sound/xaudio2.c | 1 + src/unix/unix.c | 5 +---- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qt/qt_platform.cpp b/src/qt/qt_platform.cpp index 4ec31b842..0c399cd48 100644 --- a/src/qt/qt_platform.cpp +++ b/src/qt/qt_platform.cpp @@ -238,10 +238,12 @@ plat_path_abs(char *path) void plat_path_normalize(char* path) { +#ifdef Q_OS_WINDOWS while (*path++ != 0) { if (*path == '\\') *path = '/'; } +#endif } void diff --git a/src/sound/xaudio2.c b/src/sound/xaudio2.c index 114aa16da..c7e8dbf8f 100644 --- a/src/sound/xaudio2.c +++ b/src/sound/xaudio2.c @@ -178,6 +178,7 @@ inital() } initialized = 1; + atexit(closeal); } void diff --git a/src/unix/unix.c b/src/unix/unix.c index 83f6b4a9b..4e7e3602d 100644 --- a/src/unix/unix.c +++ b/src/unix/unix.c @@ -285,10 +285,7 @@ plat_path_abs(char *path) void plat_path_normalize(char* path) { - while (*path++ != 0) - { - if (*path == '\\') *path = '/'; - } + /* No-op. */ } void