claunia/86Box
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Next round of sonarlint cleanups

Browse Source
This commit is contained in:
Jasmine Iwanek
2023-06-26 12:47:04 -04:00
parent 2fe3bcd5d2
commit 21adfd4d50
176 changed files with 2791 additions and 1377 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/device/serial.c
View File

@@ -154,7 +154,9 @@ serial_receive_timer(void *priv)
{
serial_t *dev = (serial_t *) priv;
// serial_log("serial_receive_timer()\n");
#if 0
serial_log("serial_receive_timer()\n");
#endif
timer_on_auto(&dev->receive_timer, /* dev->bits * */ dev->transmit_period);
@@ -174,7 +176,9 @@ serial_receive_timer(void *priv)
} else {
/* We can input data into the FIFO. */
dev->rcvr_fifo[dev->rcvr_fifo_end] = (uint8_t) (dev->out_new & 0xff);
// dev->rcvr_fifo_end = (dev->rcvr_fifo_end + 1) & 0x0f;
#if 0
dev->rcvr_fifo_end = (dev->rcvr_fifo_end + 1) & 0x0f;
#endif
/* Do not wrap around, makes sure it still triggers the interrupt
at 16 bytes. */
dev->rcvr_fifo_end++;
@@ -557,6 +561,8 @@ serial_write(uint16_t addr, uint8_t val, void *p)
case 3:
dev->rcvr_fifo_len = 14;
break;
default:
break;
}
dev->out_new = 0xffff;
serial_log("FIFO now %sabled, receive FIFO length = %i\n", dev->fifo_enabled ? "en" : "dis", dev->rcvr_fifo_len);
@@ -624,8 +630,10 @@ serial_write(uint16_t addr, uint8_t val, void *p)
serial_update_ints(dev);
break;
case 6:
// dev->msr = (val & 0xf0) | (dev->msr & 0x0f);
// dev->msr = val;
#if 0
dev->msr = (val & 0xf0) | (dev->msr & 0x0f);
dev->msr = val;
#endif
/* The actual condition bits of the MSR are read-only, but the delta bits are
undocumentedly writable, and the PCjr BIOS uses them to raise MSR interrupts. */
dev->msr = (dev->msr & 0xf0) | (val & 0x0f);
@@ -637,6 +645,8 @@ serial_write(uint16_t addr, uint8_t val, void *p)
if (dev->type >= SERIAL_16450)
dev->scratch = val;
break;
default:
break;
}
}
@@ -736,6 +746,8 @@ serial_read(uint16_t addr, void *p)
case 7:
ret = dev->scratch;
break;
default:
break;
}
// serial_log("UART: Read %02X from port %02X\n", ret, addr);
@@ -914,7 +926,7 @@ serial_set_next_inst(int ni)
void
serial_standalone_init(void)
{
for (; next_inst < SERIAL_MAX;)
while (next_inst < SERIAL_MAX)
device_add_inst(&ns8250_device, next_inst + 1);
};