Next round of sonarlint cleanups

This commit is contained in:
Jasmine Iwanek
2023-06-26 12:47:04 -04:00
parent 2fe3bcd5d2
commit 21adfd4d50
176 changed files with 2791 additions and 1377 deletions

View File

@@ -29,6 +29,7 @@
#include <86box/serial.h>
#include <86box/serial_passthrough.h>
#include <86box/plat_serial_passthrough.h>
#include <86box/plat_unused.h>
#define ENABLE_SERIAL_PASSTHROUGH_LOG 1
#ifdef ENABLE_SERIAL_PASSTHROUGH_LOG
@@ -61,7 +62,7 @@ serial_passthrough_init(void)
}
static void
serial_passthrough_write(serial_t *s, void *priv, uint8_t val)
serial_passthrough_write(UNUSED(serial_t *s), void *priv, uint8_t val)
{
plat_serpt_write(priv, val);
}
@@ -86,24 +87,32 @@ host_to_serial_cb(void *priv)
}
}
if (plat_serpt_read(dev, &byte)) {
// printf("got byte %02X\n", byte);
#if 0
printf("got byte %02X\n", byte);
#endif
serial_write_fifo(dev->serial, byte);
// serial_set_dsr(dev->serial, 1);
#if 0
serial_set_dsr(dev->serial, 1);
#endif
}
no_write_to_machine:
// serial_device_timeout(dev->serial);
#if 0
serial_device_timeout(dev->serial);
#endif
timer_on_auto(&dev->host_to_serial_timer, (1000000.0 / dev->baudrate) * (double) dev->bits);
}
static void
serial_passthrough_rcr_cb(struct serial_s *serial, void *priv)
serial_passthrough_rcr_cb(UNUSED(struct serial_s *serial), void *priv)
{
serial_passthrough_t *dev = (serial_passthrough_t *) priv;
timer_stop(&dev->host_to_serial_timer);
/* FIXME: do something to dev->baudrate */
timer_on_auto(&dev->host_to_serial_timer, (1000000.0 / dev->baudrate) * (double) dev->bits);
// serial_clear_fifo(dev->serial);
#if 0
serial_clear_fifo(dev->serial);
#endif
}
static void
@@ -114,7 +123,9 @@ serial_passthrough_speed_changed(void *priv)
timer_stop(&dev->host_to_serial_timer);
/* FIXME: do something to dev->baudrate */
timer_on_auto(&dev->host_to_serial_timer, (1000000.0 / dev->baudrate) * (double) dev->bits);
// serial_clear_fifo(dev->serial);
#if 0
serial_clear_fifo(dev->serial);
#endif
}
static void
@@ -131,28 +142,28 @@ serial_passthrough_dev_close(void *priv)
}
void
serial_passthrough_transmit_period(serial_t *serial, void *p, double transmit_period)
serial_passthrough_transmit_period(UNUSED(serial_t *serial), void *priv, double transmit_period)
{
serial_passthrough_t *dev = (serial_passthrough_t *) p;
serial_passthrough_t *dev = (serial_passthrough_t *) priv;
if (dev->mode != SERPT_MODE_HOSTSER)
return;
dev->baudrate = 1000000.0 / transmit_period;
serial_passthrough_speed_changed(p);
serial_passthrough_speed_changed(priv);
plat_serpt_set_params(dev);
}
void
serial_passthrough_lcr_callback(serial_t *serial, void *p, uint8_t lcr)
serial_passthrough_lcr_callback(serial_t *serial, void *priv, uint8_t lcr)
{
serial_passthrough_t *dev = (serial_passthrough_t *) p;
serial_passthrough_t *dev = (serial_passthrough_t *) priv;
if (dev->mode != SERPT_MODE_HOSTSER)
return;
dev->bits = serial->bits;
dev->data_bits = ((lcr & 0x03) + 5);
serial_passthrough_speed_changed(p);
serial_passthrough_speed_changed(priv);
plat_serpt_set_params(dev);
}