claunia/86Box
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor IDT_???? to have meaningful names

Browse Source
This commit is contained in:
Jasmine Iwanek
2022-01-30 23:30:40 -05:00
parent a666ff87c0
commit 3a140e67d9
22 changed files with 289 additions and 228 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
src/win/win_settings.c
View File

@@ -2011,7 +2011,7 @@ recalc_location_controls(HWND hdlg, int is_add_dlg, int assign_id)
{
int i = 0, bus = 0;
for (i = IDT_1722; i <= IDT_1723; i++)
for (i = IDT_CHANNEL; i <= IDT_ID; i++)
settings_show_window(hdlg, i, FALSE);
settings_show_window(hdlg, IDC_COMBO_HD_CHANNEL, FALSE);
settings_show_window(hdlg, IDC_COMBO_HD_ID, FALSE);
@@ -2022,7 +2022,7 @@ recalc_location_controls(HWND hdlg, int is_add_dlg, int assign_id)
switch(bus) {
case HDD_BUS_MFM: /* MFM */
settings_show_window(hdlg, IDT_1722, TRUE);
settings_show_window(hdlg, IDT_CHANNEL, TRUE);
settings_show_window(hdlg, IDC_COMBO_HD_CHANNEL, TRUE);
if (assign_id)
@@ -2030,7 +2030,7 @@ recalc_location_controls(HWND hdlg, int is_add_dlg, int assign_id)
settings_set_cur_sel(hdlg, IDC_COMBO_HD_CHANNEL, is_add_dlg ? new_hdd.mfm_channel : temp_hdd[lv1_current_sel].mfm_channel);
break;
case HDD_BUS_XTA: /* XTA */
settings_show_window(hdlg, IDT_1722, TRUE);
settings_show_window(hdlg, IDT_CHANNEL, TRUE);
settings_show_window(hdlg, IDC_COMBO_HD_CHANNEL, TRUE);
if (assign_id)
@@ -2038,7 +2038,7 @@ recalc_location_controls(HWND hdlg, int is_add_dlg, int assign_id)
settings_set_cur_sel(hdlg, IDC_COMBO_HD_CHANNEL, is_add_dlg ? new_hdd.xta_channel : temp_hdd[lv1_current_sel].xta_channel);
break;
case HDD_BUS_ESDI: /* ESDI */
settings_show_window(hdlg, IDT_1722, TRUE);
settings_show_window(hdlg, IDT_CHANNEL, TRUE);
settings_show_window(hdlg, IDC_COMBO_HD_CHANNEL, TRUE);
if (assign_id)
@@ -2047,7 +2047,7 @@ recalc_location_controls(HWND hdlg, int is_add_dlg, int assign_id)
break;
case HDD_BUS_IDE: /* IDE */
case HDD_BUS_ATAPI: /* ATAPI */
settings_show_window(hdlg, IDT_1722, TRUE);
settings_show_window(hdlg, IDT_CHANNEL, TRUE);
settings_show_window(hdlg, IDC_COMBO_HD_CHANNEL_IDE, TRUE);
if (assign_id)
@@ -2055,8 +2055,8 @@ recalc_location_controls(HWND hdlg, int is_add_dlg, int assign_id)
settings_set_cur_sel(hdlg, IDC_COMBO_HD_CHANNEL_IDE, is_add_dlg ? new_hdd.ide_channel : temp_hdd[lv1_current_sel].ide_channel);
break;
case HDD_BUS_SCSI: /* SCSI */
settings_show_window(hdlg, IDT_1723, TRUE);
settings_show_window(hdlg, IDT_1724, TRUE);
settings_show_window(hdlg, IDT_ID, TRUE);
settings_show_window(hdlg, IDT_LUN, TRUE);
settings_show_window(hdlg, IDC_COMBO_HD_ID, TRUE);
if (assign_id)
@@ -2065,7 +2065,7 @@ recalc_location_controls(HWND hdlg, int is_add_dlg, int assign_id)
}
}
settings_show_window(hdlg, IDT_1721, (hd_listview_items != 0) || is_add_dlg);
settings_show_window(hdlg, IDT_BUS, (hd_listview_items != 0) || is_add_dlg);
settings_show_window(hdlg, IDC_COMBO_HD_BUS, (hd_listview_items != 0) || is_add_dlg);
}
@@ -2528,11 +2528,11 @@ static MVHDGeom create_drive_vhd_fixed(char* filename, int cyl, int heads, int s
adjust_86box_geometry_for_vhd(&_86box_geometry, &vhd_geometry);
HWND h = GetDlgItem(vhd_progress_hdlg, IDC_PBAR_IMG_CREATE);
settings_show_window(vhd_progress_hdlg, IDT_1731, FALSE);
settings_show_window(vhd_progress_hdlg, IDT_FILE_NAME, FALSE);
settings_show_window(vhd_progress_hdlg, IDC_EDIT_HD_FILE_NAME, FALSE);
settings_show_window(vhd_progress_hdlg, IDC_CFILE, FALSE);
settings_show_window(vhd_progress_hdlg, IDC_PBAR_IMG_CREATE, TRUE);
settings_enable_window(vhd_progress_hdlg, IDT_1752, TRUE);
settings_enable_window(vhd_progress_hdlg, IDT_PROGRESS, TRUE);
SendMessage(h, PBM_SETRANGE32, (WPARAM) 0, (LPARAM) vhd_geometry.cyl * vhd_geometry.heads * vhd_geometry.spt);
SendMessage(h, PBM_SETPOS, (WPARAM) 0, (LPARAM) 0);
@@ -2663,7 +2663,7 @@ win_settings_hard_disks_add_proc(HWND hdlg, UINT message, WPARAM wParam, LPARAM
settings_set_cur_sel(hdlg, IDC_COMBO_HD_BLOCK_SIZE, 0);
settings_show_window(hdlg, IDC_COMBO_HD_BLOCK_SIZE, FALSE);
settings_show_window(hdlg, IDT_1775, FALSE);
settings_show_window(hdlg, IDT_BLOCK_SIZE, FALSE);
if (existing & 1) {
settings_enable_window(hdlg, IDC_EDIT_HD_SPT, FALSE);
@@ -2672,7 +2672,7 @@ win_settings_hard_disks_add_proc(HWND hdlg, UINT message, WPARAM wParam, LPARAM
settings_enable_window(hdlg, IDC_EDIT_HD_SIZE, FALSE);
settings_enable_window(hdlg, IDC_COMBO_HD_TYPE, FALSE);
settings_show_window(hdlg, IDC_COMBO_HD_IMG_FORMAT, FALSE);
settings_show_window(hdlg, IDT_1774, FALSE);
settings_show_window(hdlg, IDT_IMG_FORMAT, FALSE);
/* adjust window size */
GetWindowRect(hdlg, &rect);
@@ -2717,7 +2717,7 @@ win_settings_hard_disks_add_proc(HWND hdlg, UINT message, WPARAM wParam, LPARAM
new_hdd.scsi_id = id;
settings_enable_window(hdlg, IDC_EDIT_HD_FILE_NAME, FALSE);
settings_show_window(hdlg, IDT_1752, FALSE);
settings_show_window(hdlg, IDT_PROGRESS, FALSE);
settings_show_window(hdlg, IDC_PBAR_IMG_CREATE, FALSE);
no_update = 0;
@@ -2845,11 +2845,11 @@ win_settings_hard_disks_add_proc(HWND hdlg, UINT message, WPARAM wParam, LPARAM
size &= 0xfffff;
if (size || r) {
settings_show_window(hdlg, IDT_1731, FALSE);
settings_show_window(hdlg, IDT_FILE_NAME, FALSE);
settings_show_window(hdlg, IDC_EDIT_HD_FILE_NAME, FALSE);
settings_show_window(hdlg, IDC_CFILE, FALSE);
settings_show_window(hdlg, IDC_PBAR_IMG_CREATE, TRUE);
settings_enable_window(hdlg, IDT_1752, TRUE);
settings_enable_window(hdlg, IDT_PROGRESS, TRUE);
h = GetDlgItem(hdlg, IDC_PBAR_IMG_CREATE);
SendMessage(h, PBM_SETRANGE32, (WPARAM) 0, (LPARAM) r);
@@ -3309,10 +3309,10 @@ hdd_add_file_open_error:
if (img_format == 4 || img_format == 5) { /* For dynamic and diff VHDs, show the block size dropdown. */
settings_show_window(hdlg, IDC_COMBO_HD_BLOCK_SIZE, TRUE);
settings_show_window(hdlg, IDT_1775, TRUE);
settings_show_window(hdlg, IDT_BLOCK_SIZE, TRUE);
} else { /* Hide it otherwise. */
settings_show_window(hdlg, IDC_COMBO_HD_BLOCK_SIZE, FALSE);
settings_show_window(hdlg, IDT_1775, FALSE);
settings_show_window(hdlg, IDT_BLOCK_SIZE, FALSE);
}
break;
}
@@ -4226,19 +4226,19 @@ cdrom_recalc_location_controls(HWND hdlg, int assign_id)
int i = 0;
int bus = temp_cdrom[lv2_current_sel].bus_type;
for (i = IDT_1741; i < (IDT_1742 + 1); i++)
for (i = IDT_CD_ID; i <= (IDT_CD_LUN); i++)
settings_show_window(hdlg, i, FALSE);
settings_show_window(hdlg, IDC_COMBO_CD_ID, FALSE);
settings_show_window(hdlg, IDC_COMBO_CD_CHANNEL_IDE, FALSE);
settings_show_window(hdlg, IDC_COMBO_CD_SPEED, bus != CDROM_BUS_DISABLED);
settings_show_window(hdlg, IDT_1758, bus != CDROM_BUS_DISABLED);
settings_show_window(hdlg, IDT_CD_SPEED, bus != CDROM_BUS_DISABLED);
if (bus != CDROM_BUS_DISABLED)
settings_set_cur_sel(hdlg, IDC_COMBO_CD_SPEED, temp_cdrom[lv2_current_sel].speed - 1);
switch(bus) {
case CDROM_BUS_ATAPI: /* ATAPI */
settings_show_window(hdlg, IDT_1742, TRUE);
settings_show_window(hdlg, IDT_CD_LUN, TRUE);
settings_show_window(hdlg, IDC_COMBO_CD_CHANNEL_IDE, TRUE);
if (assign_id)
@@ -4247,7 +4247,7 @@ cdrom_recalc_location_controls(HWND hdlg, int assign_id)
settings_set_cur_sel(hdlg, IDC_COMBO_CD_CHANNEL_IDE, temp_cdrom[lv2_current_sel].ide_channel);
break;
case CDROM_BUS_SCSI: /* SCSI */
settings_show_window(hdlg, IDT_1741, TRUE);
settings_show_window(hdlg, IDT_CD_ID, TRUE);
settings_show_window(hdlg, IDC_COMBO_CD_ID, TRUE);
if (assign_id)
@@ -4307,19 +4307,19 @@ mo_recalc_location_controls(HWND hdlg, int assign_id)
int i = 0;
int bus = temp_mo_drives[lv1_current_sel].bus_type;
for (i = IDT_1771; i < (IDT_1772 + 1); i++)
for (i = IDT_MO_ID; i <= (IDT_MO_CHANNEL); i++)
settings_show_window(hdlg, i, FALSE);
settings_show_window(hdlg, IDC_COMBO_MO_ID, FALSE);
settings_show_window(hdlg, IDC_COMBO_MO_CHANNEL_IDE, FALSE);
settings_show_window(hdlg, IDC_COMBO_MO_TYPE, bus != MO_BUS_DISABLED);
settings_show_window(hdlg, IDT_1773, bus != MO_BUS_DISABLED);
settings_show_window(hdlg, IDT_MO_TYPE, bus != MO_BUS_DISABLED);
if (bus != MO_BUS_DISABLED)
settings_set_cur_sel(hdlg, IDC_COMBO_MO_TYPE, temp_mo_drives[lv1_current_sel].type);
switch(bus) {
case MO_BUS_ATAPI: /* ATAPI */
settings_show_window(hdlg, IDT_1772, TRUE);
settings_show_window(hdlg, IDT_MO_CHANNEL, TRUE);
settings_show_window(hdlg, IDC_COMBO_MO_CHANNEL_IDE, TRUE);
if (assign_id)
@@ -4328,7 +4328,7 @@ mo_recalc_location_controls(HWND hdlg, int assign_id)
settings_set_cur_sel(hdlg, IDC_COMBO_MO_CHANNEL_IDE, temp_mo_drives[lv1_current_sel].ide_channel);
break;
case MO_BUS_SCSI: /* SCSI */
settings_show_window(hdlg, IDT_1771, TRUE);
settings_show_window(hdlg, IDT_MO_ID, TRUE);
settings_show_window(hdlg, IDC_COMBO_MO_ID, TRUE);
if (assign_id)
@@ -4374,7 +4374,7 @@ zip_recalc_location_controls(HWND hdlg, int assign_id)
int bus = temp_zip_drives[lv2_current_sel].bus_type;
for (i = IDT_1754; i < (IDT_1755 + 1); i++)
for (i = IDT_ZIP_ID; i <= (IDT_ZIP_LUN); i++)
settings_show_window(hdlg, i, FALSE);
settings_show_window(hdlg, IDC_COMBO_ZIP_ID, FALSE);
settings_show_window(hdlg, IDC_COMBO_ZIP_CHANNEL_IDE, FALSE);
@@ -4385,7 +4385,7 @@ zip_recalc_location_controls(HWND hdlg, int assign_id)
switch(bus) {
case ZIP_BUS_ATAPI: /* ATAPI */
settings_show_window(hdlg, IDT_1755, TRUE);
settings_show_window(hdlg, IDT_ZIP_LUN, TRUE);
settings_show_window(hdlg, IDC_COMBO_ZIP_CHANNEL_IDE, TRUE);
if (assign_id)
@@ -4394,7 +4394,7 @@ zip_recalc_location_controls(HWND hdlg, int assign_id)
settings_set_cur_sel(hdlg, IDC_COMBO_ZIP_CHANNEL_IDE, temp_zip_drives[lv2_current_sel].ide_channel);
break;
case ZIP_BUS_SCSI: /* SCSI */
settings_show_window(hdlg, IDT_1754, TRUE);
settings_show_window(hdlg, IDT_ZIP_ID, TRUE);
settings_show_window(hdlg, IDC_COMBO_ZIP_ID, TRUE);
if (assign_id)