From 47284831880de010571d680c71d4ca48453de813 Mon Sep 17 00:00:00 2001
From: dob205 <dominik.babic0@gmail.com>
Date: Wed, 10 Nov 2021 10:01:37 +0100
Subject: [PATCH] Updating the CMakeLists.txt to create macOS app bundles

Changes the CMakeLists.txt to enable the creation of macOS app bundles via cmake --build build --target install including all necessary dylibs for a functioning macOS compile.
---
 src/CMakeLists.txt | 70 ++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 64 insertions(+), 6 deletions(-)

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 49025d4dd..db085ceec 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -9,15 +9,32 @@
 #		CMake build script.
 #
 # Authors:	David Hrdlička, <hrdlickadavid@outlook.com>
+#		dob205
 #
 #		Copyright 2020,2021 David Hrdlička.
+#		Copyright 2021 dob205.
 #
 
-# WIN32 marks us as a GUI app on Windows
-add_executable(86Box WIN32 86box.c config.c random.c timer.c io.c acpi.c apm.c
-	dma.c ddma.c nmi.c pic.c pit.c port_92.c ppi.c pci.c mca.c usb.c
-	device.c nvr.c nvr_at.c nvr_ps2.c)
+# Prepare the macOS app bundle icon depending on the release channel
+if(RELEASE_BUILD)
+	set(APP_ICON_MACOSX ${CMAKE_CURRENT_SOURCE_DIR}/mac/icons/release/86Box.icns)
+elseif(BETA_BUILD)
+	set(APP_ICON_MACOSX ${CMAKE_CURRENT_SOURCE_DIR}/mac/icons/beta/86Box.icns)
+elseif(ALPHA_BUILD)
+	set(APP_ICON_MACOSX ${CMAKE_CURRENT_SOURCE_DIR}/mac/icons/dev/86Box.icns)
+else()
+	set(APP_ICON_MACOSX ${CMAKE_CURRENT_SOURCE_DIR}/mac/icons/branch/86Box.icns)
+endif()
 
+set_source_files_properties(${APP_ICON_MACOSX} PROPERTIES
+        MACOSX_PACKAGE_LOCATION "Resources")
+        
+# WIN32 marks us as a GUI app on Windows
+# MACOSX_BUNDLE prepares a macOS application bundle including with the app icon
+add_executable(86Box WIN32 MACOSX_BUNDLE 86box.c config.c random.c timer.c io.c acpi.c apm.c
+	dma.c ddma.c nmi.c pic.c pit.c port_92.c ppi.c pci.c mca.c usb.c
+	device.c nvr.c nvr_at.c nvr_ps2.c ${APP_ICON_MACOSX})
+ 
 if(NEW_DYNAREC)
 	add_compile_definitions(USE_NEW_DYNAREC)
 endif()
@@ -36,6 +53,7 @@ endif()
 
 if(DEV_BRANCH)
 	add_compile_definitions(DEV_BRANCH)
+	set(APP_ICON_MACOSX ${CMAKE_CURRENT_SOURCE_DIR}/mac/icons/branch/86Box.icns)
 endif()
 
 if(VNC)
@@ -63,13 +81,41 @@ if(MINGW)
 	set(CMAKE_FIND_LIBRARY_SUFFIXES ".a" ".dll.a")
 endif()
 
+#some macOS specific configuration steps
 if(APPLE)
-	# Force using the newest library if it's installed by homebrew
-	set(CMAKE_FIND_FRAMEWORK LAST)
+  # Force using the newest library if it's installed by homebrew
+  set(CMAKE_FIND_FRAMEWORK LAST)
+  
+  # prepare stuff for macOS app bundles
+  set(CMAKE_MACOSX_BUNDLE 1)
+
+  # setting our compilation target to macOS Mojave (macOS version 10.14), can be eventually changed to macOS 10.13 High Sierra
+  set(CMAKE_OSX_DEPLOYMENT_TARGET "10.14")
+  
+  # set the Info.plist properly
+  set_target_properties(86Box PROPERTIES MACOSX_BUNDLE_INFO_PLIST ${CMAKE_CURRENT_SOURCE_DIR}/mac/Info.plist.in)
+  set(MACOSX_BUNDLE_GUI_IDENTIFIER net.86Box.86Box)
+  set(MACOSX_BUNDLE_BUNDLE_NAME 86Box)
+  set(MACOSX_BUNDLE_BUNDLE_VERSION 3.0)
+  set(MACOSX_BUNDLE_SHORT_VERSION_STRING "3.0")
+  set(MACOSX_BUNDLE_LONG_VERSION_STRING "3.0.0")
+  set(MACOSX_BUNDLE_ICON_FILE 86Box.icns)
+  set(MACOSX_BUNDLE_INFO_STRING "A emulator of old computers")
+  set(MACOSX_BUNDLE_COPYRIGHT "© 2007-2021 Sarah Walker, Miran Grča, Fred N. van Kempen (waltje), SA1988, MoochMcGee, reenigne, leilei, JohnElliott, greatpsycho, and others")
+
+  
+  # preparing the code signing for easier distribution, Apple dev certificate needed at one point
+  #set(XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED "YES")
+  #set(XCODE_ATTRIBUTE_CODE_SIGN_IDENTITY "-")
+  #set(XCODE_ATTRIBUTE_CODE_SIGN_ENTITLEMENTS ${CMAKE_CURRENT_SOURCE_DIR}/mac/codesign/dev/app.entitlements)
+  
 endif()
 
 find_package(Freetype REQUIRED)
 include_directories(${FREETYPE_INCLUDE_DIRS})
+if(APPLE)
+	target_link_libraries(86Box Freetype::Freetype) # bundles freetype for the macOS app bundle
+endif()
 
 find_package(OpenAL REQUIRED)
 include_directories(${OPENAL_INCLUDE_DIR})
@@ -120,6 +166,18 @@ if(MINITRACE)
 endif()
 
 install(TARGETS 86Box)
+
+
+# adjustments for macOS app bundles
+if(APPLE)
+	set(APPS ${CMAKE_CURRENT_BINARY_DIR}/86Box.app)
+	install(CODE "
+        	include(InstallRequiredSystemLibraries)
+        	include(BundleUtilities)
+        	fixup_bundle(\"${APPS}\" \"\" \"\")"
+    	COMPONENT Runtime)
+endif()
+
 if(VCPKG_TOOLCHAIN)
 	x_vcpkg_install_local_dependencies(TARGETS 86Box DESTINATION "bin")
 endif()