claunia/86Box
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed the packet structure's data field to a 65536-byte array to need less malloc'ing and free'ing, significantly reducing heap fragmentation.

Browse Source
This commit is contained in:
OBattler
2020-05-02 02:09:10 +02:00
parent 3e248fe54a
commit 5b87c654e1
2 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/include/86box/network.h
View File

@@ -71,7 +71,7 @@ typedef int (*NETSETLINKSTATE)(void *);
typedef struct netpkt { typedef struct netpkt {
void *priv; void *priv;
uint8_t *data; uint8_t data[65536]; /* Maximum length + 1 to round up to the nearest power of 2. */
int len; int len;
struct netpkt *prev, *next; struct netpkt *prev, *next;

5
src/network/network.c
View File

@@ -230,7 +230,6 @@ network_queue_put(int tx, void *priv, uint8_t *data, int len)
temp = (netpkt_t *) malloc(sizeof(netpkt_t)); temp = (netpkt_t *) malloc(sizeof(netpkt_t));
memset(temp, 0, sizeof(netpkt_t)); memset(temp, 0, sizeof(netpkt_t));
temp->priv = priv; temp->priv = priv;
temp->data = (uint8_t *) malloc(len);
memcpy(temp->data, data, len); memcpy(temp->data, data, len);
temp->len = len; temp->len = len;
temp->prev = last_pkt[tx]; temp->prev = last_pkt[tx];
@@ -266,8 +265,6 @@ network_queue_advance(int tx)
return; return;
first_pkt[tx] = temp->next; first_pkt[tx] = temp->next;
if (temp->data != NULL)
free(temp->data);
free(temp); free(temp);
if (first_pkt[tx] == NULL) if (first_pkt[tx] == NULL)
@@ -284,8 +281,6 @@ network_queue_clear(int tx)
return; return;
do { do {
if (temp->data != NULL)
free(temp->data);
free(temp); free(temp);
temp = temp->next; temp = temp->next;
} while (temp != NULL); } while (temp != NULL);