Some code smell fixes from sonarlint

2023-05-11 03:02:36 -04:00
parent d314255362
commit 6c1e4a8e2c
137 changed files with 3354 additions and 2900 deletions
--- a/src/device/cartridge.c
+++ b/src/device/cartridge.c
@@ -175,15 +175,13 @@ cart_close(int drive)
 void
 cart_reset(void)
 {
-    int i;
-
    cart_image_close(1);
    cart_image_close(0);

    if (!machine_has_cartridge(machine))
        return;

-    for (i = 0; i < 2; i++) {
+    for (uint8_t i = 0; i < 2; i++) {
        mem_mapping_add(&cart_mappings[i], 0x000d0000, 0x00002000,
                        cart_read, NULL, NULL,
                        NULL, NULL, NULL,