claunia/86Box
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Some code smell fixes from sonarlint

Browse Source
This commit is contained in:
Jasmine Iwanek
2023-05-11 03:02:36 -04:00
parent d314255362
commit 6c1e4a8e2c
137 changed files with 3354 additions and 2900 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/game/gameport.c
View File

@@ -285,7 +285,8 @@ gameport_update_joystick_type(void)
void
gameport_remap(void *priv, uint16_t address)
{
gameport_t *dev = (gameport_t *) priv, *other_dev;
gameport_t *dev = (gameport_t *) priv;
gameport_t *other_dev;
if (dev->addr) {
/* Remove this port from the active ports list. */

9
src/game/joystick_sw_pad.c
View File

@@ -183,10 +183,8 @@ sw_write(void *p)
if (time_since_last > 9900 && time_since_last < 9940) {
sw->poll_mode = 0;
sw->poll_left = 49;
sw->poll_data = 0x2400ull | (0x1830ull << 15) | (0x19b0ull << 30);
sw->poll_data = 0x2400ULL | (0x1830ULL << 15) | (0x19b0ULL << 30);
} else {
int c;
sw->poll_mode = sw->data_mode;
sw->data_mode = !sw->data_mode;
@@ -198,9 +196,8 @@ sw_write(void *p)
sw->poll_data = 1;
}
for (c = 0; c < 4; c++) {
for (uint8_t c = 0; c < 4; c++) {
uint16_t data = 0x3fff;
int b;
if (!JOYSTICK_PRESENT(c))
break;
@@ -214,7 +211,7 @@ sw_write(void *p)
if (joystick_state[c].axis[0] < -16383)
data &= ~8;
for (b = 0; b < 10; b++) {
for (uint8_t b = 0; b < 10; b++) {
if (joystick_state[c].button[b])
data &= ~(1 << (b + 4));
}