Some code smell fixes from sonarlint

This commit is contained in:
Jasmine Iwanek
2023-05-11 03:02:36 -04:00
parent d314255362
commit 6c1e4a8e2c
137 changed files with 3354 additions and 2900 deletions

View File

@@ -224,7 +224,8 @@ upi42_op_XCH_A_Rr(upi42_t *upi42, uint32_t fetchdat)
static int
upi42_op_XCH_A_indRr(upi42_t *upi42, uint32_t fetchdat)
{
uint8_t temp = upi42->a, addr = upi42->ram[fetchdat & 1] & upi42->rammask;
uint8_t temp = upi42->a;
uint8_t addr = upi42->ram[fetchdat & 1] & upi42->rammask;
upi42->a = upi42->ram[addr];
upi42->ram[addr] = temp;
return 1;
@@ -233,7 +234,8 @@ upi42_op_XCH_A_indRr(upi42_t *upi42, uint32_t fetchdat)
static int
upi42_op_XCHD_A_indRr(upi42_t *upi42, uint32_t fetchdat)
{
uint8_t temp = upi42->a, addr = upi42->ram[fetchdat & 1] & upi42->rammask;
uint8_t temp = upi42->a;
uint8_t addr = upi42->ram[fetchdat & 1] & upi42->rammask;
upi42->a = (upi42->a & 0xf0) | (upi42->ram[addr] & 0x0f);
upi42->ram[addr] = (upi42->ram[addr] & 0xf0) | (temp & 0x0f);
return 1;
@@ -1172,7 +1174,8 @@ static void
upi42_write(uint16_t port, uint8_t val, void *priv)
{
upi42_t *upi42 = (upi42_t *) priv;
uint32_t temp_type, uint8_t *temp_rom;
uint32_t temp_type;
uint8_t *temp_rom;
int i;
switch (port) {