claunia/86Box
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix the details screen after deleting every machine

Browse Source
This commit is contained in:
Alexander Babikov
2025-08-08 01:36:24 +05:00
parent 74501db7fc
commit 6ee2e66b56
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/qt/qt_vmmanager_main.cpp
View File

@@ -188,11 +188,19 @@ VMManagerMain::currentSelectionChanged(const QModelIndex &current,
return; return;
} }
/* hack to prevent strange segfaults when adding a machine after
removing all machines previously */
if (selected_sysconfig->config_signal_connected == true) {
disconnect(selected_sysconfig, &VMManagerSystem::configurationChanged, this, &VMManagerMain::onConfigUpdated); disconnect(selected_sysconfig, &VMManagerSystem::configurationChanged, this, &VMManagerMain::onConfigUpdated);
selected_sysconfig->config_signal_connected = false;
}
const auto mapped_index = proxy_model->mapToSource(current); const auto mapped_index = proxy_model->mapToSource(current);
selected_sysconfig = vm_model->getConfigObjectForIndex(mapped_index); selected_sysconfig = vm_model->getConfigObjectForIndex(mapped_index);
vm_details->updateData(selected_sysconfig); vm_details->updateData(selected_sysconfig);
if (selected_sysconfig->config_signal_connected == false) {
connect(selected_sysconfig, &VMManagerSystem::configurationChanged, this, &VMManagerMain::onConfigUpdated); connect(selected_sysconfig, &VMManagerSystem::configurationChanged, this, &VMManagerMain::onConfigUpdated);
selected_sysconfig->config_signal_connected = true;
}
// Emit that the selection changed, include with the process state // Emit that the selection changed, include with the process state
emit selectionChanged(current, selected_sysconfig->process->state()); emit selectionChanged(current, selected_sysconfig->process->state());
@@ -456,6 +464,14 @@ VMManagerMain::deleteSystem(VMManagerSystem *sysconfig)
config->remove(sysconfig->uuid); config->remove(sysconfig->uuid);
vm_model->removeConfigFromModel(sysconfig); vm_model->removeConfigFromModel(sysconfig);
delete sysconfig; delete sysconfig;
if (vm_model->rowCount(QModelIndex()) <= 0) {
/* no machines left - get rid of the last machine's leftovers */
ui->detailsArea->layout()->removeWidget(vm_details);
delete vm_details;
vm_details = new VMManagerDetails();
ui->detailsArea->layout()->addWidget(vm_details);
}
} }
} }

1
src/qt/qt_vmmanager_system.hpp
View File

@@ -136,6 +136,7 @@ public:
QProcess *process = new QProcess(); QProcess *process = new QProcess();
bool window_obscured; bool window_obscured;
bool config_signal_connected = false;
QString getDisplayValue(VMManager::Display::Name key); QString getDisplayValue(VMManager::Display::Name key);
QFileInfoList getScreenshots(); QFileInfoList getScreenshots();