From aa9976d5c6a5a994426a484b2f6da7296ed95783 Mon Sep 17 00:00:00 2001
From: Alexander Babikov <lemondrops358@gmail.com>
Date: Sat, 7 Jun 2025 20:30:51 +0500
Subject: [PATCH] Fix up file filters for filename fields of device configs for
 consistency

- Filter descriptions are now translatable
- Extensions get uppercase and lowercase variations on *nix
- Add "All files" option
---
 src/qt/qt_deviceconfig.cpp | 22 +++++++++++++++++++---
 src/qt/qt_util.cpp         | 23 +++++++++++++++++++++++
 src/qt/qt_util.hpp         |  1 +
 3 files changed, 43 insertions(+), 3 deletions(-)

diff --git a/src/qt/qt_deviceconfig.cpp b/src/qt/qt_deviceconfig.cpp
index 54923be06..255b3c39f 100644
--- a/src/qt/qt_deviceconfig.cpp
+++ b/src/qt/qt_deviceconfig.cpp
@@ -31,6 +31,7 @@
 #include <QLabel>
 #include <QDir>
 #include <QSettings>
+#include <QStringBuilder>
 
 extern "C" {
 #include <86box/86box.h>
@@ -45,6 +46,7 @@ extern "C" {
 
 #include "qt_filefield.hpp"
 #include "qt_models_common.hpp"
+#include "qt_util.hpp"
 #ifdef Q_OS_LINUX
 #    include <sys/stat.h>
 #    include <sys/sysmacros.h>
@@ -276,11 +278,25 @@ DeviceConfig::ProcessConfig(void *dc, const void *c, const bool is_dep)
             }
             case CONFIG_FNAME:
             {
-                auto *fileField = new FileField();
+                auto *fileField = new FileField(this);
                 fileField->setObjectName(config->name);
                 fileField->setFileName(selected);
-                fileField->setFilter(QString(config->file_filter).left(static_cast<int>(strcspn(config->file_filter,
-                                                                                                "|"))));
+                /* Get the actually used part of the filter */
+                QString filter = QString(config->file_filter).left(static_cast<int>(strcspn(config->file_filter, "|")));
+                /* Extract the description and the extension list */
+                QRegularExpressionMatch match = QRegularExpression("(.+) \\((.+)\\)$").match(filter);
+                QString description = match.captured(1);
+                QString extensions = match.captured(2);
+                QStringList extensionList;
+                /* Split the extension list up and strip the filename globs */
+                QRegularExpression re("\\*\\.(.*)");
+                int i = 0;
+                while (extensions.section(' ', i, i) != "") {
+                    QString extension = re.match(extensions.section(' ', i, i)).captured(1);
+                    extensionList.append(extension);
+                    i++;
+                }
+                fileField->setFilter(tr(description.toUtf8().constData()) % util::DlgFilter(extensionList) % tr("All files") % util::DlgFilter({ "*" }, true));
                 this->ui->formLayout->addRow(tr(config->description), fileField);
                 break;
             }
diff --git a/src/qt/qt_util.cpp b/src/qt/qt_util.cpp
index 0c78c2f5e..5baaaaacf 100644
--- a/src/qt/qt_util.cpp
+++ b/src/qt/qt_util.cpp
@@ -92,6 +92,29 @@ DlgFilter(std::initializer_list<QString> extensions, bool last)
     return " (" % temp.join(' ') % ")" % (!last ? ";;" : "");
 }
 
+QString
+DlgFilter(QStringList extensions, bool last)
+{
+    QStringList temp;
+
+    for (auto ext : extensions) {
+#ifdef Q_OS_UNIX
+        if (ext == "*") {
+            temp.append("*");
+            continue;
+        }
+        temp.append("*." % ext.toUpper());
+#endif
+        temp.append("*." % ext);
+    }
+
+#ifdef Q_OS_UNIX
+    temp.removeDuplicates();
+#endif
+    return " (" % temp.join(' ') % ")" % (!last ? ";;" : "");
+}
+
+
 QString currentUuid()
 {
     auto configPath = QFileInfo(cfg_path).dir().canonicalPath();
diff --git a/src/qt/qt_util.hpp b/src/qt/qt_util.hpp
index 9432610b6..e0d2648d0 100644
--- a/src/qt/qt_util.hpp
+++ b/src/qt/qt_util.hpp
@@ -11,6 +11,7 @@ namespace util {
 static constexpr auto UUID_MIN_LENGTH = 36;
 /* Creates extension list for qt filedialog */
 QString DlgFilter(std::initializer_list<QString> extensions, bool last = false);
+QString DlgFilter(QStringList extensions, bool last = false);
 /* Returns screen the widget is on */
 QScreen *screenOfWidget(QWidget *widget);
 #ifdef Q_OS_WINDOWS