From e5d6430ec8375276550ce1cdb32e9942d1e24345 Mon Sep 17 00:00:00 2001 From: cold-brewed Date: Mon, 12 Sep 2022 09:48:14 -0400 Subject: [PATCH] qt: Fix potential null pointer access in media history --- src/qt/qt_mediahistorymanager.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qt/qt_mediahistorymanager.cpp b/src/qt/qt_mediahistorymanager.cpp index a672c0843..884a13de5 100644 --- a/src/qt/qt_mediahistorymanager.cpp +++ b/src/qt/qt_mediahistorymanager.cpp @@ -132,8 +132,9 @@ void MediaHistoryManager::serializeImageHistoryType(ui::MediaType type) continue; } for ( int slot = 0; slot < MAX_PREV_IMAGES; slot++) { - strncpy(device_history_ptr[slot], master_list[type][device][slot].toUtf8().constData(), MAX_IMAGE_PATH_LEN); - + if (device_history_ptr[slot] != nullptr) { + strncpy(device_history_ptr[slot], master_list[type][device][slot].toUtf8().constData(), MAX_IMAGE_PATH_LEN); + } } } }