Yet more sonarlint fixes
This commit is contained in:
@@ -473,7 +473,9 @@ static int
|
||||
elnkReceiveLocked(void *priv, uint8_t *src, int size)
|
||||
{
|
||||
threec501_t *dev = (threec501_t *) priv;
|
||||
int is_padr = 0, is_bcast = 0, is_mcast = 0;
|
||||
int is_padr = 0;
|
||||
int is_bcast = 0;
|
||||
int is_mcast = 0;
|
||||
bool fLoopback = dev->RcvCmd.adr_match == EL_BCTL_LOOPBACK;
|
||||
|
||||
union {
|
||||
@@ -644,7 +646,7 @@ elnkAsyncTransmit(threec501_t *dev)
|
||||
return;
|
||||
}
|
||||
|
||||
if (((dev->AuxCmd.buf_ctl != EL_BCTL_XMT_RCV) && (dev->AuxCmd.buf_ctl != EL_BCTL_LOOPBACK))) {
|
||||
if ((dev->AuxCmd.buf_ctl != EL_BCTL_XMT_RCV) && (dev->AuxCmd.buf_ctl != EL_BCTL_LOOPBACK)) {
|
||||
#ifdef ENABLE_3COM501_LOG
|
||||
threec501_log("3Com501: Nope, not in xmit-then-receive or loopback state\n");
|
||||
#endif
|
||||
@@ -656,8 +658,8 @@ elnkAsyncTransmit(threec501_t *dev)
|
||||
*/
|
||||
do {
|
||||
/* Don't send anything when the link is down. */
|
||||
if ((!elnkIsLinkUp(dev)
|
||||
&& dev->cLinkDownReported > ELNK_MAX_LINKDOWN_REPORTED))
|
||||
if (!elnkIsLinkUp(dev)
|
||||
&& dev->cLinkDownReported > ELNK_MAX_LINKDOWN_REPORTED)
|
||||
break;
|
||||
|
||||
bool const fLoopback = dev->AuxCmd.buf_ctl == EL_BCTL_LOOPBACK;
|
||||
@@ -925,7 +927,7 @@ threec501_read(uint16_t addr, void *priv)
|
||||
#ifdef ENABLE_3COM501_LOG
|
||||
threec501_log("3Com501: read addr %x, value %x\n", addr & 0x0f, retval);
|
||||
#endif
|
||||
return (retval);
|
||||
return retval;
|
||||
}
|
||||
|
||||
static uint8_t
|
||||
@@ -1130,7 +1132,7 @@ threec501_nic_init(const device_t *info)
|
||||
|
||||
timer_add(&dev->timer_restore, elnkR3TimerRestore, dev, 0);
|
||||
|
||||
return (dev);
|
||||
return dev;
|
||||
}
|
||||
|
||||
static void
|
||||
|
||||
@@ -239,7 +239,7 @@ threec503_nic_lo_read(uint16_t addr, void *priv)
|
||||
break;
|
||||
}
|
||||
|
||||
return (retval);
|
||||
return retval;
|
||||
}
|
||||
|
||||
static void
|
||||
@@ -611,7 +611,7 @@ threec503_nic_init(const device_t *info)
|
||||
/* Attach ourselves to the network module. */
|
||||
dev->dp8390->card = network_attach(dev->dp8390, dev->dp8390->physaddr, dp8390_rx, NULL);
|
||||
|
||||
return (dev);
|
||||
return dev;
|
||||
}
|
||||
|
||||
static void
|
||||
|
||||
@@ -63,13 +63,13 @@ mcast_index(const void *dst)
|
||||
{
|
||||
#define POLYNOMIAL 0x04c11db6
|
||||
uint32_t crc = 0xffffffffL;
|
||||
int carry, i, j;
|
||||
int carry;
|
||||
uint8_t b;
|
||||
uint8_t *ep = (uint8_t *) dst;
|
||||
|
||||
for (i = 6; --i >= 0;) {
|
||||
for (int8_t i = 6; --i >= 0;) {
|
||||
b = *ep++;
|
||||
for (j = 8; --j >= 0;) {
|
||||
for (int8_t j = 8; --j >= 0;) {
|
||||
carry = ((crc & 0x80000000L) ? 1 : 0) ^ (b & 0x01);
|
||||
crc <<= 1;
|
||||
b >>= 1;
|
||||
@@ -93,7 +93,6 @@ mcast_index(const void *dst)
|
||||
uint32_t
|
||||
dp8390_chipmem_read(dp8390_t *dev, uint32_t addr, unsigned int len)
|
||||
{
|
||||
int i;
|
||||
uint32_t retval = 0;
|
||||
|
||||
#ifdef ENABLE_DP8390_LOG
|
||||
@@ -104,7 +103,7 @@ dp8390_chipmem_read(dp8390_t *dev, uint32_t addr, unsigned int len)
|
||||
dp8390_log("DP8390: Chipmem Read Address=%04x\n", addr);
|
||||
|
||||
/* ROM'd MAC address */
|
||||
for (i = 0; i < len; i++) {
|
||||
for (unsigned int i = 0; i < len; i++) {
|
||||
if ((addr >= dev->mem_start) && (addr < dev->mem_end))
|
||||
retval |= (uint32_t) (dev->mem[addr - dev->mem_start]) << (i << 3);
|
||||
else if (addr < dev->macaddr_size)
|
||||
@@ -116,14 +115,12 @@ dp8390_chipmem_read(dp8390_t *dev, uint32_t addr, unsigned int len)
|
||||
addr++;
|
||||
}
|
||||
|
||||
return (retval);
|
||||
return retval;
|
||||
}
|
||||
|
||||
void
|
||||
dp8390_chipmem_write(dp8390_t *dev, uint32_t addr, uint32_t val, unsigned len)
|
||||
{
|
||||
int i;
|
||||
|
||||
#ifdef ENABLE_DP8390_LOG
|
||||
if ((len > 1) && (addr & (len - 1)))
|
||||
dp8390_log("DP8390: unaligned chipmem word write\n");
|
||||
@@ -131,7 +128,7 @@ dp8390_chipmem_write(dp8390_t *dev, uint32_t addr, uint32_t val, unsigned len)
|
||||
|
||||
dp8390_log("DP8390: Chipmem Write Address=%04x\n", addr);
|
||||
|
||||
for (i = 0; i < len; i++) {
|
||||
for (unsigned int i = 0; i < len; i++) {
|
||||
if ((addr < dev->mem_start) || (addr >= dev->mem_end)) {
|
||||
dp8390_log("DP8390: out-of-bounds chipmem write, %04X\n", addr);
|
||||
return;
|
||||
@@ -152,7 +149,7 @@ dp8390_read_cr(dp8390_t *dev)
|
||||
retval = (((dev->CR.pgsel & 0x03) << 6) | ((dev->CR.rdma_cmd & 0x07) << 3) | (dev->CR.tx_packet << 2) | (dev->CR.start << 1) | (dev->CR.stop));
|
||||
dp8390_log("DP8390: read CR returns 0x%02x\n", retval);
|
||||
|
||||
return (retval);
|
||||
return retval;
|
||||
}
|
||||
|
||||
void
|
||||
@@ -270,8 +267,10 @@ dp8390_rx_common(void *priv, uint8_t *buf, int io_len)
|
||||
static uint8_t bcast_addr[6] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
|
||||
uint8_t pkthdr[4];
|
||||
uint8_t *startptr;
|
||||
int pages, avail;
|
||||
int idx, nextpage;
|
||||
int pages;
|
||||
int avail;
|
||||
int idx;
|
||||
int nextpage;
|
||||
int endbytes;
|
||||
|
||||
if (io_len != 60)
|
||||
@@ -427,7 +426,7 @@ dp8390_page0_read(dp8390_t *dev, uint32_t off, unsigned int len)
|
||||
/* encountered with win98 hardware probe */
|
||||
dp8390_log("DP8390: bad length! Page0 read from register 0x%02x, len=%u\n",
|
||||
off, len);
|
||||
return (retval);
|
||||
return retval;
|
||||
}
|
||||
|
||||
switch (off) {
|
||||
@@ -503,7 +502,7 @@ dp8390_page0_read(dp8390_t *dev, uint32_t off, unsigned int len)
|
||||
dp8390_log("DP8390: Page0 read from register 0x%02x, value=0x%02x\n", off,
|
||||
retval);
|
||||
|
||||
return (retval);
|
||||
return retval;
|
||||
}
|
||||
|
||||
void
|
||||
@@ -730,7 +729,7 @@ dp8390_page1_read(dp8390_t *dev, uint32_t off, unsigned int len)
|
||||
default:
|
||||
dp8390_log("DP8390: Page1 read register 0x%02x out of range\n",
|
||||
off);
|
||||
return (0);
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -812,7 +811,7 @@ dp8390_page2_read(dp8390_t *dev, uint32_t off, unsigned int len)
|
||||
case 0x0b:
|
||||
dp8390_log("DP8390: reserved Page2 read - register 0x%02x\n",
|
||||
off);
|
||||
return (0xff);
|
||||
return 0xff;
|
||||
|
||||
case 0x0c: /* RCR */
|
||||
return ((dev->RCR.monitor << 5) | (dev->RCR.promisc << 4) | (dev->RCR.multicast << 3) | (dev->RCR.broadcast << 2) | (dev->RCR.runts_ok << 1) | (dev->RCR.errors_ok));
|
||||
@@ -832,7 +831,7 @@ dp8390_page2_read(dp8390_t *dev, uint32_t off, unsigned int len)
|
||||
break;
|
||||
}
|
||||
|
||||
return (0);
|
||||
return 0;
|
||||
}
|
||||
|
||||
void
|
||||
@@ -931,7 +930,8 @@ dp8390_set_id(dp8390_t *dev, uint8_t id0, uint8_t id1)
|
||||
void
|
||||
dp8390_reset(dp8390_t *dev)
|
||||
{
|
||||
int i, max, shift = 0;
|
||||
int max;
|
||||
int shift = 0;
|
||||
|
||||
if (dev->flags & DP8390_FLAG_EVEN_MAC)
|
||||
shift = 1;
|
||||
@@ -939,7 +939,7 @@ dp8390_reset(dp8390_t *dev)
|
||||
max = 16 << shift;
|
||||
|
||||
/* Initialize the MAC address area by doubling the physical address */
|
||||
for (i = 0; i < max; i++) {
|
||||
for (int i = 0; i < max; i++) {
|
||||
if (i < (6 << shift))
|
||||
dev->macaddr[i] = dev->physaddr[i >> shift];
|
||||
else /* Signature */
|
||||
|
||||
@@ -251,7 +251,7 @@ asic_read(nic_t *dev, uint32_t off, unsigned int len)
|
||||
break;
|
||||
}
|
||||
|
||||
return (retval);
|
||||
return retval;
|
||||
}
|
||||
|
||||
static void
|
||||
@@ -316,7 +316,7 @@ page3_read(nic_t *dev, uint32_t off, unsigned int len)
|
||||
return (dev->_9346cr);
|
||||
|
||||
case 0x3: /* CONFIG0 */
|
||||
return (0x00); /* Cable not BNC */
|
||||
return 0x00; /* Cable not BNC */
|
||||
|
||||
case 0x5: /* CONFIG2 */
|
||||
return (dev->config2 & 0xe0);
|
||||
@@ -329,12 +329,12 @@ page3_read(nic_t *dev, uint32_t off, unsigned int len)
|
||||
|
||||
case 0xe: /* 8029ASID0 */
|
||||
if (dev->board == NE2K_RTL8029AS)
|
||||
return (0x29);
|
||||
return 0x29;
|
||||
break;
|
||||
|
||||
case 0xf: /* 8029ASID1 */
|
||||
if (dev->board == NE2K_RTL8029AS)
|
||||
return (0x80);
|
||||
return 0x80;
|
||||
break;
|
||||
|
||||
default:
|
||||
@@ -342,7 +342,7 @@ page3_read(nic_t *dev, uint32_t off, unsigned int len)
|
||||
}
|
||||
|
||||
nelog(3, "%s: Page3 read register 0x%02x attempted\n", dev->name, off);
|
||||
return (0x00);
|
||||
return 0x00;
|
||||
}
|
||||
|
||||
static void
|
||||
@@ -409,7 +409,7 @@ nic_read(nic_t *dev, uint32_t addr, unsigned len)
|
||||
break;
|
||||
}
|
||||
|
||||
return (retval);
|
||||
return retval;
|
||||
}
|
||||
|
||||
static uint8_t
|
||||
@@ -711,7 +711,7 @@ nic_pci_read(int func, int addr, void *priv)
|
||||
|
||||
nelog(2, "%s: PCI_Read(%d, %04x) = %02x\n", dev->name, func, addr, ret);
|
||||
|
||||
return (ret);
|
||||
return ret;
|
||||
}
|
||||
|
||||
static void
|
||||
@@ -1095,7 +1095,7 @@ nic_init(const device_t *info)
|
||||
nelog(1, "%s: %s attached IO=0x%X IRQ=%d\n", dev->name,
|
||||
dev->is_pci ? "PCI" : "ISA", dev->base_address, dev->base_irq);
|
||||
|
||||
return (dev);
|
||||
return dev;
|
||||
}
|
||||
|
||||
static void
|
||||
|
||||
@@ -357,7 +357,7 @@ int
|
||||
net_pcap_prepare(netdev_t *list)
|
||||
{
|
||||
char errbuf[PCAP_ERRBUF_SIZE];
|
||||
pcap_if_t *devlist, *dev;
|
||||
pcap_if_t *devlist;
|
||||
int i = 0;
|
||||
|
||||
/* Try loading the DLL. */
|
||||
@@ -379,7 +379,7 @@ net_pcap_prepare(netdev_t *list)
|
||||
return (-1);
|
||||
}
|
||||
|
||||
for (dev = devlist; dev != NULL; dev = dev->next) {
|
||||
for (pcap_if_t *dev = devlist; dev != NULL; dev = dev->next) {
|
||||
if (i >= (NET_HOST_INTF_MAX - 1))
|
||||
break;
|
||||
|
||||
@@ -405,7 +405,7 @@ net_pcap_prepare(netdev_t *list)
|
||||
/* Release the memory. */
|
||||
f_pcap_freealldevs(devlist);
|
||||
|
||||
return (i);
|
||||
return i;
|
||||
}
|
||||
|
||||
/*
|
||||
|
||||
@@ -446,7 +446,8 @@ pcnetIsLinkUp(nic_t *dev)
|
||||
static __inline int
|
||||
pcnetTmdLoad(nic_t *dev, TMD *tmd, uint32_t addr, int fRetIfNotOwn)
|
||||
{
|
||||
uint8_t ownbyte, bytes[4] = { 0, 0, 0, 0 };
|
||||
uint8_t ownbyte;
|
||||
uint8_t bytes[4] = { 0, 0, 0, 0 };
|
||||
uint16_t xda[4];
|
||||
uint32_t xda32[4];
|
||||
|
||||
@@ -539,7 +540,8 @@ pcnetTmdStorePassHost(nic_t *dev, TMD *tmd, uint32_t addr)
|
||||
static __inline int
|
||||
pcnetRmdLoad(nic_t *dev, RMD *rmd, uint32_t addr, int fRetIfNotOwn)
|
||||
{
|
||||
uint8_t ownbyte, bytes[4] = { 0, 0, 0, 0 };
|
||||
uint8_t ownbyte;
|
||||
uint8_t bytes[4] = { 0, 0, 0, 0 };
|
||||
uint16_t rda[4];
|
||||
uint32_t rda32[4];
|
||||
|
||||
@@ -654,10 +656,10 @@ lnc_mchash(const uint8_t *ether_addr)
|
||||
{
|
||||
#define LNC_POLYNOMIAL 0xEDB88320UL
|
||||
uint32_t crc = 0xFFFFFFFF;
|
||||
int idx, bit;
|
||||
int bit;
|
||||
uint8_t data;
|
||||
|
||||
for (idx = 0; idx < ETHER_ADDR_LEN; idx++) {
|
||||
for (uint8_t idx = 0; idx < ETHER_ADDR_LEN; idx++) {
|
||||
for (data = *ether_addr++, bit = 0; bit < MULTICAST_FILTER_LEN; bit++) {
|
||||
crc = (crc >> 1) ^ (((crc ^ data) & 1) ? LNC_POLYNOMIAL : 0);
|
||||
data >>= 1;
|
||||
@@ -915,7 +917,6 @@ pcnetUpdateIrq(nic_t *dev)
|
||||
static void
|
||||
pcnetInit(nic_t *dev)
|
||||
{
|
||||
int i;
|
||||
pcnet_log(3, "%s: pcnetInit: init_addr=%#010x\n", dev->name, PHYSADDR(dev, CSR_IADR(dev)));
|
||||
|
||||
/** @todo Documentation says that RCVRL and XMTRL are stored as two's complement!
|
||||
@@ -956,7 +957,7 @@ pcnetInit(nic_t *dev)
|
||||
#undef PCNET_INIT
|
||||
|
||||
size_t cbRxBuffers = 0;
|
||||
for (i = CSR_RCVRL(dev); i >= 1; i--) {
|
||||
for (int i = CSR_RCVRL(dev); i >= 1; i--) {
|
||||
RMD rmd;
|
||||
uint32_t rdaddr = PHYSADDR(dev, pcnetRdraAddr(dev, i));
|
||||
|
||||
@@ -1200,8 +1201,10 @@ pcnetCalcPacketLen(nic_t *dev, int cb)
|
||||
static int
|
||||
pcnetReceiveNoSync(void *priv, uint8_t *buf, int size)
|
||||
{
|
||||
nic_t *dev = (nic_t *) priv;
|
||||
int is_padr = 0, is_bcast = 0, is_ladr = 0;
|
||||
nic_t *dev = (nic_t *) priv;
|
||||
int is_padr = 0;
|
||||
int is_bcast = 0;
|
||||
int is_ladr = 0;
|
||||
uint32_t iRxDesc;
|
||||
int cbPacket;
|
||||
uint8_t buf1[60];
|
||||
@@ -1266,7 +1269,8 @@ pcnetReceiveNoSync(void *priv, uint8_t *buf, int size)
|
||||
uint8_t *src = &dev->abRecvBuf[8];
|
||||
uint32_t crda = CSR_CRDA(dev);
|
||||
uint32_t next_crda;
|
||||
RMD rmd, next_rmd;
|
||||
RMD rmd;
|
||||
RMD next_rmd;
|
||||
|
||||
/*
|
||||
* Ethernet framing considers these two octets to be
|
||||
@@ -1473,8 +1477,8 @@ pcnetAsyncTransmit(nic_t *dev)
|
||||
break;
|
||||
|
||||
/* Don't continue sending packets when the link is down. */
|
||||
if ((!pcnetIsLinkUp(dev)
|
||||
&& dev->cLinkDownReported > PCNET_MAX_LINKDOWN_REPORTED))
|
||||
if (!pcnetIsLinkUp(dev)
|
||||
&& dev->cLinkDownReported > PCNET_MAX_LINKDOWN_REPORTED)
|
||||
break;
|
||||
|
||||
pcnet_log(3, "%s: TMDLOAD %#010x\n", dev->name, PHYSADDR(dev, CSR_CXDA(dev)));
|
||||
@@ -1488,7 +1492,7 @@ pcnetAsyncTransmit(nic_t *dev)
|
||||
const int cb = 4096 - tmd.tmd1.bcnt;
|
||||
pcnet_log(3, "%s: pcnetAsyncTransmit: stp&enp: cb=%d xmtrc=%#x\n", dev->name, cb, CSR_XMTRC(dev));
|
||||
|
||||
if ((pcnetIsLinkUp(dev) || fLoopback)) {
|
||||
if (pcnetIsLinkUp(dev) || fLoopback) {
|
||||
|
||||
/* From the manual: ``A zero length buffer is acceptable as
|
||||
* long as it is not the last buffer in a chain (STP = 0 and
|
||||
@@ -2024,7 +2028,10 @@ static uint16_t
|
||||
pcnet_mii_readw(nic_t *dev, uint16_t miiaddr)
|
||||
{
|
||||
uint16_t val;
|
||||
int autoneg, duplex, fast, isolate;
|
||||
int autoneg;
|
||||
int duplex;
|
||||
int fast;
|
||||
int isolate;
|
||||
|
||||
/* If the DANAS (BCR32.7) bit is set, the MAC does not do any
|
||||
* auto-negotiation and the PHY must be set up explicitly. DANAS
|
||||
@@ -2238,7 +2245,7 @@ pcnet_byte_read(nic_t *dev, uint32_t addr)
|
||||
|
||||
pcnet_log(3, "%s: pcnet_word_read: addr = %04x, val = %04x, DWIO not set = %04x\n", dev->name, addr & 0x0f, val, !BCR_DWIO(dev));
|
||||
|
||||
return (val);
|
||||
return val;
|
||||
}
|
||||
|
||||
static uint16_t
|
||||
@@ -2276,7 +2283,7 @@ pcnet_word_read(nic_t *dev, uint32_t addr)
|
||||
skip_update_irq:
|
||||
pcnet_log(3, "%s: pcnet_word_read: addr = %04x, val = %04x, DWIO not set = %04x\n", dev->name, addr & 0x0f, val, !BCR_DWIO(dev));
|
||||
|
||||
return (val);
|
||||
return val;
|
||||
}
|
||||
|
||||
static void
|
||||
@@ -2300,7 +2307,7 @@ pcnet_dword_write(nic_t *dev, uint32_t addr, uint32_t val)
|
||||
/* switch device to dword i/o mode */
|
||||
pcnet_bcr_writew(dev, BCR_BSBC, pcnet_bcr_readw(dev, BCR_BSBC) | 0x0080);
|
||||
pcnet_log(3, "%s: device switched into dword i/o mode\n", dev->name);
|
||||
};
|
||||
}
|
||||
}
|
||||
|
||||
static uint32_t
|
||||
@@ -2334,7 +2341,7 @@ pcnet_dword_read(nic_t *dev, uint32_t addr)
|
||||
|
||||
skip_update_irq:
|
||||
pcnet_log(3, "%s: Read Long mode, addr = %08x, val = %08x\n", dev->name, addr, val);
|
||||
return (val);
|
||||
return val;
|
||||
}
|
||||
|
||||
static void
|
||||
@@ -2424,7 +2431,7 @@ pcnet_read(nic_t *dev, uint32_t addr, int len)
|
||||
}
|
||||
|
||||
pcnet_log(3, "%s: value in read - %08x\n", dev->name, retval);
|
||||
return (retval);
|
||||
return retval;
|
||||
}
|
||||
|
||||
static uint8_t
|
||||
@@ -2682,7 +2689,7 @@ pcnet_pci_read(int func, int addr, void *p)
|
||||
return 0xff;
|
||||
}
|
||||
|
||||
return (0);
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void
|
||||
@@ -3005,7 +3012,7 @@ pcnet_init(const device_t *info)
|
||||
|
||||
timer_add(&dev->timer_restore, pcnetTimerRestore, dev, 0);
|
||||
|
||||
return (dev);
|
||||
return dev;
|
||||
}
|
||||
|
||||
static void
|
||||
|
||||
@@ -416,7 +416,10 @@ net_slirp_init(const netcard_t *card, const uint8_t *mac_addr, void *priv, char
|
||||
}
|
||||
|
||||
/* Set up port forwarding. */
|
||||
int udp, external, internal, i = 0;
|
||||
int udp;
|
||||
int i = 0;
|
||||
int external;
|
||||
int internal;
|
||||
char category[32];
|
||||
snprintf(category, sizeof(category), "SLiRP Port Forwarding #%d", card->card_num + 1);
|
||||
char key[20];
|
||||
|
||||
@@ -253,7 +253,6 @@ void net_vde_error(char *errbuf, const char *message) {
|
||||
//-
|
||||
void *net_vde_init(const netcard_t *card, const uint8_t *mac_addr, void *priv, char *netdrv_errbuf) {
|
||||
struct vde_open_args vde_args;
|
||||
int i;
|
||||
|
||||
char *socket_name = (char *) priv;
|
||||
|
||||
@@ -288,7 +287,7 @@ void *net_vde_init(const netcard_t *card, const uint8_t *mac_addr, void *priv, c
|
||||
}
|
||||
vde_log("VDE: Socket opened (%s).\n", socket_name);
|
||||
|
||||
for(i=0; i < VDE_PKT_BATCH; i++) {
|
||||
for(uint8_t i = 0; i < VDE_PKT_BATCH; i++) {
|
||||
vde->pktv[i].data = calloc(1, NET_MAX_FRAME);
|
||||
}
|
||||
vde->pkt.data = calloc(1,NET_MAX_FRAME);
|
||||
|
||||
@@ -194,9 +194,9 @@ wd_ram_write(uint32_t addr, uint8_t val, void *priv)
|
||||
static int
|
||||
wd_get_irq_index(wd_t *dev)
|
||||
{
|
||||
uint8_t i, irq = 255;
|
||||
uint8_t irq = 255;
|
||||
|
||||
for (i = 0; i < 4; i++) {
|
||||
for (uint8_t i = 0; i < 4; i++) {
|
||||
if (we_int_table[i] == dev->irq)
|
||||
irq = i;
|
||||
}
|
||||
@@ -285,7 +285,7 @@ wd_smc_read(wd_t *dev, uint32_t off)
|
||||
wdlog("%s: ASIC read addr=0x%02x, value=0x%04x\n",
|
||||
dev->name, (unsigned) off, (unsigned) retval);
|
||||
|
||||
return (retval);
|
||||
return retval;
|
||||
}
|
||||
|
||||
static void
|
||||
@@ -423,7 +423,7 @@ wd_read(uint16_t addr, void *priv, int len)
|
||||
}
|
||||
}
|
||||
|
||||
return (retval);
|
||||
return retval;
|
||||
}
|
||||
|
||||
static uint8_t
|
||||
@@ -776,7 +776,7 @@ wd_init(const device_t *info)
|
||||
dev->base_address, dev->irq, dev->ram_addr);
|
||||
}
|
||||
|
||||
return (dev);
|
||||
return dev;
|
||||
}
|
||||
|
||||
static void
|
||||
|
||||
@@ -552,15 +552,13 @@ network_close(void)
|
||||
void
|
||||
network_reset(void)
|
||||
{
|
||||
int i = -1;
|
||||
|
||||
ui_sb_update_icon(SB_NETWORK, 0);
|
||||
|
||||
#if defined ENABLE_NETWORK_LOG && !defined(_WIN32)
|
||||
network_dump_mutex = thread_create_mutex();
|
||||
#endif
|
||||
|
||||
for (i = 0; i < NET_CARD_MAX; i++) {
|
||||
for (uint8_t i = 0; i < NET_CARD_MAX; i++) {
|
||||
if (!network_dev_available(i)) {
|
||||
continue;
|
||||
}
|
||||
@@ -656,15 +654,13 @@ network_is_connected(int id)
|
||||
int
|
||||
network_dev_to_id(char *devname)
|
||||
{
|
||||
int i = 0;
|
||||
|
||||
for (i = 0; i < network_ndev; i++) {
|
||||
for (int i = 0; i < network_ndev; i++) {
|
||||
if (!strcmp((char *) network_devs[i].device, devname)) {
|
||||
return (i);
|
||||
return i;
|
||||
}
|
||||
}
|
||||
|
||||
return (-1);
|
||||
return -1;
|
||||
}
|
||||
|
||||
/* UI */
|
||||
@@ -673,7 +669,7 @@ network_dev_available(int id)
|
||||
{
|
||||
int available = (net_cards_conf[id].device_num > 0);
|
||||
|
||||
if ((net_cards_conf[id].net_type == NET_TYPE_PCAP && (network_dev_to_id(net_cards_conf[id].host_dev_name) <= 0)))
|
||||
if (net_cards_conf[id].net_type == NET_TYPE_PCAP && (network_dev_to_id(net_cards_conf[id].host_dev_name) <= 0))
|
||||
available = 0;
|
||||
|
||||
// TODO: Handle VDE device
|
||||
@@ -700,7 +696,7 @@ network_card_available(int card)
|
||||
if (net_cards[card])
|
||||
return (device_available(net_cards[card]));
|
||||
|
||||
return (1);
|
||||
return 1;
|
||||
}
|
||||
|
||||
/* UI */
|
||||
@@ -715,7 +711,7 @@ int
|
||||
network_card_has_config(int card)
|
||||
{
|
||||
if (!net_cards[card])
|
||||
return (0);
|
||||
return 0;
|
||||
|
||||
return (device_has_config(net_cards[card]) ? 1 : 0);
|
||||
}
|
||||
@@ -735,9 +731,9 @@ network_card_get_from_internal_name(char *s)
|
||||
|
||||
while (net_cards[c] != NULL) {
|
||||
if (!strcmp((char *) net_cards[c]->internal_name, s))
|
||||
return (c);
|
||||
return c;
|
||||
c++;
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -87,7 +87,7 @@ static int
|
||||
get_devlist(capdev_t *list)
|
||||
{
|
||||
char errbuf[PCAP_ERRBUF_SIZE];
|
||||
pcap_if_t *devlist, *dev;
|
||||
pcap_if_t *devlist;
|
||||
int i = 0;
|
||||
|
||||
/* Retrieve the device list from the local machine */
|
||||
@@ -96,7 +96,7 @@ get_devlist(capdev_t *list)
|
||||
return (-1);
|
||||
}
|
||||
|
||||
for (dev = devlist; dev != NULL; dev = dev->next) {
|
||||
for (pcap_if_t *dev = devlist; dev != NULL; dev = dev->next) {
|
||||
strcpy(list->device, dev->name);
|
||||
if (dev->description)
|
||||
strcpy(list->description, dev->description);
|
||||
@@ -109,7 +109,7 @@ get_devlist(capdev_t *list)
|
||||
/* Release the memory. */
|
||||
f_pcap_freealldevs(devlist);
|
||||
|
||||
return (i);
|
||||
return i;
|
||||
}
|
||||
|
||||
/* Simple HEXDUMP routine for raw data. */
|
||||
@@ -127,7 +127,7 @@ hex_dump(unsigned char *bufp, int len)
|
||||
printf("%04lx %02x", addr, c);
|
||||
else
|
||||
printf(" %02x", c);
|
||||
asci[(addr & 15)] = (uint8_t) isprint(c) ? c : '.';
|
||||
asci[addr & 15] = (uint8_t) isprint(c) ? c : '.';
|
||||
if ((++addr % 16) == 0) {
|
||||
asci[16] = '\0';
|
||||
printf(" | %s |\n", asci);
|
||||
@@ -137,7 +137,7 @@ hex_dump(unsigned char *bufp, int len)
|
||||
if (addr % 16) {
|
||||
while (addr % 16) {
|
||||
printf(" ");
|
||||
asci[(addr & 15)] = ' ';
|
||||
asci[addr & 15] = ' ';
|
||||
addr++;
|
||||
}
|
||||
asci[16] = '\0';
|
||||
@@ -166,7 +166,7 @@ eth_prhdr(unsigned char *ptr)
|
||||
type = (ptr[12] << 8) | ptr[13];
|
||||
printf(" type %04x\n", type);
|
||||
|
||||
return (14);
|
||||
return 14;
|
||||
}
|
||||
|
||||
/* Capture packets from the network, and print them. */
|
||||
@@ -189,7 +189,7 @@ start_cap(char *dev)
|
||||
temp);
|
||||
if (pcap == NULL) {
|
||||
fprintf(stderr, "Pcap: open_live(%s): %s\n", dev, temp);
|
||||
return (2);
|
||||
return 2;
|
||||
}
|
||||
|
||||
printf("Listening on '%s'..\n", dev);
|
||||
@@ -217,19 +217,17 @@ start_cap(char *dev)
|
||||
/* All done, close up. */
|
||||
f_pcap_close(pcap);
|
||||
|
||||
return (0);
|
||||
return 0;
|
||||
}
|
||||
|
||||
/* Show a list of available network interfaces. */
|
||||
static void
|
||||
show_devs(capdev_t *list, int num)
|
||||
{
|
||||
int i;
|
||||
|
||||
if (num > 0) {
|
||||
printf("Available network interfaces:\n\n");
|
||||
|
||||
for (i = 0; i < num; i++) {
|
||||
for (int i = 0; i < num; i++) {
|
||||
printf(" %d - %s\n", i + 1, list->device);
|
||||
if (list->description[0] != '\0')
|
||||
printf(" (%s)\n", list->description);
|
||||
@@ -247,7 +245,8 @@ int
|
||||
main(int argc, char **argv)
|
||||
{
|
||||
capdev_t interfaces[32];
|
||||
int numdev, i;
|
||||
int numdev;
|
||||
int i;
|
||||
|
||||
/* Try loading the DLL. */
|
||||
#ifdef _WIN32
|
||||
@@ -263,7 +262,7 @@ main(int argc, char **argv)
|
||||
#else
|
||||
fprintf(stderr, "Unable to load libpcap.so !\n");
|
||||
#endif
|
||||
return (1);
|
||||
return 1;
|
||||
}
|
||||
|
||||
/* Get the list. */
|
||||
@@ -275,7 +274,7 @@ main(int argc, char **argv)
|
||||
|
||||
dynld_close(pcap_handle);
|
||||
|
||||
return (numdev);
|
||||
return numdev;
|
||||
}
|
||||
|
||||
/* Assume argument to be the interface number to listen on. */
|
||||
@@ -285,7 +284,7 @@ main(int argc, char **argv)
|
||||
|
||||
dynld_close(pcap_handle);
|
||||
|
||||
return (1);
|
||||
return 1;
|
||||
}
|
||||
|
||||
/* Looks good, go and listen.. */
|
||||
@@ -293,5 +292,5 @@ main(int argc, char **argv)
|
||||
|
||||
dynld_close(pcap_handle);
|
||||
|
||||
return (i);
|
||||
return i;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user