claunia/SabreTools
1
0
Fork 0
mirror of https://github.com/claunia/SabreTools.git synced 2025-12-16 19:14:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify conditional source update

Browse Source
This commit is contained in:
Matt Nadareski
2025-01-06 15:56:48 -05:00
parent 8d845df8b9
commit 02cdfb53ae
1 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
SabreTools.DatItems/DatItem.cs
View File

@@ -170,7 +170,6 @@ namespace SabreTools.DatItems
/// <param name="item">Existing item to copy information from</param> /// <param name="item">Existing item to copy information from</param>
/// <remarks> /// <remarks>
/// The cases when Source data is updated: /// The cases when Source data is updated:
/// - Current source data is missing and the other item has a source
/// - Current source data has an index higher than the other item /// - Current source data has an index higher than the other item
/// </remarks> /// </remarks>
public void ConditionalUpdateSource(DatItem item) public void ConditionalUpdateSource(DatItem item)
@@ -179,19 +178,6 @@ namespace SabreTools.DatItems
Source? selfSource = GetFieldValue<Source?>(DatItem.SourceKey); Source? selfSource = GetFieldValue<Source?>(DatItem.SourceKey);
Source? itemSource = item.GetFieldValue<Source?>(DatItem.SourceKey); Source? itemSource = item.GetFieldValue<Source?>(DatItem.SourceKey);
// If both sources are missing, do nothing
if (selfSource == null && itemSource == null)
return;
// Use the new source if missing
if (selfSource == null && itemSource != null)
{
SetFieldValue<Source?>(DatItem.SourceKey, itemSource.Clone() as Source);
CopyMachineInformation(item);
SetName(item.GetName());
return;
}
// If either source is missing // If either source is missing
if (selfSource == null || itemSource == null) if (selfSource == null || itemSource == null)
return; return;