From 0e97b2025a50bcbc2b8cbc9777d6ad09a3f60f31 Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Mon, 15 Jul 2024 21:39:25 -0400 Subject: [PATCH] Add notes around GetFileStream --- SabreTools.DatTools/Rebuilder.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/SabreTools.DatTools/Rebuilder.cs b/SabreTools.DatTools/Rebuilder.cs index 77501ee9..a3344d7f 100644 --- a/SabreTools.DatTools/Rebuilder.cs +++ b/SabreTools.DatTools/Rebuilder.cs @@ -745,6 +745,8 @@ namespace SabreTools.DatTools BaseArchive? archive = BaseArchive.Create(file); if (archive != null) { + // TODO: Write entry to a temporary file to avoid over-large in-memory streams + // TODO: Once entry is written, replace GetEntryStream implementations ItemType itemType = datItem.GetStringFieldValue(Models.Metadata.DatItem.TypeKey).AsEnumValue(); (stream, _) = archive.GetEntryStream(datItem.GetName() ?? itemType.AsStringValue() ?? string.Empty); }