From 4066516c7b2752d945451bfb6ff9802c6aa5d2d4 Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Wed, 19 Feb 2025 13:44:30 -0500 Subject: [PATCH] Update both Remover and Setter tests again --- SabreTools.Test/RemoverTests.cs | 4 ++-- SabreTools.Test/SetterTests.cs | 29 ++++++++++------------------- 2 files changed, 12 insertions(+), 21 deletions(-) diff --git a/SabreTools.Test/RemoverTests.cs b/SabreTools.Test/RemoverTests.cs index a2e19fb0..330331af 100644 --- a/SabreTools.Test/RemoverTests.cs +++ b/SabreTools.Test/RemoverTests.cs @@ -8,7 +8,7 @@ namespace SabreTools.Test public class RemoverTests { [Fact] - public void RemoveFieldsDatItemTest() + public void RemoveFields_DatItem() { var datItem = new Rom(); datItem.SetName("foo"); @@ -21,7 +21,7 @@ namespace SabreTools.Test } [Fact] - public void RemoveFieldsMachineTest() + public void RemoveFields_Machine() { var machine = new Machine(); machine.SetFieldValue(Models.Metadata.Machine.NameKey, "bar"); diff --git a/SabreTools.Test/SetterTests.cs b/SabreTools.Test/SetterTests.cs index c03a545c..715ddb28 100644 --- a/SabreTools.Test/SetterTests.cs +++ b/SabreTools.Test/SetterTests.cs @@ -9,39 +9,30 @@ namespace SabreTools.Test public class SetterTests { [Fact] - public void SetFieldsDatItemTest() + public void SetFields_DatItem() { - var datItem = CreateDatItem(); + var datItem = new Rom(); + datItem.SetName("foo"); + var setter = new Setter(); setter.PopulateSetters(new FilterKey("datitem", "name"), "bar"); setter.SetFields(datItem); + Assert.Equal("bar", datItem.GetName()); } [Fact] - public void SetFieldsMachineTest() - { - var datItem = CreateDatItem(); - var setter = new Setter(); - setter.PopulateSetters(new FilterKey("machine", "name"), "foo"); - setter.SetFields(datItem.GetFieldValue(DatItem.MachineKey)); - Assert.Equal("foo", datItem.GetFieldValue(DatItem.MachineKey)!.GetStringFieldValue(Models.Metadata.Machine.NameKey)); - } - - /// - /// Generate a consistent DatItem for testing - /// - private static DatItem CreateDatItem() + public void SetFields_Machine() { var machine = new Machine(); machine.SetFieldValue(Models.Metadata.Machine.NameKey, "bar"); machine.SetFieldValue(Models.Metadata.Machine.DescriptionKey, "bar"); - var rom = new Rom(); - rom.SetFieldValue(DatItem.MachineKey, machine); - rom.SetName("foo"); + var setter = new Setter(); + setter.PopulateSetters(new FilterKey("machine", "name"), "foo"); + setter.SetFields(machine); - return rom; + Assert.Equal("foo", machine.GetStringFieldValue(Models.Metadata.Machine.NameKey)); } } } \ No newline at end of file