claunia/SabreTools
1
0
Fork 0
mirror of https://github.com/claunia/SabreTools.git synced 2025-12-16 19:14:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make string comparison ordinal, add comment

Browse Source
This commit is contained in:
Matt Nadareski
2025-01-07 20:13:58 -05:00
parent f918b7ab79
commit 49aa18bccd
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
SabreTools.DatItems/DatItem.cs
View File

@@ -162,7 +162,9 @@ namespace SabreTools.DatItems
if (GetName() == other?.GetName()) if (GetName() == other?.GetName())
return Equals(other) ? 0 : 1; return Equals(other) ? 0 : 1;
return string.Compare(GetName(), other?.GetName()); // If `other?.GetName()` is null, Compare will return > 0
// If `this.GetName()` is null, Compare will return < 0
return string.Compare(GetName(), other?.GetName(), StringComparison.Ordinal);
} }
catch catch
{ {
@@ -548,7 +550,9 @@ namespace SabreTools.DatItems
if (GetName() == other?.GetName()) if (GetName() == other?.GetName())
return Equals(other) ? 0 : 1; return Equals(other) ? 0 : 1;
return string.Compare(GetName(), other?.GetName()); // If `other?.GetName()` is null, Compare will return > 0
// If `this.GetName()` is null, Compare will return < 0
return string.Compare(GetName(), other?.GetName(), StringComparison.Ordinal);
} }
catch catch
{ {