claunia/SabreTools
1
0
Fork 0
mirror of https://github.com/claunia/SabreTools.git synced 2025-12-16 19:14:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce method calls in Cleaner

Browse Source
This commit is contained in:
Matt Nadareski
2024-10-24 02:08:35 -04:00
parent 0a6ae30e6b
commit 4fc27d70e5
1 changed files with 53 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

75
SabreTools.Filtering/Cleaner.cs
View File

@@ -231,36 +231,54 @@ namespace SabreTools.Filtering
/// <param name="datItem">DatItem to clean</param> /// <param name="datItem">DatItem to clean</param>
internal void CleanDatItem(DatItem datItem) internal void CleanDatItem(DatItem datItem)
{ {
// Get the machine associated with the item, if possible
var machine = datItem.GetFieldValue<Machine>(DatItem.MachineKey);
if (machine == null)
return;
// Get the fields for processing
string? machineName = machine.GetStringFieldValue(Models.Metadata.Machine.NameKey);
string? machineDesc = machine.GetStringFieldValue(Models.Metadata.Machine.DescriptionKey);
string? datItemName = datItem.GetName();
// If we're stripping unicode characters, strip machine name and description // If we're stripping unicode characters, strip machine name and description
if (RemoveUnicode) if (RemoveUnicode)
{ {
datItem.GetFieldValue<Machine>(DatItem.MachineKey)!.SetFieldValue<string?>(Models.Metadata.Machine.NameKey, TextHelper.RemoveUnicodeCharacters(datItem.GetFieldValue<Machine>(DatItem.MachineKey)!.GetStringFieldValue(Models.Metadata.Machine.NameKey))); machineName = TextHelper.RemoveUnicodeCharacters(machineName);
datItem.GetFieldValue<Machine>(DatItem.MachineKey)!.SetFieldValue<string?>(Models.Metadata.Machine.DescriptionKey, TextHelper.RemoveUnicodeCharacters(datItem.GetFieldValue<Machine>(DatItem.MachineKey)!.GetStringFieldValue(Models.Metadata.Machine.DescriptionKey))); machineDesc = TextHelper.RemoveUnicodeCharacters(machineDesc);
datItem.SetName(TextHelper.RemoveUnicodeCharacters(datItem.GetName())); datItemName = TextHelper.RemoveUnicodeCharacters(datItemName);
} }
// If we're in cleaning mode, sanitize machine name and description // If we're in cleaning mode, sanitize machine name and description
if (Clean) if (Clean)
{ {
datItem.GetFieldValue<Machine>(DatItem.MachineKey)!.SetFieldValue<string?>(Models.Metadata.Machine.NameKey, TextHelper.NormalizeCharacters(datItem.GetFieldValue<Machine>(DatItem.MachineKey)!.GetStringFieldValue(Models.Metadata.Machine.NameKey))); machineName = TextHelper.NormalizeCharacters(machineName);
datItem.GetFieldValue<Machine>(DatItem.MachineKey)!.SetFieldValue<string?>(Models.Metadata.Machine.DescriptionKey, TextHelper.NormalizeCharacters(datItem.GetFieldValue<Machine>(DatItem.MachineKey)!.GetStringFieldValue(Models.Metadata.Machine.DescriptionKey))); machineDesc = TextHelper.NormalizeCharacters(machineDesc);
} }
// If we are in single game mode, rename the machine // If we are in single game mode, rename the machine
if (Single) if (Single)
datItem.GetFieldValue<Machine>(DatItem.MachineKey)!.SetFieldValue<string?>(Models.Metadata.Machine.NameKey, "!"); {
machineName = "!";
machineDesc = "!";
}
// If we are in NTFS trim mode, trim the item name // If we are in NTFS trim mode, trim the item name
if (Trim && datItem.GetName() != null) if (Trim && datItemName != null)
{ {
// Windows max name length is 260 // Windows max name length is 260
int usableLength = 260 - datItem.GetFieldValue<Machine>(DatItem.MachineKey)!.GetStringFieldValue(Models.Metadata.Machine.NameKey)!.Length - (Root?.Length ?? 0); int usableLength = 260 - (machineName?.Length ?? 0) - (Root?.Length ?? 0);
if (datItem.GetName()!.Length > usableLength) if (datItemName.Length > usableLength)
{ {
string ext = Path.GetExtension(datItem.GetName()!); string ext = Path.GetExtension(datItemName);
datItem.SetName(datItem.GetName()!.Substring(0, usableLength - ext.Length) + ext); datItemName = datItemName.Substring(0, usableLength - ext.Length) + ext;
} }
} }
// Set the fields back, if necessary
machine.SetFieldValue<string?>(Models.Metadata.Machine.NameKey, machineName);
machine.SetFieldValue<string?>(Models.Metadata.Machine.DescriptionKey, machineDesc);
datItem.SetName(datItemName);
} }
/// <summary> /// <summary>
@@ -275,36 +293,49 @@ namespace SabreTools.Filtering
if (machine.Item2 == null) if (machine.Item2 == null)
return; return;
// Get the fields for processing
string? machineName = machine.Item2.GetStringFieldValue(Models.Metadata.Machine.NameKey);
string? machineDesc = machine.Item2.GetStringFieldValue(Models.Metadata.Machine.DescriptionKey);
string? datItemName = datItem.Item2.GetName();
// If we're stripping unicode characters, strip machine name and description // If we're stripping unicode characters, strip machine name and description
if (RemoveUnicode) if (RemoveUnicode)
{ {
machine.Item2.SetFieldValue<string?>(Models.Metadata.Machine.NameKey, TextHelper.RemoveUnicodeCharacters(machine.Item2.GetStringFieldValue(Models.Metadata.Machine.NameKey))); machineName = TextHelper.RemoveUnicodeCharacters(machineName);
machine.Item2.SetFieldValue<string?>(Models.Metadata.Machine.DescriptionKey, TextHelper.RemoveUnicodeCharacters(machine.Item2.GetStringFieldValue(Models.Metadata.Machine.DescriptionKey))); machineDesc = TextHelper.RemoveUnicodeCharacters(machineDesc);
datItem.Item2.SetName(TextHelper.RemoveUnicodeCharacters(datItem.Item2.GetName())); datItemName = TextHelper.RemoveUnicodeCharacters(datItemName);
} }
// If we're in cleaning mode, sanitize machine name and description // If we're in cleaning mode, sanitize machine name and description
if (Clean) if (Clean)
{ {
machine.Item2.SetFieldValue<string?>(Models.Metadata.Machine.NameKey, TextHelper.NormalizeCharacters(machine.Item2.GetStringFieldValue(Models.Metadata.Machine.NameKey))); machineName = TextHelper.NormalizeCharacters(machineName);
machine.Item2.SetFieldValue<string?>(Models.Metadata.Machine.DescriptionKey, TextHelper.NormalizeCharacters(machine.Item2.GetStringFieldValue(Models.Metadata.Machine.DescriptionKey))); machineDesc = TextHelper.NormalizeCharacters(machineDesc);
} }
// If we are in single game mode, rename the machine // If we are in single game mode, rename the machine
if (Single) if (Single)
machine.Item2.SetFieldValue<string?>(Models.Metadata.Machine.NameKey, "!"); {
machineName = "!";
machineDesc = "!";
}
// If we are in NTFS trim mode, trim the item name // If we are in NTFS trim mode, trim the item name
if (Trim && datItem.Item2.GetName() != null) if (Trim && datItemName != null)
{ {
// Windows max name length is 260 // Windows max name length is 260
int usableLength = 260 - machine.Item2.GetStringFieldValue(Models.Metadata.Machine.NameKey)!.Length - (Root?.Length ?? 0); int usableLength = 260 - (machineName?.Length ?? 0) - (Root?.Length ?? 0);
if (datItem.Item2.GetName()!.Length > usableLength) if (datItemName.Length > usableLength)
{ {
string ext = Path.GetExtension(datItem.Item2.GetName()!); string ext = Path.GetExtension(datItemName);
datItem.Item2.SetName(datItem.Item2.GetName()!.Substring(0, usableLength - ext.Length) + ext); datItemName = datItemName.Substring(0, usableLength - ext.Length) + ext;
} }
} }
// Set the fields back, if necessary
machine.Item2.SetFieldValue<string?>(Models.Metadata.Machine.NameKey, machineName);
machine.Item2.SetFieldValue<string?>(Models.Metadata.Machine.DescriptionKey, machineDesc);
datItem.Item2.SetName(datItemName);
} }
#endregion #endregion