claunia/SabreTools
1
0
Fork 0
mirror of https://github.com/claunia/SabreTools.git synced 2025-12-16 19:14:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reenable RemoverTests tests

Browse Source
This commit is contained in:
Matt Nadareski
2025-02-19 13:39:21 -05:00
parent 29bbb35965
commit 59faf22c7e
2 changed files with 24 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
SabreTools.DatTools/Remover.cs
View File

@@ -211,7 +211,7 @@ namespace SabreTools.DatTools
/// <summary>
/// Remove machine fields with given values
/// </summary>
private void RemoveFields(Machine? machine)
internal void RemoveFields(Machine? machine)
{
// If we have an invalid input, return
if (machine == null || MachineFieldNames.Count == 0)
@@ -227,7 +227,7 @@ namespace SabreTools.DatTools
/// Remove fields with given values
/// </summary>
/// <param name="datItem">DatItem to remove fields from</param>
private void RemoveFields(DatItem? datItem)
internal void RemoveFields(DatItem? datItem)
{
if (datItem == null)
return;

52
SabreTools.Test/RemoverTests.cs
View File

@@ -1,45 +1,37 @@
using SabreTools.DatItems;
using SabreTools.DatItems.Formats;
using SabreTools.DatTools;
using Xunit;
namespace SabreTools.Test
{
// TODO: Reenable tests when there's a reasonable way of doing so
public class RemoverTests
{
//[Fact]
//public void RemoveFieldsDatItemTest()
//{
// var datItem = CreateDatItem();
// var remover = new Remover();
// remover.PopulateExclusions("DatItem.Name");
// remover.RemoveFields(datItem);
// Assert.Null(datItem.GetName());
//}
//[Fact]
//public void RemoveFieldsMachineTest()
//{
// var datItem = CreateDatItem();
// var remover = new Remover();
// remover.PopulateExclusions("Machine.Name");
// remover.RemoveFields(datItem);
// Assert.Null(datItem.GetFieldValue<Machine>(DatItem.MachineKey)!.GetStringFieldValue(Models.Metadata.Machine.NameKey));
//}
/// <summary>
/// Generate a consistent DatItem for testing
/// </summary>
private static DatItem CreateDatItem()
[Fact]
public void RemoveFieldsDatItemTest()
{
var machine = new Machine();
var datItem = new Rom();
datItem.SetName("foo");
var remover = new Remover();
remover.PopulateExclusions("DatItem.Name");
remover.RemoveFields(datItem);
Assert.Null(datItem.GetName());
}
[Fact]
public void RemoveFieldsMachineTest()
{
var machine = new Machine();
machine.SetFieldValue<string?>(Models.Metadata.Machine.NameKey, "bar");
machine.SetFieldValue<string?>(Models.Metadata.Machine.DescriptionKey, "bar");
var rom = new Rom();
rom.SetName("foo");
rom.SetFieldValue<Machine>(DatItem.MachineKey, machine);
var remover = new Remover();
remover.PopulateExclusions("Machine.Name");
remover.RemoveFields(machine);
return rom;
Assert.Null(machine.GetStringFieldValue(Models.Metadata.Machine.NameKey));
}
}
}