From 6c8c635588abf9d22e6731721e9a993a3a804375 Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 24 Oct 2024 03:23:56 -0400 Subject: [PATCH] Don't allow null arrays in constructor --- SabreTools.Core/Filter/FilterRunner.cs | 12 +++--------- SabreTools.Test/Filter/PopulationTests.cs | 10 ---------- 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/SabreTools.Core/Filter/FilterRunner.cs b/SabreTools.Core/Filter/FilterRunner.cs index aa1c5c66..de856995 100644 --- a/SabreTools.Core/Filter/FilterRunner.cs +++ b/SabreTools.Core/Filter/FilterRunner.cs @@ -13,21 +13,15 @@ namespace SabreTools.Core.Filter /// /// Set of filters to be run against an object /// - public FilterObject[] Filters { get; } + public readonly FilterObject[] Filters; - public FilterRunner(FilterObject[]? filters) + public FilterRunner(FilterObject[] filters) { - if (filters == null) - throw new ArgumentNullException(nameof(filters)); - Filters = filters; } - public FilterRunner(string[]? filterStrings) + public FilterRunner(string[] filterStrings) { - if (filterStrings == null) - throw new ArgumentNullException(nameof(filterStrings)); - var filters = new List(); foreach (string filterString in filterStrings) { diff --git a/SabreTools.Test/Filter/PopulationTests.cs b/SabreTools.Test/Filter/PopulationTests.cs index b1c5ef54..1a4aea5a 100644 --- a/SabreTools.Test/Filter/PopulationTests.cs +++ b/SabreTools.Test/Filter/PopulationTests.cs @@ -6,16 +6,6 @@ namespace SabreTools.Test.Filter { public class PopulationTests { - [Fact] - public void PopulateFilterRunnerNullListTest() - { - // Setup the list - string[]? filters = null; - - // Setup the filter - Assert.Throws(() => new FilterRunner(filters)); - } - [Fact] public void PopulateFilterRunnerEmptyListTest() {