claunia/SabreTools
1
0
Fork 0
mirror of https://github.com/claunia/SabreTools.git synced 2025-12-16 19:14:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Take care of 2 minor TODOs

Browse Source
This commit is contained in:
Matt Nadareski
2025-01-30 14:05:12 -05:00
parent 92c2be7eb1
commit 845babdff5
3 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
SabreTools.DatFiles.Test/DatHeaderTests.cs
View File

@@ -112,12 +112,6 @@ namespace SabreTools.DatFiles.Test
#endregion #endregion
#region Constructor
// TODO: Add Constructor from model tests
#endregion
#region Clone #region Clone
[Fact] [Fact]

6
SabreTools.DatFiles/DatFile.cs
View File

@@ -28,9 +28,8 @@ namespace SabreTools.DatFiles
/// <summary> /// <summary>
/// Modifier values /// Modifier values
/// </summary> /// </summary>
/// TODO: Make this private set
[JsonProperty("modifiers"), XmlElement("modifiers")] [JsonProperty("modifiers"), XmlElement("modifiers")]
public DatModifiers Modifiers { get; set; } = new DatModifiers(); public DatModifiers Modifiers { get; private set; } = new DatModifiers();
/// <summary> /// <summary>
/// DatItems and related statistics /// DatItems and related statistics
@@ -151,9 +150,8 @@ namespace SabreTools.DatFiles
/// <param name="datHeader">Replacement header to be used</param> /// <param name="datHeader">Replacement header to be used</param>
public void SetHeader(DatHeader? datHeader) public void SetHeader(DatHeader? datHeader)
{ {
// TODO: Figure out why clone loses data here
if (datHeader != null) if (datHeader != null)
Header = datHeader; Header = (DatHeader)datHeader.Clone();
} }
/// <summary> /// <summary>

12
SabreTools.DatFiles/DatHeader.cs
View File

@@ -109,6 +109,18 @@ namespace SabreTools.DatFiles
_internal[fieldName] = header[fieldName]; _internal[fieldName] = header[fieldName];
} }
} }
// Get all no-filter fields
if (header.ContainsKey(Models.Metadata.Header.CanOpenKey))
_internal[Models.Metadata.Header.CanOpenKey] = header[Models.Metadata.Header.CanOpenKey];
if (header.ContainsKey(Models.Metadata.Header.ImagesKey))
_internal[Models.Metadata.Header.ImagesKey] = header[Models.Metadata.Header.ImagesKey];
if (header.ContainsKey(Models.Metadata.Header.InfosKey))
_internal[Models.Metadata.Header.InfosKey] = header[Models.Metadata.Header.InfosKey];
if (header.ContainsKey(Models.Metadata.Header.NewDatKey))
_internal[Models.Metadata.Header.NewDatKey] = header[Models.Metadata.Header.NewDatKey];
if (header.ContainsKey(Models.Metadata.Header.SearchKey))
_internal[Models.Metadata.Header.SearchKey] = header[Models.Metadata.Header.SearchKey];
} }
#endregion #endregion