mirror of
https://github.com/claunia/SabreTools.git
synced 2025-12-16 19:14:27 +00:00
Take care of 2 minor TODOs
This commit is contained in:
@@ -112,12 +112,6 @@ namespace SabreTools.DatFiles.Test
|
||||
|
||||
#endregion
|
||||
|
||||
#region Constructor
|
||||
|
||||
// TODO: Add Constructor from model tests
|
||||
|
||||
#endregion
|
||||
|
||||
#region Clone
|
||||
|
||||
[Fact]
|
||||
|
||||
@@ -28,9 +28,8 @@ namespace SabreTools.DatFiles
|
||||
/// <summary>
|
||||
/// Modifier values
|
||||
/// </summary>
|
||||
/// TODO: Make this private set
|
||||
[JsonProperty("modifiers"), XmlElement("modifiers")]
|
||||
public DatModifiers Modifiers { get; set; } = new DatModifiers();
|
||||
public DatModifiers Modifiers { get; private set; } = new DatModifiers();
|
||||
|
||||
/// <summary>
|
||||
/// DatItems and related statistics
|
||||
@@ -151,9 +150,8 @@ namespace SabreTools.DatFiles
|
||||
/// <param name="datHeader">Replacement header to be used</param>
|
||||
public void SetHeader(DatHeader? datHeader)
|
||||
{
|
||||
// TODO: Figure out why clone loses data here
|
||||
if (datHeader != null)
|
||||
Header = datHeader;
|
||||
Header = (DatHeader)datHeader.Clone();
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
|
||||
@@ -109,6 +109,18 @@ namespace SabreTools.DatFiles
|
||||
_internal[fieldName] = header[fieldName];
|
||||
}
|
||||
}
|
||||
|
||||
// Get all no-filter fields
|
||||
if (header.ContainsKey(Models.Metadata.Header.CanOpenKey))
|
||||
_internal[Models.Metadata.Header.CanOpenKey] = header[Models.Metadata.Header.CanOpenKey];
|
||||
if (header.ContainsKey(Models.Metadata.Header.ImagesKey))
|
||||
_internal[Models.Metadata.Header.ImagesKey] = header[Models.Metadata.Header.ImagesKey];
|
||||
if (header.ContainsKey(Models.Metadata.Header.InfosKey))
|
||||
_internal[Models.Metadata.Header.InfosKey] = header[Models.Metadata.Header.InfosKey];
|
||||
if (header.ContainsKey(Models.Metadata.Header.NewDatKey))
|
||||
_internal[Models.Metadata.Header.NewDatKey] = header[Models.Metadata.Header.NewDatKey];
|
||||
if (header.ContainsKey(Models.Metadata.Header.SearchKey))
|
||||
_internal[Models.Metadata.Header.SearchKey] = header[Models.Metadata.Header.SearchKey];
|
||||
}
|
||||
|
||||
#endregion
|
||||
|
||||
Reference in New Issue
Block a user