From 9ed8d0e4b92c968d3879c53ac75f41387768ba79 Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Thu, 30 Jul 2020 16:54:25 -0700 Subject: [PATCH] VSCode cleanup --- .vscode/launch.json | 27 ++++++++++++++++++ .vscode/tasks.json | 31 ++++----------------- SabreTools.Library/DatFiles/SoftwareList.cs | 2 +- 3 files changed, 34 insertions(+), 26 deletions(-) create mode 100644 .vscode/launch.json diff --git a/.vscode/launch.json b/.vscode/launch.json new file mode 100644 index 00000000..139470f4 --- /dev/null +++ b/.vscode/launch.json @@ -0,0 +1,27 @@ +{ + // Use IntelliSense to find out which attributes exist for C# debugging + // Use hover for the description of the existing attributes + // For further information visit https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md + "version": "0.2.0", + "configurations": [ + { + "name": ".NET Core Launch (console)", + "type": "coreclr", + "request": "launch", + "preLaunchTask": "build", + // If you have changed target frameworks, make sure to update the program path. + "program": "${workspaceFolder}/SabreTools/bin/Debug/netcoreapp3.1/SabreTools.dll", + "args": [], + "cwd": "${workspaceFolder}/SabreTools", + // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console + "console": "internalConsole", + "stopAtEntry": false + }, + { + "name": ".NET Core Attach", + "type": "coreclr", + "request": "attach", + "processId": "${command:pickProcess}" + } + ] +} \ No newline at end of file diff --git a/.vscode/tasks.json b/.vscode/tasks.json index dd39e57b..31c32bd3 100644 --- a/.vscode/tasks.json +++ b/.vscode/tasks.json @@ -4,39 +4,20 @@ "version": "2.0.0", "tasks": [ { - "label": "build-mono", + "label": "build", + "command": "dotnet", "type": "shell", - "command": "msbuild", "args": [ - // Ask msbuild to generate full paths for file names. + "build", + // Ask dotnet build to generate full paths for file names. "/property:GenerateFullPaths=true", - "/property:Configuration=Mono", - "/t:build" + // Do not generate summary otherwise it leads to duplicate errors in Problems panel + "/consoleloggerparameters:NoSummary" ], "group": "build", "presentation": { - // Reveal the output only if unrecognized errors occur. "reveal": "silent" }, - // Use the standard MS compiler pattern to detect errors, warnings and infos - "problemMatcher": "$msCompile" - }, - { - "label": "build-debug", - "type": "shell", - "command": "msbuild", - "args": [ - // Ask msbuild to generate full paths for file names. - "/property:GenerateFullPaths=true", - "/property:Configuration=Debug", - "/t:build" - ], - "group": "build", - "presentation": { - // Reveal the output only if unrecognized errors occur. - "reveal": "silent" - }, - // Use the standard MS compiler pattern to detect errors, warnings and infos "problemMatcher": "$msCompile" } ] diff --git a/SabreTools.Library/DatFiles/SoftwareList.cs b/SabreTools.Library/DatFiles/SoftwareList.cs index f17c9a27..f68332dd 100644 --- a/SabreTools.Library/DatFiles/SoftwareList.cs +++ b/SabreTools.Library/DatFiles/SoftwareList.cs @@ -235,7 +235,7 @@ namespace SabreTools.Library.DatFiles // Miscellaneous bool keep) { - string key, areaname, partname = string.Empty, partinterface = string.Empty; + string areaname, partname = string.Empty, partinterface = string.Empty; long? areasize = null; var features = new List>(); bool containsItems = false;