From a47652bab96fafdfd7ee9d60a972af1c4b75200e Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Sun, 11 May 2025 21:13:34 -0400 Subject: [PATCH] Avoid loop in common path of GetItemsForBucket --- SabreTools.DatFiles/ItemDictionary.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/SabreTools.DatFiles/ItemDictionary.cs b/SabreTools.DatFiles/ItemDictionary.cs index e42ed603..ad3f40f2 100644 --- a/SabreTools.DatFiles/ItemDictionary.cs +++ b/SabreTools.DatFiles/ItemDictionary.cs @@ -243,13 +243,13 @@ namespace SabreTools.DatFiles var items = _items[bucketName]; #endif - if (items == null) - return []; + if (items == null || !filter) + return [.. items ?? []]; var datItems = new List(); foreach (DatItem item in items) { - if (!filter || item.GetBoolFieldValue(DatItem.RemoveKey) != true) + if (item.GetBoolFieldValue(DatItem.RemoveKey) != true) datItems.Add(item); }