From c070167eb9e5a077065a4f79dd47e64a7349f28a Mon Sep 17 00:00:00 2001 From: Matt Nadareski Date: Sun, 14 Jun 2020 20:33:06 -0700 Subject: [PATCH] Char, not string --- SabreTools.Library/DatFiles/AttractMode.cs | 2 +- SabreTools.Library/DatFiles/EverdriveSmdb.cs | 2 +- SabreTools.Library/DatFiles/Hashfile.cs | 2 +- SabreTools.Library/DatFiles/SeparatedValue.cs | 2 +- SabreTools.Library/Readers/IniReader.cs | 2 +- SabreTools.Library/Writers/SeparatedValueWriter.cs | 6 +++--- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/SabreTools.Library/DatFiles/AttractMode.cs b/SabreTools.Library/DatFiles/AttractMode.cs index 2a227d34..c6f41ec6 100644 --- a/SabreTools.Library/DatFiles/AttractMode.cs +++ b/SabreTools.Library/DatFiles/AttractMode.cs @@ -124,7 +124,7 @@ namespace SabreTools.Library.DatFiles SeparatedValueWriter svw = new SeparatedValueWriter(fs, new UTF8Encoding(false)); svw.Quotes = false; - svw.Separator = ";"; + svw.Separator = ';'; svw.VerifyFieldCount = true; // Write out the header diff --git a/SabreTools.Library/DatFiles/EverdriveSmdb.cs b/SabreTools.Library/DatFiles/EverdriveSmdb.cs index 7c19234f..8446087f 100644 --- a/SabreTools.Library/DatFiles/EverdriveSmdb.cs +++ b/SabreTools.Library/DatFiles/EverdriveSmdb.cs @@ -108,7 +108,7 @@ namespace SabreTools.Library.DatFiles SeparatedValueWriter svw = new SeparatedValueWriter(fs, new UTF8Encoding(false)); svw.Quotes = false; - svw.Separator = "\t"; + svw.Separator = '\t'; svw.VerifyFieldCount = true; // Get a properly sorted set of keys diff --git a/SabreTools.Library/DatFiles/Hashfile.cs b/SabreTools.Library/DatFiles/Hashfile.cs index 7478effa..d482f561 100644 --- a/SabreTools.Library/DatFiles/Hashfile.cs +++ b/SabreTools.Library/DatFiles/Hashfile.cs @@ -124,7 +124,7 @@ namespace SabreTools.Library.DatFiles SeparatedValueWriter svw = new SeparatedValueWriter(fs, new UTF8Encoding(false)); svw.Quotes = false; - svw.Separator = " "; + svw.Separator = ' '; svw.VerifyFieldCount = true; // Get a properly sorted set of keys diff --git a/SabreTools.Library/DatFiles/SeparatedValue.cs b/SabreTools.Library/DatFiles/SeparatedValue.cs index 3ad88bfc..f62993e4 100644 --- a/SabreTools.Library/DatFiles/SeparatedValue.cs +++ b/SabreTools.Library/DatFiles/SeparatedValue.cs @@ -397,7 +397,7 @@ namespace SabreTools.Library.DatFiles SeparatedValueWriter svw = new SeparatedValueWriter(fs, new UTF8Encoding(false)); svw.Quotes = true; - svw.Separator = this._delim.ToString(); + svw.Separator = this._delim; svw.VerifyFieldCount = true; // Write out the header diff --git a/SabreTools.Library/Readers/IniReader.cs b/SabreTools.Library/Readers/IniReader.cs index 60419ec6..0b9b47b7 100644 --- a/SabreTools.Library/Readers/IniReader.cs +++ b/SabreTools.Library/Readers/IniReader.cs @@ -134,7 +134,7 @@ namespace SabreTools.Library.Readers } /// - /// Dispose of the reader + /// Dispose of the underlying reader /// public void Dispose() { diff --git a/SabreTools.Library/Writers/SeparatedValueWriter.cs b/SabreTools.Library/Writers/SeparatedValueWriter.cs index fabe32f0..b8f69312 100644 --- a/SabreTools.Library/Writers/SeparatedValueWriter.cs +++ b/SabreTools.Library/Writers/SeparatedValueWriter.cs @@ -32,9 +32,9 @@ namespace SabreTools.Library.Writers public bool Quotes { get; set; } = true; /// - /// Set what string should be used as a separator + /// Set what character should be used as a separator /// - public string Separator { get; set; } = ","; + public char Separator { get; set; } = ','; /// /// Set if field count should be verified from the first row @@ -79,7 +79,7 @@ namespace SabreTools.Library.Writers throw new ArgumentException(nameof(sw)); // If the separator character is invalid, we error - if (string.IsNullOrEmpty(Separator)) + if (Separator == default(char)) throw new ArgumentException(nameof(Separator)); // If we have the first row, set the bool and the field count