claunia/SabreTools
1
0
Fork 0
mirror of https://github.com/claunia/SabreTools.git synced 2025-12-16 19:14:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce implicit null checks

Browse Source
This commit is contained in:
Matt Nadareski
2023-08-10 11:35:32 -04:00
parent 5213490689
commit c59bd4d857
35 changed files with 1406 additions and 783 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
SabreTools.Serialization/OfflineList.Serializer.cs
View File

@@ -13,15 +13,23 @@ namespace SabreTools.Serialization
/// <summary>
/// Convert from <cref="Models.OfflineList.Dat"/> to <cref="Models.Internal.MetadataFile"/>
/// </summary>
public static Models.Internal.MetadataFile ConvertToInternalModel(Dat item)
public static Models.Internal.MetadataFile? ConvertToInternalModel(Dat? item)
{
if (item == null)
return null;
var metadataFile = new Models.Internal.MetadataFile
{
[Models.Internal.MetadataFile.HeaderKey] = ConvertHeaderToInternalModel(item),
};
if (item?.Games?.Game != null && item.Games.Game.Any())
metadataFile[Models.Internal.MetadataFile.MachineKey] = item.Games.Game.Select(ConvertMachineToInternalModel).ToArray();
{
metadataFile[Models.Internal.MetadataFile.MachineKey] = item.Games.Game
.Where(g => g != null)
.Select(ConvertMachineToInternalModel)
.ToArray();
}
return metadataFile;
}
@@ -82,12 +90,15 @@ namespace SabreTools.Serialization
if (item.Files?.RomCRC != null && item.Files.RomCRC.Any())
{
machine[Models.Internal.Machine.RomKey] = item.Files.RomCRC.Select(romCRC =>
{
var rom = ConvertToInternalModel(romCRC);
rom[Models.Internal.Rom.SizeKey] = item.RomSize;
return rom;
}).ToArray();
machine[Models.Internal.Machine.RomKey] = item.Files.RomCRC
.Where(r => r != null)
.Select(romCRC =>
{
var rom = ConvertToInternalModel(romCRC);
rom[Models.Internal.Rom.SizeKey] = item.RomSize;
return rom;
})
.ToArray();
}
return machine;