Commit Graph

498 Commits

Author SHA1 Message Date
Matt Nadareski
a45db9f18d Reduce more odd null cases 2025-01-13 13:31:14 -05:00
Matt Nadareski
c6dde56c1e Reduce uncertainty in returned value nullability 2025-01-13 13:22:48 -05:00
Matt Nadareski
8ec4605725 Be more consistent with remarks 2025-01-13 13:05:53 -05:00
Matt Nadareski
2f5c43e9ad Try to make method names clearer 2025-01-13 13:02:17 -05:00
Matt Nadareski
e78154d824 Try to make method names clearer 2025-01-13 13:01:36 -05:00
Matt Nadareski
ecf21a5bc0 Try to make method names clearer 2025-01-13 13:00:14 -05:00
Matt Nadareski
021c4debb7 Fix unnecessary null skips 2025-01-13 10:57:00 -05:00
Matt Nadareski
94f117c06f Remove unnecessary null skips 2025-01-13 10:52:27 -05:00
Matt Nadareski
5a451dd1ac Stop using "Rom" terminology 2025-01-13 10:45:42 -05:00
Matt Nadareski
91c2fce12b Fix access level for 2 methods 2025-01-13 10:35:59 -05:00
Matt Nadareski
f492e68c6a Add RemoveMachineRelationshipTags tests, add another helper 2025-01-13 10:01:27 -05:00
Matt Nadareski
c94d8d712f Replace more direct accessors to ItemDictionary 2025-01-13 09:37:59 -05:00
Matt Nadareski
3c4de2cc07 Be more consistent with remarks 2025-01-13 09:27:01 -05:00
Matt Nadareski
3dfd8a38b0 Update both naming and remarks for clarity 2025-01-13 09:24:16 -05:00
Matt Nadareski
31aa6a6478 Rename RemoveTagsFromChild to RemoveMachineRelationshipTags 2025-01-13 09:12:07 -05:00
Matt Nadareski
17446907b0 Fix RemoveTagsFromChildImpl 2025-01-13 00:31:38 -05:00
Matt Nadareski
9e76e9e033 Fix RemoveTagsFromChildImplDB 2025-01-13 00:29:39 -05:00
Matt Nadareski
16fa2cbe02 Minor cleanup to avoid runtime exceptions 2025-01-13 00:10:36 -05:00
Matt Nadareski
208f4f64a9 Fix strip scene dates in DB variant 2025-01-13 00:02:56 -05:00
Matt Nadareski
b62792d802 Compare what a dict can do and what can be done to it 2025-01-12 23:56:48 -05:00
Matt Nadareski
10b4046c5d Fix issues found during compilation and testing 2025-01-12 23:23:23 -05:00
Matt Nadareski
f4743e859e Create passthrough methods for scaffolding 2025-01-12 23:15:30 -05:00
Matt Nadareski
d80a6b173c Create passthrough methods for scaffolding 2025-01-12 22:10:48 -05:00
Matt Nadareski
c8fda8d99d Slight rename for readability 2025-01-12 21:30:21 -05:00
Matt Nadareski
9566ab6106 Reduce overloads for CreateDatfile again 2025-01-12 20:50:40 -05:00
Matt Nadareski
4d4a873b83 Remove external quotes parameter for CMP 2025-01-12 20:49:22 -05:00
Matt Nadareski
a5e9de2fdc Fix consistency issues in converting to metadata 2025-01-11 23:34:26 -05:00
Matt Nadareski
41ab9826a3 Finish writing ConvertToMetadata and making fixes related 2025-01-11 23:03:32 -05:00
Matt Nadareski
1763796f9f Better handle triple-nested items 2025-01-11 22:21:11 -05:00
Matt Nadareski
457ddf67d9 Handle internal implementations better (nw) 2025-01-11 22:00:26 -05:00
Matt Nadareski
4f6354802f Minor formatting change for readability 2025-01-10 23:02:36 -05:00
Matt Nadareski
964c330c6f Make metadata conversion internal 2025-01-10 22:35:47 -05:00
Matt Nadareski
7186c47954 DatFile should not care about specialized removal 2025-01-10 22:24:19 -05:00
Matt Nadareski
e3332fe0a0 Reduce verbosity of variable names 2025-01-10 22:13:17 -05:00
Matt Nadareski
b869b324bb More unnecessary null checks 2025-01-10 22:03:50 -05:00
Matt Nadareski
20ec4edeb8 Common DatItem properties can never be null 2025-01-10 21:52:21 -05:00
Matt Nadareski
cfe7bb53e5 Fix RemoveItemFieldsDB logic 2025-01-10 21:22:41 -05:00
Matt Nadareski
eb1b940411 Add a verbose log line for header field removal 2025-01-10 21:20:24 -05:00
Matt Nadareski
b37787be64 Split ApplyRemovals for testability 2025-01-10 21:15:50 -05:00
Matt Nadareski
6b7fe6f56f ConvertFromMetadata tests checkpoint 2025-01-10 14:37:18 -05:00
Matt Nadareski
a4f0540736 ConvertFromMetadata tests checkpoint 2025-01-10 14:02:32 -05:00
Matt Nadareski
caf20ffbea ConvertFromMetadata tests checkpoint 2025-01-10 13:50:00 -05:00
Matt Nadareski
9d6ab715f1 ConvertFromMetadata tests checkpoint 2025-01-10 13:10:50 -05:00
Matt Nadareski
100c321e5d Rename ConvertMetadata methods to be easier to distinguish 2025-01-10 11:05:51 -05:00
Matt Nadareski
c8a927e75f Write ResolveNames/DB tests 2025-01-10 10:30:49 -05:00
Matt Nadareski
3155e7d03c Remove tentative TODO after investigating 2025-01-09 20:47:43 -05:00
Matt Nadareski
50b5b9d3f1 Ignore empty lists in ResolveNames/DB 2025-01-09 20:45:26 -05:00
Matt Nadareski
2f5d2fa961 Add ContainsWritable tests 2025-01-09 20:10:56 -05:00
Matt Nadareski
dece9c0511 Add ProcessNullifiedItem tests 2025-01-09 16:53:55 -05:00
Matt Nadareski
f456f2b0ff ProcessItemName 2025-01-09 16:25:53 -05:00