From 49d9d742e2f84295a0dca8ad9a88c94c9a57b95d Mon Sep 17 00:00:00 2001 From: Erik de Castro Lopo Date: Sun, 23 Mar 2014 21:40:54 +1100 Subject: [PATCH] metadata_object.c : Fix handling of zero length vorbis comment string. Previously if a zero length string was passed in, the pointer would be stored regardless of the copy parameter. If the original source pointer was reassigned to something else bad things could happen. Closes: https://sourceforge.net/p/flac/bugs/377/ --- src/libFLAC/metadata_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libFLAC/metadata_object.c b/src/libFLAC/metadata_object.c index 55032389..40b7b9b1 100644 --- a/src/libFLAC/metadata_object.c +++ b/src/libFLAC/metadata_object.c @@ -264,7 +264,7 @@ static FLAC__bool vorbiscomment_set_entry_(FLAC__StreamMetadata *object, FLAC__S save = dest->entry; - if(0 != src->entry && src->length > 0) { + if(0 != src->entry) { if(copy) { /* do the copy first so that if we fail we leave the dest object untouched */ if(!copy_vcentry_(dest, src))