claunia/flac
1
0
Fork 0
mirror of https://github.com/claunia/flac.git synced 2025-12-16 18:54:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use sizeof instead of magic number 4.

Browse Source
This commit is contained in:
Erik de Castro Lopo
2012-04-07 09:00:09 +10:00
parent b3e9eb66ef
commit 8340ab3bc8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/metaflac/options.c
View File

@@ -1040,8 +1040,8 @@ FLAC__bool parse_block_type(const char *in, Argument_BlockType *out)
out->entries[entry].type = FLAC__METADATA_TYPE_APPLICATION;
out->entries[entry].filter_application_by_id = (0 != r);
if(0 != r) {
if(strlen(r) == 4) {
memcpy(out->entries[entry].application_id, r, 4);
if(strlen(r) == sizeof (out->entries[entry].application_id)) {
memcpy(out->entries[entry].application_id, r, sizeof (out->entries[entry].application_id));
}
else if(strlen(r) == 10 && strncmp(r, "0x", 2) == 0 && strspn(r+2, "0123456789ABCDEFabcdef") == 8) {
FLAC__uint32 x = strtoul(r+2, 0, 16);