diff --git a/include/FLAC++/metadata.h b/include/FLAC++/metadata.h index 4cdd7cdf..3db5d05a 100644 --- a/include/FLAC++/metadata.h +++ b/include/FLAC++/metadata.h @@ -618,8 +618,8 @@ namespace FLAC { inline void set_pre_emphasis(bool value) { object_->pre_emphasis = value? 1 : 0; } void set_index(unsigned i, const ::FLAC__StreamMetadata_CueSheet_Index &index); - //@@@@ It's awkward but to insert/delete index points - //@@@@ you must use the routines in the CueSheet class. + //@@@ It's awkward but to insert/delete index points + //@@@ you must use the routines in the CueSheet class. }; CueSheet(); diff --git a/include/FLAC/format.h b/include/FLAC/format.h index 271c6a4b..52fec66d 100644 --- a/include/FLAC/format.h +++ b/include/FLAC/format.h @@ -604,7 +604,7 @@ typedef struct { extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_INDEX_OFFSET_LEN; /**< == 64 (bits) */ extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_INDEX_NUMBER_LEN; /**< == 8 (bits) */ -extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_INDEX_RESERVED_LEN; /**< == @@@@3*8 (bits) */ +extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_INDEX_RESERVED_LEN; /**< == 3*8 (bits) */ /** FLAC CUESHEET track structure. (See the @@ -640,7 +640,7 @@ extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_NUMBER_LEN; extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_ISRC_LEN; /**< == 12*8 (bits) */ extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_TYPE_LEN; /**< == 1 (bit) */ extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_PRE_EMPHASIS_LEN; /**< == 1 (bit) */ -extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_RESERVED_LEN; /**< == 6+@@@@13*8 (bits) */ +extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_RESERVED_LEN; /**< == 6+13*8 (bits) */ extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_NUM_INDICES_LEN; /**< == 8 (bits) */ @@ -672,7 +672,7 @@ typedef struct { extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_MEDIA_CATALOG_NUMBER_LEN; /**< == 128*8 (bits) */ extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_LEAD_IN_LEN; /**< == 64 (bits) */ extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_IS_CD_LEN; /**< == 1 (bit) */ -extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_RESERVED_LEN; /**< == @@@@7+258*8 (bits) */ +extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_RESERVED_LEN; /**< == 7+258*8 (bits) */ extern FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_NUM_TRACKS_LEN; /**< == 8 (bits) */ @@ -764,7 +764,7 @@ FLAC_API FLAC__bool FLAC__format_seektable_is_legal(const FLAC__StreamMetadata_S */ FLAC_API unsigned FLAC__format_seektable_sort(FLAC__StreamMetadata_SeekTable *seek_table); -/*@@@@ add to unit tests */ +/* @@@@ add to unit tests */ /** Check a cue sheet to see if it conforms to the FLAC specification. * See the format specification for limits on the contents of the * cue sheet. diff --git a/src/flac/encode.c b/src/flac/encode.c index 4ca41cc1..fb37a5ef 100644 --- a/src/flac/encode.c +++ b/src/flac/encode.c @@ -1811,7 +1811,7 @@ FLAC__bool parse_cuesheet_(FLAC__StreamMetadata **cuesheet, const char *cuesheet return false; } - *cuesheet = grabbag__cuesheet_parse(f, &error_message, &last_line_read, /*@@@@is_cdda=*/true, lead_out_offset); + *cuesheet = grabbag__cuesheet_parse(f, &error_message, &last_line_read, /*@@@is_cdda=*/true, lead_out_offset); fclose(f); diff --git a/src/flac/main.c b/src/flac/main.c index ad06748c..42b794d7 100644 --- a/src/flac/main.c +++ b/src/flac/main.c @@ -1482,7 +1482,7 @@ int encode_file(const char *infilename, FLAC__bool is_first_file, FLAC__bool is_ if(!flac__utils_parse_skip_until_specification(option_values.skip_specification, &common_options.skip_specification) || common_options.skip_specification.is_relative) return usage_error("ERROR: invalid value for --skip\n"); - if(!flac__utils_parse_skip_until_specification(option_values.until_specification, &common_options.until_specification)) //@@@@ more checks: no + without --skip, no - unless known total_samples_to_{en,de}code + if(!flac__utils_parse_skip_until_specification(option_values.until_specification, &common_options.until_specification)) //@@@ more checks: no + without --skip, no - unless known total_samples_to_{en,de}code return usage_error("ERROR: invalid value for --until\n"); /* if there is no "--until" we want to default to "--until=-0" */ if(0 == option_values.until_specification) @@ -1594,7 +1594,7 @@ int decode_file(const char *infilename) if(!flac__utils_parse_skip_until_specification(option_values.skip_specification, &common_options.skip_specification) || common_options.skip_specification.is_relative) return usage_error("ERROR: invalid value for --skip\n"); - if(!flac__utils_parse_skip_until_specification(option_values.until_specification, &common_options.until_specification)) //@@@@ more checks: no + without --skip, no - unless known total_samples_to_{en,de}code + if(!flac__utils_parse_skip_until_specification(option_values.until_specification, &common_options.until_specification)) //@@@ more checks: no + without --skip, no - unless known total_samples_to_{en,de}code return usage_error("ERROR: invalid value for --until\n"); /* if there is no "--until" we want to default to "--until=-0" */ if(0 == option_values.until_specification) diff --git a/src/libFLAC/format.c b/src/libFLAC/format.c index 4abf206d..39f834f0 100644 --- a/src/libFLAC/format.c +++ b/src/libFLAC/format.c @@ -69,20 +69,20 @@ FLAC_API const unsigned FLAC__STREAM_METADATA_VORBIS_COMMENT_NUM_COMMENTS_LEN = FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_INDEX_OFFSET_LEN = 64; /* bits */ FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_INDEX_NUMBER_LEN = 8; /* bits */ -FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_INDEX_RESERVED_LEN = 3*8; /* bits @@@@3*/ +FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_INDEX_RESERVED_LEN = 3*8; /* bits */ FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_OFFSET_LEN = 64; /* bits */ FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_NUMBER_LEN = 8; /* bits */ FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_ISRC_LEN = 12*8; /* bits */ FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_TYPE_LEN = 1; /* bit */ FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_PRE_EMPHASIS_LEN = 1; /* bit */ -FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_RESERVED_LEN = 6+13*8; /* bits @@@@13*/ +FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_RESERVED_LEN = 6+13*8; /* bits */ FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_TRACK_NUM_INDICES_LEN = 8; /* bits */ FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_MEDIA_CATALOG_NUMBER_LEN = 128*8; /* bits */ FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_LEAD_IN_LEN = 64; /* bits */ FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_IS_CD_LEN = 1; /* bit */ -FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_RESERVED_LEN = 7+258*8; /* bits @@@@258 */ +FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_RESERVED_LEN = 7+258*8; /* bits */ FLAC_API const unsigned FLAC__STREAM_METADATA_CUESHEET_NUM_TRACKS_LEN = 8; /* bits */ FLAC_API const unsigned FLAC__STREAM_METADATA_IS_LAST_LEN = 1; /* bits */ diff --git a/src/libFLAC/lpc.c b/src/libFLAC/lpc.c index a996c39a..6ec5a91b 100644 --- a/src/libFLAC/lpc.c +++ b/src/libFLAC/lpc.c @@ -220,7 +220,7 @@ void FLAC__lpc_compute_residual_from_qlp_coefficients(const FLAC__int32 data[], sum += qlp_coeff[j] * (*(--history)); #ifdef FLAC__OVERFLOW_DETECT sumo += (FLAC__int64)qlp_coeff[j] * (FLAC__int64)(*history); -#if defined _MSC_VER /* don't know how to do 64-bit literals in VC++ */ +#if defined _MSC_VER if(sumo > 2147483647I64 || sumo < -2147483648I64) #else if(sumo > 2147483647ll || sumo < -2147483648ll) @@ -303,7 +303,7 @@ void FLAC__lpc_restore_signal(const FLAC__int32 residual[], unsigned data_len, c sum += qlp_coeff[j] * (*(--history)); #ifdef FLAC__OVERFLOW_DETECT sumo += (FLAC__int64)qlp_coeff[j] * (FLAC__int64)(*history); -#if defined _MSC_VER /* don't know how to do 64-bit literals in VC++ */ +#if defined _MSC_VER if(sumo > 2147483647I64 || sumo < -2147483648I64) #else if(sumo > 2147483647ll || sumo < -2147483648ll) diff --git a/src/libFLAC/metadata_object.c b/src/libFLAC/metadata_object.c index 8bf1dd59..12f6b901 100644 --- a/src/libFLAC/metadata_object.c +++ b/src/libFLAC/metadata_object.c @@ -294,7 +294,6 @@ static FLAC__bool cuesheet_set_track_(FLAC__StreamMetadata *object, FLAC__Stream FLAC__ASSERT(0 != src); FLAC__ASSERT(object->type == FLAC__METADATA_TYPE_CUESHEET); FLAC__ASSERT((0 != src->indices && src->num_indices > 0) || (0 == src->indices && src->num_indices == 0)); - /*@@@@ for docs, note that there is no "&& copy == false" at the end here ^^^ which will filter up */ save = dest->indices; diff --git a/src/metaflac/operations_shorthand_cuesheet.c b/src/metaflac/operations_shorthand_cuesheet.c index 203211e3..f61d8f8d 100644 --- a/src/metaflac/operations_shorthand_cuesheet.c +++ b/src/metaflac/operations_shorthand_cuesheet.c @@ -119,7 +119,7 @@ FLAC__bool import_cs_from(const char *filename, FLAC__StreamMetadata **cuesheet, return false; } - *cuesheet = grabbag__cuesheet_parse(f, &error_message, &last_line_read, /*@@@@is_cdda=*/true, lead_out_offset); + *cuesheet = grabbag__cuesheet_parse(f, &error_message, &last_line_read, /*@@@is_cdda=*/true, lead_out_offset); if(f != stdin) fclose(f); diff --git a/src/share/grabbag/cuesheet.c b/src/share/grabbag/cuesheet.c index 0e64c647..6540e6fb 100644 --- a/src/share/grabbag/cuesheet.c +++ b/src/share/grabbag/cuesheet.c @@ -269,7 +269,7 @@ static FLAC__bool local__cuesheet_parse_(FILE *file, const char **error_message, *error_message = "CD-DA INDEX number must be between 0 and 99, inclusive"; return false; } - /*@@@@ search for duplicate track number? */ + /*@@@ search for duplicate track number? */ if(0 == (field = local__get_field_(&line))) { *error_message = "INDEX is missing an offset after the index number"; return false; @@ -371,7 +371,7 @@ static FLAC__bool local__cuesheet_parse_(FILE *file, const char **error_message, *error_message = "CD-DA TRACK numbers must be sequential"; return false; } - /*@@@@ search for duplicate track number? */ + /*@@@ search for duplicate track number? */ if(0 == (field = local__get_field_(&line))) { *error_message = "TRACK is missing a track type after the track number"; return false; @@ -381,7 +381,7 @@ static FLAC__bool local__cuesheet_parse_(FILE *file, const char **error_message, return false; } cs->tracks[cs->num_tracks-1].number = in_track_num; - cs->tracks[cs->num_tracks-1].type = (0 == FLAC__STRCASECMP(field, "AUDIO"))? 0 : 1; /*@@@@ should we be more strict with the value here? */ + cs->tracks[cs->num_tracks-1].type = (0 == FLAC__STRCASECMP(field, "AUDIO"))? 0 : 1; /*@@@ should we be more strict with the value here? */ in_index_num = -1; track_has_flags = false; track_has_isrc = false; @@ -422,7 +422,7 @@ static FLAC__bool local__cuesheet_parse_(FILE *file, const char **error_message, return false; } forced_leadout_track_num = (unsigned)track_num; - /*@@@@ search for duplicate track number? */ + /*@@@ search for duplicate track number? */ if(0 == (field = local__get_field_(&line))) { *error_message = "FLAC__lead-out is missing offset"; return false;