From e8721c1e4e8723fa16d52a29128b946dae808ba8 Mon Sep 17 00:00:00 2001 From: rocky Date: Sun, 18 Sep 2005 20:34:02 +0000 Subject: [PATCH] The type of (option) opt needs to be int not char and this is noticable on ppc where char is unsigned by default. Furthermore, poptGetNextOpt() returns an int, not a char. Bug noticed and patch all thanks to Nicolas Boullis. --- src/cd-info.c | 4 ++-- src/cd-read.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cd-info.c b/src/cd-info.c index bd9a3980..ee790e77 100644 --- a/src/cd-info.c +++ b/src/cd-info.c @@ -1,5 +1,5 @@ /* - $Id: cd-info.c,v 1.143 2005/09/15 06:36:01 rocky Exp $ + $Id: cd-info.c,v 1.144 2005/09/18 20:34:02 rocky Exp $ Copyright (C) 2003, 2004, 2005 Rocky Bernstein Copyright (C) 1996, 1997, 1998 Gerd Knorr @@ -115,7 +115,7 @@ char *temp_str; static bool parse_options (int argc, const char *argv[]) { - char opt; /* used for argument parsing */ + int opt; /* used for argument parsing */ char *psz_my_source; struct poptOption optionsTable[] = { diff --git a/src/cd-read.c b/src/cd-read.c index 307cb006..ea73aa7a 100644 --- a/src/cd-read.c +++ b/src/cd-read.c @@ -1,5 +1,5 @@ /* - $Id: cd-read.c,v 1.24 2005/02/19 11:43:05 rocky Exp $ + $Id: cd-read.c,v 1.25 2005/09/18 20:34:02 rocky Exp $ Copyright (C) 2003, 2004, 2005 Rocky Bernstein @@ -178,7 +178,7 @@ static bool parse_options (int argc, const char *argv[]) { - char opt; + int opt; char *psz_my_source; char *opt_arg;