Try to regularize naming better. More mmc_ -> cdio_mmc_

Add more debug variables to be able to get at enum values in a debugger.
This commit is contained in:
rocky
2005-10-21 11:13:54 +00:00
parent 4e67d2192a
commit fa0848bf90
5 changed files with 65 additions and 36 deletions

View File

@@ -1,5 +1,5 @@
/*
$Id: mmc.h,v 1.21 2005/06/26 18:29:49 rocky Exp $
$Id: mmc.h,v 1.22 2005/10/21 11:13:54 rocky Exp $
Copyright (C) 2003, 2004, 2005 Rocky Bernstein <rocky@panix.com>
@@ -52,10 +52,8 @@ extern "C" {
#define MMC_READ_TIMEOUT_DEFAULT 3*60*1000
/*! \brief The opcode-portion (generic packet commands) of an MMC command.
In general, those opcodes that end in 6 take a 6-byte command
descriptor, those that end in 10 take a 10-byte
descriptor and those that in in 12 take a 12-byte descriptor.
@@ -293,7 +291,7 @@ typedef enum {
identifier. */
CDIO_MMC_FEATURE_FIRMWARE_DATE = 0x1FF, /**< Firmware creation date
report */
} mmc_feature_t;
} cdio_mmc_feature_t;
/*! Profile profile codes used in GET_CONFIGURATION - PROFILE LIST. */
typedef enum {
@@ -331,7 +329,7 @@ typedef enum {
double layer */
CDIO_MMC_FEATURE_PROF_NON_CONFORM = 0xFFFF, /**< The Logical Unit does not
conform to any Profile. */
} mmc_feature_profile_t;
} cdio_mmc_feature_profile_t;
typedef enum {
CDIO_MMC_FEATURE_INTERFACE_UNSPECIFIED = 0,
@@ -340,7 +338,7 @@ typedef enum {
CDIO_MMC_FEATURE_INTERFACE_IEEE_1394 = 3,
CDIO_MMC_FEATURE_INTERFACE_IEEE_1394A = 4,
CDIO_MMC_FEATURE_INTERFACE_FIBRE_CH = 5
} mmc_feature_interface_t;
} cdio_mmc_feature_interface_t;
/*! The largest Command Descriptor Block (CDB) size.
@@ -367,7 +365,7 @@ typedef struct mmc_cdb_s {
unsigned char reserved2;
unsigned char profile_msb;
unsigned char profile_lsb;
} mmc_feature_list_header_t;
} cdio_mmc_feature_list_header_t;
/*! An enumeration indicating whether an MMC command is sending
data or getting data.
@@ -375,13 +373,13 @@ typedef struct mmc_cdb_s {
typedef enum mmc_direction_s {
SCSI_MMC_DATA_READ,
SCSI_MMC_DATA_WRITE
} mmc_direction_t;
} cdio_mmc_direction_t;
typedef struct mmc_subchannel_s
{
uint8_t reserved;
uint8_t audio_status;
uint16_t data_length; /* Really 7.2.2 */
uint16_t data_length; /**< Really ISO 9660 7.2.2 */
uint8_t format;
uint8_t address: 4;
uint8_t control: 4;
@@ -389,7 +387,7 @@ typedef struct mmc_cdb_s {
uint8_t index;
uint8_t abs_addr[4];
uint8_t rel_addr[4];
} mmc_subchannel_t;
} cdio_mmc_subchannel_t;
#define CDIO_MMC_SET_COMMAND(cdb, command) \
cdb[0] = command
@@ -580,7 +578,7 @@ mmc_audio_read_subchannel (CdIo_t *p_cdio,
@return true if we have the interface and false if not.
*/
bool_3way_t mmc_have_interface( CdIo_t *p_cdio,
mmc_feature_interface_t e_interface );
cdio_mmc_feature_interface_t e_interface );
/*! Run a MODE_SENSE command (6- or 10-byte version)
and put the results in p_buf
@@ -758,7 +756,7 @@ mmc_audio_read_subchannel (CdIo_t *p_cdio,
*/
int mmc_run_cmd( const CdIo_t *p_cdio, unsigned int i_timeout_ms,
const mmc_cdb_t *p_cdb,
mmc_direction_t e_direction, unsigned int i_buf,
cdio_mmc_direction_t e_direction, unsigned int i_buf,
/*in/out*/ void *p_buf );
/*!
Set the block size for subsequest read requests, via MMC.
@@ -790,7 +788,21 @@ mmc_audio_read_subchannel (CdIo_t *p_cdio,
}
#endif /* __cplusplus */
/** The below variables are trickery to force the above enum symbol
values to be recorded in debug symbol tables. They are used to
allow one refer to the enumeration value names in the typedefs
above in a debugger and debugger expressions
*/
extern cdio_mmc_gpcmd_t debug_cdio_mmc_gpcmd;
extern cdio_mmc_read_sub_state_t debug_cdio_mmc_read_sub_state;
extern cdio_mmc_feature_t debug_cdio_mmc_feature;
extern cdio_mmc_feature_profile_t debug_cdio_mmc_feature_profile;
extern cdio_mmc_feature_interface_t debug_cdio_mmc_feature_interface;
/** For backward compatibility. */
#define mmc_direction_t cdio_mmc_direction_t
#define mmc_feature_interface_t cdio_mmc_feature_interface_t
#define mmc_subchannel_t cdio_mmc_subchannel_t
#define scsi_mmc_cdb_t mmc_cdb_t
#define scsi_mmc_direction_t mmc_direction_t
#define scsi_mmc_get_cmd_len mmc_get_cmd_len

View File

@@ -1,5 +1,5 @@
/*
$Id: gnu_linux.c,v 1.17 2005/07/23 22:05:29 rocky Exp $
$Id: gnu_linux.c,v 1.18 2005/10/21 11:13:54 rocky Exp $
Copyright (C) 2001 Herbert Valerio Riedel <hvr@gnu.org>
Copyright (C) 2002, 2003, 2004, 2005 Rocky Bernstein <rocky@panix.com>
@@ -27,7 +27,7 @@
# include "config.h"
#endif
static const char _rcsid[] = "$Id: gnu_linux.c,v 1.17 2005/07/23 22:05:29 rocky Exp $";
static const char _rcsid[] = "$Id: gnu_linux.c,v 1.18 2005/10/21 11:13:54 rocky Exp $";
#include <string.h>
@@ -100,11 +100,12 @@ typedef struct {
/**** prototypes for static functions ****/
static bool is_cdrom_linux(const char *drive, char *mnttype);
static bool read_toc_linux (void *p_user_data);
static driver_return_code_t run_mmc_cmd_linux( void *p_user_data,
static driver_return_code_t
run_mmc_cmd_linux( void *p_user_data,
unsigned int i_timeout,
unsigned int i_cdb,
const mmc_cdb_t *p_cdb,
mmc_direction_t e_direction,
cdio_mmc_direction_t e_direction,
unsigned int i_buf,
/*in/out*/ void *p_buf );
static access_mode_t
@@ -1104,7 +1105,7 @@ static driver_return_code_t
run_mmc_cmd_linux( void *p_user_data,
unsigned int i_timeout_ms,
unsigned int i_cdb, const mmc_cdb_t *p_cdb,
mmc_direction_t e_direction,
cdio_mmc_direction_t e_direction,
unsigned int i_buf, /*in/out*/ void *p_buf )
{
const _img_private_t *p_env = p_user_data;

View File

@@ -162,6 +162,11 @@ cdtext_get_const
cdtext_init
cdtext_is_keyword
cdtext_set
debug_cdio_mmc_gpcmd_t
debug_cdio_mmc_read_sub_state_t
debug_cdio_mmc_feature_t
debug_cdio_mmc_feature_profile_t
debug_cdio_mmc_feature_interface_t
discmode2str
mmc_audio_read_subchannel
mmc_audio_state2str

View File

@@ -1,6 +1,6 @@
/* Common Multimedia Command (MMC) routines.
$Id: mmc.c,v 1.27 2005/06/26 18:29:49 rocky Exp $
$Id: mmc.c,v 1.28 2005/10/21 11:13:54 rocky Exp $
Copyright (C) 2004, 2005 Rocky Bernstein <rocky@panix.com>
@@ -45,6 +45,17 @@
#include <errno.h>
#endif
/** The below variables are trickery to force the above enum symbol
values to be recorded in debug symbol tables. They are used to
allow one refer to the enumeration value names in the typedefs
above in a debugger and debugger expressions
*/
cdio_mmc_gpcmd_t debug_cdio_mmc_gpcmd;
cdio_mmc_read_sub_state_t debug_cdio_mmc_read_sub_state;
cdio_mmc_feature_t debug_cdio_mmc_feature;
cdio_mmc_feature_profile_t debug_cdio_mmc_feature_profile;
cdio_mmc_feature_interface_t debug_cdio_mmc_feature_interface;
/*************************************************************************
MMC CdIo Operations which a driver may use.
These are not accessible directly.
@@ -587,7 +598,7 @@ mmc_audio_read_subchannel (CdIo_t *p_cdio, cdio_subchannel_t *p_subchannel)
{
mmc_cdb_t cdb;
driver_return_code_t i_rc;
mmc_subchannel_t mmc_subchannel;
cdio_mmc_subchannel_t mmc_subchannel;
if (!p_cdio) return DRIVER_OP_UNINIT;
@@ -596,7 +607,7 @@ mmc_audio_read_subchannel (CdIo_t *p_cdio, cdio_subchannel_t *p_subchannel)
memset(&cdb, 0, sizeof(mmc_cdb_t));
CDIO_MMC_SET_COMMAND(cdb.field, CDIO_MMC_GPCMD_READ_SUBCHANNEL);
CDIO_MMC_SET_READ_LENGTH8(cdb.field, sizeof(mmc_subchannel_t));
CDIO_MMC_SET_READ_LENGTH8(cdb.field, sizeof(cdio_mmc_subchannel_t));
cdb.field[1] = CDIO_CDROM_MSF;
cdb.field[2] = 0x40; /* subq */
@@ -604,7 +615,7 @@ mmc_audio_read_subchannel (CdIo_t *p_cdio, cdio_subchannel_t *p_subchannel)
cdb.field[6] = 0; /* track number (only in isrc mode, ignored) */
i_rc = mmc_run_cmd(p_cdio, mmc_timeout_ms, &cdb, SCSI_MMC_DATA_READ,
sizeof(mmc_subchannel_t), &mmc_subchannel);
sizeof(cdio_mmc_subchannel_t), &mmc_subchannel);
if (DRIVER_OP_SUCCESS == i_rc) {
p_subchannel->format = mmc_subchannel.format;
p_subchannel->audio_status = mmc_subchannel.audio_status;
@@ -872,7 +883,7 @@ mmc_get_mcn ( const CdIo_t *p_cdio )
driver_return_code_t
mmc_run_cmd( const CdIo_t *p_cdio, unsigned int i_timeout_ms,
const mmc_cdb_t *p_cdb,
mmc_direction_t e_direction, unsigned int i_buf,
cdio_mmc_direction_t e_direction, unsigned int i_buf,
/*in/out*/ void *p_buf )
{
if (!p_cdio) return DRIVER_OP_UNINIT;
@@ -1148,7 +1159,7 @@ const char *mmc_feature_profile2str( int i_feature_profile )
* @return true if we have the feature and false if not.
*/
bool_3way_t
mmc_have_interface( CdIo_t *p_cdio, mmc_feature_interface_t e_interface )
mmc_have_interface( CdIo_t *p_cdio, cdio_mmc_feature_interface_t e_interface )
{
int i_status; /* Result of MMC command */
uint8_t buf[500] = { 0, }; /* Place to hold returned data */

View File

@@ -1,6 +1,6 @@
/* private MMC helper routines.
$Id: mmc_private.h,v 1.8 2005/03/06 00:03:53 rocky Exp $
$Id: mmc_private.h,v 1.9 2005/10/21 11:13:54 rocky Exp $
Copyright (C) 2004, 2005 Rocky Bernstein <rocky@panix.com>
@@ -110,7 +110,7 @@ typedef driver_return_code_t (*mmc_run_cmd_fn_t)
unsigned int i_timeout_ms,
unsigned int i_cdb,
const mmc_cdb_t *p_cdb,
mmc_direction_t e_direction,
cdio_mmc_direction_t e_direction,
unsigned int i_buf, /*in/out*/ void *p_buf );
int mmc_set_blocksize_mmc_private ( const void *p_env, const