Commit Graph

22 Commits

Author SHA1 Message Date
R. Bernstein
21f3187bb8 More small header changes:
* Remove leading underscores in header preprocessor names
* Regularize names to include directory parts in the file name
* Untabify files
* Update copyright and remove unmaintained cvs $Id$ line

The justification for removing leading underscores comes from a CERTS Secure Coding recommendation: https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier

See also Savannah bug #35745 https://savannah.gnu.org/bugs/?35745
2012-03-18 12:02:01 -04:00
R. Bernstein
abe5b84295 Multilanguage CD-Text from greenleon 2012-03-05 21:22:08 -05:00
R. Bernstein
14f6f505ce Some more pbatard patches 2012-03-04 14:12:09 -05:00
R. Bernstein
b1d2146ab4 Reduce complation warnings via changes in pbatard branch 2012-03-03 19:52:41 -05:00
R. Bernstein
f130f66c5d mmc_hl_cmds.c: remove gcc warning
solaris.c: remove unused fn warning when not on solaris
check_cue.sh.in: fix so we can build outside of source tree. With this, "make distcheck" works again.
2012-01-28 20:56:30 -05:00
R. Bernstein
8d43aaca4d Patch from Leon Merten Lohse: Correct the length of the CD-TEXT block. 2011-12-04 20:29:53 -05:00
R. Bernstein
c242ca3997 Look for a NULL destination buffer in mmc_read_cd and return
DRIVER_OP_BAD_POINTER in this particular situation.
2011-11-27 17:47:50 -05:00
R. Bernstein
dbf6d24765 1) cdtext objects are no longer associated with a track but with the disc.
2) - cdio_get_cdtext no longer takes track as an argument
- cdtext_get, cdtext_get_const, cdtext_set require track argument
3) Language, Genre, Genre Code and Encoding Fields are now properly parsed and stored in the cdtext object
4) Added public function cdio_get_cdtext_raw to extract the binary CD-Text
5) Added CDTEXTFILE keyword logic in cue sheet parser. Parses binary/raw CD-Text files
6) Added cdtext_genre2str to convert genre code
7) altered the example programs, test drivers, cdda-player and cd-info to work with these changes
8) Added test case
9) A few smaller changes
A disc either holds CD-Text for all the tracks or does not hold any. Therefore a CD-Text object for the whole disc seems more natural to me. It also enables us to store global fields, like genre, encoding, language.

Patch was tested on GNU/Linux 32 bit running Gentoo.
2011-11-24 20:54:40 -05:00
R. Bernstein
f215cad224 Make sure config.h or the copy of that gets included only once to reduce duplicate include
warnings.
2011-10-20 19:44:10 -04:00
rocky
940b7cd848 patch from Honza Horak using Coverity's static analysis tool. 2011-05-30 15:19:22 -04:00
rocky
f2438edcbc Add ISRC track info to cd-info output. Code from Scot C. Bontrager. 2011-05-18 09:48:03 -04:00
rocky
d10938c43c Add mmc routine to get the ISRC information on a CD that is in the q subchannel
but not showing up in the CDTEXT. Contributed by Scot C. Bontrager.
2011-05-17 22:59:36 -04:00
R. Bernstein
c10bee26b6 mmc_util.{c,h} Break simpler non-dependent mmc helper or utility routines from mmc.{c,h} 2010-02-22 15:18:59 -05:00
R. Bernstein
6e53c6b19f Small change 2010-02-11 06:39:06 -05:00
R. Bernstein
ff49db8449 Move another routine from mmc.c into mmc_hl_cmds.c 2010-02-11 06:35:22 -05:00
R. Bernstein
7f37476924 Split off MMC tests which don't involve exclusive access from those that do. 2010-02-10 22:30:37 -05:00
R. Bernstein
80304a8cef Add mmc_read_disc_information. Change get_disctype to use it and thus it
moves from mmc.c into mmc_hl_cmds.c. Status is now the return type, not
erasable.

Split mmc_cmds.h into mmc_ll_cmds.h and mmc_hl_cmds.h.
test/driver/mmc.c for invalid page check we get the right sense key,
asc, and ascq.
2010-02-09 22:39:05 -05:00
R. Bernstein
5656a0b14c Remove duplicate cdio_mmc_disctype_t. 2010-02-08 19:01:14 -05:00
R. Bernstein
100654b51b Fix all fo the bugs I introduced "improving" the code of others.
mmc_ll_cmds.c: mmc_mode_select and mmc_get_configuration now work.
mmc_hl_cmds.c: bug introduced by turning a var into a pointer to that variable.
2010-02-08 16:56:04 -05:00
R. Bernstein
2d3b7d28b4 Add SCSI-MMC GET CONFIGURATION.
Add Frank Endres' disc type determination via MMC.
Be more careful to suffix with CDIO_MMC which I hope will reduce possible name conflicts.
2010-02-07 21:04:21 -05:00
R. Bernstein
aa7f7e1315 Start populating mmc/mmc_hl_cmds.c. Create mmc directory in preparation
for making it a library.

mmc.h:  CDIO_MMC_GPCMD_ALLOW_MEDIUM_REMOVAL ->
        CDIO_MMC_GPCMD_PREVENT_ALLOW_MEDIUM_REMOVAL
mmc.c:  Move mm_eject_media and mmc_set_drive_speed to mmc/mmc_hl_cmds.c
mmc_ll_cmds.c: add mmc_prevent_allow_medium_removal,
               move mmc_mode_sense to mmc/mmc_hl_cmds.c
2010-02-07 19:21:33 -05:00
R. Bernstein
d3a0ba06e1 Move more towards making MMC a library. Start to reorganize more to
break out 1-1 SCSI-MMC commands (in mmc_ll_cmds.c) from higher-level
commands which use the lower-level ones.
2010-02-07 18:35:47 -05:00