Add InstructionSetExtensionDto and update InstructionSetExtensionsController to use DTO for extension operations

Marechai.Data/Dtos/InstructionSetExtensionDto.cs

@@ -0,0 +1,36 @@
+/******************************************************************************
+// MARECHAI: Master repository of computing history artifacts information
+// ----------------------------------------------------------------------------
+//
+// Author(s)      : Natalia Portillo <claunia@claunia.com>
+//
+// --[ License ] --------------------------------------------------------------
+//
+//     This program is free software: you can redistribute it and/or modify
+//     it under the terms of the GNU General Public License as
+//     published by the Free Software Foundation, either version 3 of the
+//     License, or (at your option) any later version.
+//
+//     This program is distributed in the hope that it will be useful,
+//     but WITHOUT ANY WARRANTY; without even the implied warranty of
+//     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+//     GNU General Public License for more details.
+//
+//     You should have received a copy of the GNU General Public License
+//     along with this program.  If not, see <http://www.gnu.org/licenses/>.
+//
+// ----------------------------------------------------------------------------
+// Copyright © 2003-2021 Natalia Portillo
+*******************************************************************************/
+
+using System.ComponentModel.DataAnnotations;
+using System.Text.Json.Serialization;
+
+namespace Marechai.Data.Dtos;
+
+public class InstructionSetExtensionDto : BaseDto<int>
+{
+    [JsonPropertyName("extension")]
+    [Required]
+    public required string Extension { get; set; }
+}

Marechai.Server/Controllers/InstructionSetExtensionsController.cs

@@ -28,6 +28,7 @@ using System.Collections.Generic;
 using System.Linq;
 using System.Security.Claims;
 using System.Threading.Tasks;
+using Marechai.Data.Dtos;
 using Marechai.Database.Models;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Http;
@@ -44,25 +45,31 @@ public class InstructionSetExtensionsController(MarechaiContext context) : Contr
     [AllowAnonymous]
     [ProducesResponseType(StatusCodes.Status200OK)]
     [ProducesResponseType(StatusCodes.Status400BadRequest)]
-    public Task<List<InstructionSetExtension>> GetAsync() => context.InstructionSetExtensions.OrderBy(e => e.Extension)
+    public Task<List<InstructionSetExtensionDto>> GetAsync()
-                                                                    .Select(e => new InstructionSetExtension
+    {
+        return context.InstructionSetExtensions.OrderBy(e => e.Extension)
+        .Select(e => new InstructionSetExtensionDto
         {
             Extension = e.Extension,
             Id = e.Id
         })
         .ToListAsync();
+    }
 
     [HttpGet("{id:int}")]
     [AllowAnonymous]
     [ProducesResponseType(StatusCodes.Status200OK)]
     [ProducesResponseType(StatusCodes.Status400BadRequest)]
-    public Task<InstructionSetExtension> GetAsync(int id) => context.InstructionSetExtensions.Where(e => e.Id == id)
+    public Task<InstructionSetExtensionDto> GetAsync(int id)
-                                                                    .Select(e => new InstructionSetExtension
+    {
+        return context.InstructionSetExtensions.Where(e => e.Id == id)
+        .Select(e => new InstructionSetExtensionDto
         {
             Extension = e.Extension,
             Id = e.Id
         })
         .FirstOrDefaultAsync();
+    }
 
     [HttpPut("{id:int}")]
     [Authorize(Roles = "Admin,UberAdmin")]
@@ -70,14 +77,14 @@ public class InstructionSetExtensionsController(MarechaiContext context) : Contr
     [ProducesResponseType(StatusCodes.Status400BadRequest)]
     [ProducesResponseType(StatusCodes.Status404NotFound)]
     [ProducesResponseType(StatusCodes.Status401Unauthorized)]
-    public async Task<ActionResult> UpdateAsync(int id, [FromBody] InstructionSetExtension viewModel)
+    public async Task<ActionResult> UpdateAsync(int id, [FromBody] InstructionSetExtensionDto viewModel)
     {
-        string userId = User.FindFirstValue(ClaimTypes.Sid);
+        var userId = User.FindFirstValue(ClaimTypes.Sid);
 
-        if(userId is null) return Unauthorized();
+        if (userId is null) return Unauthorized();
-        InstructionSetExtension model = await context.InstructionSetExtensions.FindAsync(viewModel.Id);
+        var model = await context.InstructionSetExtensions.FindAsync(viewModel.Id);
 
-        if(model is null) return NotFound();
+        if (model is null) return NotFound();
 
         model.Extension = viewModel.Extension;
 
@@ -91,11 +98,11 @@ public class InstructionSetExtensionsController(MarechaiContext context) : Contr
     [ProducesResponseType(StatusCodes.Status200OK)]
     [ProducesResponseType(StatusCodes.Status400BadRequest)]
     [ProducesResponseType(StatusCodes.Status401Unauthorized)]
-    public async Task<ActionResult<int>> CreateAsync([FromBody] InstructionSetExtension viewModel)
+    public async Task<ActionResult<int>> CreateAsync([FromBody] InstructionSetExtensionDto viewModel)
     {
-        string userId = User.FindFirstValue(ClaimTypes.Sid);
+        var userId = User.FindFirstValue(ClaimTypes.Sid);
 
-        if(userId is null) return Unauthorized();
+        if (userId is null) return Unauthorized();
 
         var model = new InstructionSetExtension
         {
@@ -116,12 +123,12 @@ public class InstructionSetExtensionsController(MarechaiContext context) : Contr
     [ProducesResponseType(StatusCodes.Status401Unauthorized)]
     public async Task<ActionResult> DeleteAsync(int id)
     {
-        string userId = User.FindFirstValue(ClaimTypes.Sid);
+        var userId = User.FindFirstValue(ClaimTypes.Sid);
 
-        if(userId is null) return Unauthorized();
+        if (userId is null) return Unauthorized();
-        InstructionSetExtension item = await context.InstructionSetExtensions.FindAsync(id);
+        var item = await context.InstructionSetExtensions.FindAsync(id);
 
-        if(item is null) return NotFound();
+        if (item is null) return NotFound();
 
         context.InstructionSetExtensions.Remove(item);
 
@@ -134,8 +141,10 @@ public class InstructionSetExtensionsController(MarechaiContext context) : Contr
     [AllowAnonymous]
     [ProducesResponseType(StatusCodes.Status200OK)]
     [ProducesResponseType(StatusCodes.Status400BadRequest)]
-    public bool VerifyUnique(string extension) =>
+    public bool VerifyUnique(string extension)
-        !context.InstructionSetExtensions.Any(i => string.Equals(i.Extension,
+    {
+        return !context.InstructionSetExtensions.Any(i => string.Equals(i.Extension,
             extension,
             StringComparison.OrdinalIgnoreCase));
+    }
 }