claunia/marechai
1
0
Fork 0
mirror of https://github.com/claunia/marechai.git synced 2025-12-16 19:14:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor BookScansController routes and method signatures for improved clarity and consistency

Browse Source
This commit is contained in:
Natalia Portillo
2025-11-13 20:19:02 +00:00
parent 583f20ff99
commit 0ba1a24b4e
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Marechai.Server/Controllers/BookScansController.cs
View File

@@ -37,18 +37,18 @@ using Microsoft.EntityFrameworkCore;
namespace Marechai.Server.Controllers; namespace Marechai.Server.Controllers;
[Route("/book-scans")] [Route("/books/scans")]
[ApiController] [ApiController]
public class BookScansController(MarechaiContext context) : ControllerBase public class BookScansController(MarechaiContext context) : ControllerBase
{ {
[HttpGet] [HttpGet("/books/{bookId:long}/scans")]
[AllowAnonymous] [AllowAnonymous]
[ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status400BadRequest)]
public Task<List<Guid>> GetGuidsByBookAsync(long bookId) => public Task<List<Guid>> GetGuidsByBookAsync(long bookId) =>
context.BookScans.Where(p => p.BookId == bookId).Select(p => p.Id).ToListAsync(); context.BookScans.Where(p => p.BookId == bookId).Select(p => p.Id).ToListAsync();
[HttpGet] [HttpGet("{id:Guid}")]
[AllowAnonymous] [AllowAnonymous]
[ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status400BadRequest)]
@@ -76,18 +76,19 @@ public class BookScansController(MarechaiContext context) : ControllerBase
}) })
.FirstOrDefaultAsync(); .FirstOrDefaultAsync();
[HttpPost] [HttpPut("{id:Guid}")]
[Authorize(Roles = "Admin,UberAdmin")] [Authorize(Roles = "Admin,UberAdmin")]
[ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status400BadRequest)]
[ProducesResponseType(StatusCodes.Status404NotFound)] [ProducesResponseType(StatusCodes.Status404NotFound)]
[ProducesResponseType(StatusCodes.Status401Unauthorized)] [ProducesResponseType(StatusCodes.Status401Unauthorized)]
public async Task<ActionResult> UpdateAsync(BookScanDto dto) public async Task<ActionResult> UpdateAsync(Guid id, [FromBody] BookScanDto dto)
{ {
string userId = User.FindFirstValue(ClaimTypes.Sid); string userId = User.FindFirstValue(ClaimTypes.Sid);
if(userId is null) return Unauthorized(); if(userId is null) return Unauthorized();
BookScan model = await context.BookScans.FindAsync(dto.Id);
BookScan model = await context.BookScans.FindAsync(id);
if(model is null) return NotFound(); if(model is null) return NotFound();
@@ -115,7 +116,7 @@ public class BookScansController(MarechaiContext context) : ControllerBase
[ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status400BadRequest)]
[ProducesResponseType(StatusCodes.Status401Unauthorized)] [ProducesResponseType(StatusCodes.Status401Unauthorized)]
public async Task<ActionResult<Guid>> CreateAsync(BookScanDto dto) public async Task<ActionResult<Guid>> CreateAsync([FromBody] BookScanDto dto)
{ {
string userId = User.FindFirstValue(ClaimTypes.Sid); string userId = User.FindFirstValue(ClaimTypes.Sid);
@@ -149,7 +150,7 @@ public class BookScansController(MarechaiContext context) : ControllerBase
return model.Id; return model.Id;
} }
[HttpDelete] [HttpDelete("{id:Guid}")]
[Authorize(Roles = "Admin,UberAdmin")] [Authorize(Roles = "Admin,UberAdmin")]
[ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status400BadRequest)]
@@ -160,6 +161,7 @@ public class BookScansController(MarechaiContext context) : ControllerBase
string userId = User.FindFirstValue(ClaimTypes.Sid); string userId = User.FindFirstValue(ClaimTypes.Sid);
if(userId is null) return Unauthorized(); if(userId is null) return Unauthorized();
BookScan item = await context.BookScans.FindAsync(id); BookScan item = await context.BookScans.FindAsync(id);
if(item is null) return NotFound(); if(item is null) return NotFound();