Refactor CompaniesByDocumentController routes and method signatures for improved clarity and consistency

This commit is contained in:
2025-11-13 20:35:47 +00:00
parent d301315fbf
commit bed72102e8

View File

@@ -36,11 +36,11 @@ using Microsoft.EntityFrameworkCore;
namespace Marechai.Server.Controllers; namespace Marechai.Server.Controllers;
[Route("/companies-by-document")] [Route("/documents/companies")]
[ApiController] [ApiController]
public class CompaniesByDocumentController(MarechaiContext context) : ControllerBase public class CompaniesByDocumentController(MarechaiContext context) : ControllerBase
{ {
[HttpGet] [HttpGet("/documents/{documentId:long}/companies")]
[AllowAnonymous] [AllowAnonymous]
[ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status400BadRequest)]
@@ -59,7 +59,7 @@ public class CompaniesByDocumentController(MarechaiContext context) : Controller
.ThenBy(p => p.Role) .ThenBy(p => p.Role)
.ToListAsync(); .ToListAsync();
[HttpDelete] [HttpDelete("{id:long}")]
[Authorize(Roles = "Admin,UberAdmin")] [Authorize(Roles = "Admin,UberAdmin")]
[ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status400BadRequest)]
@@ -70,6 +70,7 @@ public class CompaniesByDocumentController(MarechaiContext context) : Controller
string userId = User.FindFirstValue(ClaimTypes.Sid); string userId = User.FindFirstValue(ClaimTypes.Sid);
if(userId is null) return Unauthorized(); if(userId is null) return Unauthorized();
CompaniesByDocument item = await context.CompaniesByDocuments.FindAsync(id); CompaniesByDocument item = await context.CompaniesByDocuments.FindAsync(id);
if(item is null) return NotFound(); if(item is null) return NotFound();
@@ -86,7 +87,7 @@ public class CompaniesByDocumentController(MarechaiContext context) : Controller
[ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status400BadRequest)]
[ProducesResponseType(StatusCodes.Status401Unauthorized)] [ProducesResponseType(StatusCodes.Status401Unauthorized)]
public async Task<ActionResult<long>> CreateAsync(int companyId, long documentId, string roleId) public async Task<ActionResult<long>> CreateAsync([FromBody] CompanyByDocumentDto dto)
{ {
string userId = User.FindFirstValue(ClaimTypes.Sid); string userId = User.FindFirstValue(ClaimTypes.Sid);
@@ -94,9 +95,9 @@ public class CompaniesByDocumentController(MarechaiContext context) : Controller
var item = new CompaniesByDocument var item = new CompaniesByDocument
{ {
CompanyId = companyId, CompanyId = dto.CompanyId,
DocumentId = documentId, DocumentId = dto.DocumentId,
RoleId = roleId RoleId = dto.RoleId
}; };
await context.CompaniesByDocuments.AddAsync(item); await context.CompaniesByDocuments.AddAsync(item);