From d301315fbf17a31a26fc54ed578c45f8273db7a2 Mon Sep 17 00:00:00 2001
From: Natalia Portillo <claunia@claunia.com>
Date: Thu, 13 Nov 2025 20:33:41 +0000
Subject: [PATCH] Refactor CompaniesByBookController routes and method
 signatures for improved clarity and consistency

---
 .../Controllers/CompaniesByBookController.cs       | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/Marechai.Server/Controllers/CompaniesByBookController.cs b/Marechai.Server/Controllers/CompaniesByBookController.cs
index c3d01a21..c1ea0a8e 100644
--- a/Marechai.Server/Controllers/CompaniesByBookController.cs
+++ b/Marechai.Server/Controllers/CompaniesByBookController.cs
@@ -36,11 +36,11 @@ using Microsoft.EntityFrameworkCore;
 
 namespace Marechai.Server.Controllers;
 
-[Route("/companies-by-book")]
+[Route("/books/companies")]
 [ApiController]
 public class CompaniesByBookController(MarechaiContext context) : ControllerBase
 {
-    [HttpGet]
+    [HttpGet("/books/{bookId:long}/companies")]
     [AllowAnonymous]
     [ProducesResponseType(StatusCodes.Status200OK)]
     [ProducesResponseType(StatusCodes.Status400BadRequest)]
@@ -59,7 +59,7 @@ public class CompaniesByBookController(MarechaiContext context) : ControllerBase
                                                                          .ThenBy(p => p.Role)
                                                                          .ToListAsync();
 
-    [HttpDelete]
+    [HttpDelete("{id:long}")]
     [Authorize(Roles = "Admin,UberAdmin")]
     [ProducesResponseType(StatusCodes.Status200OK)]
     [ProducesResponseType(StatusCodes.Status400BadRequest)]
@@ -86,7 +86,7 @@ public class CompaniesByBookController(MarechaiContext context) : ControllerBase
     [ProducesResponseType(StatusCodes.Status200OK)]
     [ProducesResponseType(StatusCodes.Status400BadRequest)]
     [ProducesResponseType(StatusCodes.Status401Unauthorized)]
-    public async Task<ActionResult<long>> CreateAsync(int companyId, long bookId, string roleId)
+    public async Task<ActionResult<long>> CreateAsync([FromBody] CompanyByBookDto dto)
     {
         string userId = User.FindFirstValue(ClaimTypes.Sid);
 
@@ -94,9 +94,9 @@ public class CompaniesByBookController(MarechaiContext context) : ControllerBase
 
         var item = new CompaniesByBook
         {
-            CompanyId = companyId,
-            BookId    = bookId,
-            RoleId    = roleId
+            CompanyId = dto.CompanyId,
+            BookId    = dto.BookId,
+            RoleId    = dto.RoleId
         };
 
         await context.CompaniesByBooks.AddAsync(item);