claunia/marechai
1
0
Fork 0
mirror of https://github.com/claunia/marechai.git synced 2025-12-16 19:14:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor MachinesController to improve route clarity by adding route parameters and updating service dependencies

Browse Source
This commit is contained in:
Natalia Portillo
2025-11-13 22:20:03 +00:00
parent 7c29302153
commit e9a2a68e49
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
Marechai.Server/Controllers/MachinesController.cs
View File

@@ -35,7 +35,6 @@ using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc; using Microsoft.AspNetCore.Mvc;
using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Localization;
namespace Marechai.Server.Controllers; namespace Marechai.Server.Controllers;
@@ -43,11 +42,10 @@ namespace Marechai.Server.Controllers;
[ApiController] [ApiController]
public class MachinesController public class MachinesController
( (
MarechaiContext context, MarechaiContext context,
IStringLocalizer<MachinesService> localizer, GpusController gpusController,
GpusService gpusService, ProcessorsController processorsController,
ProcessorsService processorsService, SoundSynthsController soundSynthsController
SoundSynthsService soundSynthsService
) : ControllerBase ) : ControllerBase
{ {
[HttpGet] [HttpGet]
@@ -69,7 +67,7 @@ public class MachinesController
}) })
.ToListAsync(); .ToListAsync();
[HttpGet] [HttpGet("{id:int}")]
[AllowAnonymous] [AllowAnonymous]
[ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status400BadRequest)]
@@ -193,7 +191,7 @@ public class MachinesController
return model.Id; return model.Id;
} }
[HttpGet] [HttpGet("{id:int}/full")]
[AllowAnonymous] [AllowAnonymous]
[ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status400BadRequest)]
@@ -234,7 +232,7 @@ public class MachinesController
model.FamilyId = family.Id; model.FamilyId = family.Id;
} }
model.Gpus = await gpusService.GetByMachineAsync(machine.Id); model.Gpus = await gpusController.GetByMachineAsync(machine.Id);
model.Memory = await context.MemoryByMachine.Where(m => m.MachineId == machine.Id) model.Memory = await context.MemoryByMachine.Where(m => m.MachineId == machine.Id)
.Select(m => new MemoryDto .Select(m => new MemoryDto
@@ -246,9 +244,9 @@ public class MachinesController
}) })
.ToListAsync(); .ToListAsync();
model.Processors = await processorsService.GetByMachineAsync(machine.Id); model.Processors = await processorsController.GetByMachineAsync(machine.Id);
model.SoundSynthesizers = await soundSynthsService.GetByMachineAsync(machine.Id); model.SoundSynthesizers = await soundSynthsController.GetByMachineAsync(machine.Id);
model.Storage = await context.StorageByMachine.Where(s => s.MachineId == machine.Id) model.Storage = await context.StorageByMachine.Where(s => s.MachineId == machine.Id)
.Select(s => new StorageDto .Select(s => new StorageDto
@@ -262,7 +260,7 @@ public class MachinesController
return model; return model;
} }
[HttpDelete] [HttpDelete("{id:int}")]
[Authorize(Roles = "Admin,UberAdmin")] [Authorize(Roles = "Admin,UberAdmin")]
[ProducesResponseType(StatusCodes.Status200OK)] [ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)] [ProducesResponseType(StatusCodes.Status400BadRequest)]