Refactor controller methods to return ActionResult for better error handling

This commit is contained in:
2025-11-13 18:52:45 +00:00
parent 505ace535f
commit fc6238aef1
55 changed files with 724 additions and 539 deletions

View File

@@ -90,14 +90,14 @@ public class BooksController(MarechaiContext context) : ControllerBase
[Authorize(Roles = "Admin,UberAdmin")]
[ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)]
public async Task UpdateAsync(BookDto dto)
public async Task<ActionResult> UpdateAsync(BookDto dto)
{
string userId = User.FindFirstValue(ClaimTypes.Sid);
if(userId is null) return;
if(userId is null) return Unauthorized();
Book model = await context.Books.FindAsync(dto.Id);
if(model is null) return;
if(model is null) return NotFound();
model.Title = dto.Title;
model.NativeTitle = dto.NativeTitle;
@@ -110,6 +110,8 @@ public class BooksController(MarechaiContext context) : ControllerBase
model.PreviousId = dto.PreviousId;
model.SourceId = dto.SourceId;
await context.SaveChangesWithUserAsync(userId);
return Ok();
}
[HttpPost]
@@ -153,17 +155,19 @@ public class BooksController(MarechaiContext context) : ControllerBase
[Authorize(Roles = "Admin,UberAdmin")]
[ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)]
public async Task DeleteAsync(long id)
public async Task<ActionResult> DeleteAsync(long id)
{
string userId = User.FindFirstValue(ClaimTypes.Sid);
if(userId is null) return;
if(userId is null) return Unauthorized();
Book item = await context.Books.FindAsync(id);
if(item is null) return;
if(item is null) return NotFound();
context.Books.Remove(item);
await context.SaveChangesWithUserAsync(userId);
return Ok();
}
}