claunia/marechai
1
0
Fork 0
mirror of https://github.com/claunia/marechai.git synced 2025-12-16 19:14:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor controller methods to return ActionResult for better error handling

Browse Source
This commit is contained in:
Natalia Portillo
2025-11-13 18:52:45 +00:00
parent 505ace535f
commit fc6238aef1
55 changed files with 724 additions and 539 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
Marechai.Server/Controllers/MachinesController.cs
View File

@@ -29,6 +29,7 @@ using System.Linq;
using System.Security.Claims;
using System.Threading.Tasks;
using Marechai.Data.Dtos;
using Marechai.Database;
using Marechai.Database.Models;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
@@ -90,14 +91,14 @@ public class MachinesController
[Authorize(Roles = "Admin,UberAdmin")]
[ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)]
public async Task UpdateAsync(MachineDto dto)
public async Task<ActionResult> UpdateAsync(MachineDto dto)
{
string userId = User.FindFirstValue(ClaimTypes.Sid);
if(userId is null) return;
if(userId is null) return Unauthorized();
Machine model = await context.Machines.FindAsync(dto.Id);
if(model is null) return;
if(model is null) return NotFound();
model.CompanyId = dto.CompanyId;
model.Name = dto.Name;
@@ -131,17 +132,19 @@ public class MachinesController
if(news != null) await context.News.AddAsync(news);
await context.SaveChangesWithUserAsync(userId);
return Ok();
}
[HttpPost]
[Authorize(Roles = "Admin,UberAdmin")]
[ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)]
public async Task<int> CreateAsync(MachineDto dto)
public async Task<ActionResult<int>> CreateAsync(MachineDto dto)
{
string userId = User.FindFirstValue(ClaimTypes.Sid);
if(userId is null) return 0;
if(userId is null) return Unauthorized();
var model = new Machine
{
@@ -260,17 +263,19 @@ public class MachinesController
[Authorize(Roles = "Admin,UberAdmin")]
[ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status400BadRequest)]
public async Task DeleteAsync(int id)
public async Task<ActionResult> DeleteAsync(int id)
{
string userId = User.FindFirstValue(ClaimTypes.Sid);
if(userId is null) return;
if(userId is null) return Unauthorized();
Machine item = await context.Machines.FindAsync(id);
if(item is null) return;
if(item is null) return NotFound();
context.Machines.Remove(item);
await context.SaveChangesWithUserAsync(userId);
return Ok();
}
}