[PR #5] [MERGED] NSArray: Implement IList<NSObject> #35

New Issue

claunia · 2026-01-30T21:26:51Z

claunia commented

2026-01-30 21:26:51 +00:00

📋 Pull Request Information

Original PR: https://github.com/claunia/plist-cil/pull/5
Author: @qmfrederik
Created: 5/22/2016
Status: ✅ Merged
Merged: 5/22/2016
Merged by: @claunia

Base: master ← Head: fixes/dotnetinterfaces

📝 Commits (2)

df27f9d NSArray: Implement IList
2bacfb7 Update the parsing code to match to work with the new NSArray class

📊 Changes

9 files changed (+255 additions, -36 deletions)

View changed files

➕ plist-cil.test/NSArrayTests.cs (+73 -0)
📝 plist-cil.test/ParseTest.cs (+1 -1)
📝 plist-cil.test/plist-cil.test.csproj (+4 -2)
📝 plist-cil/BinaryPropertyListParser.cs (+1 -1)
➕ plist-cil/NSArray.IList.cs (+139 -0)
📝 plist-cil/NSArray.cs (+28 -24)
📝 plist-cil/NSObject.cs (+7 -7)
📝 plist-cil/XmlPropertyListParser.cs (+1 -1)
📝 plist-cil/plist-cil.csproj (+1 -0)

📄 Description

This PR makes NSArray implement IList<NSObject>, just like NSDictionary implements IDictionary<string, NSObject>. It also changes the underlying storage from an array to a List<NSObject>, which makes operations like resizing the array more transparent.

Feedback is welcome!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/claunia/plist-cil/pull/5 **Author:** [@qmfrederik](https://github.com/qmfrederik) **Created:** 5/22/2016 **Status:** ✅ Merged **Merged:** 5/22/2016 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `master` ← **Head:** `fixes/dotnetinterfaces` --- ### 📝 Commits (2) - [`df27f9d`](https://github.com/claunia/plist-cil/commit/df27f9d5ac509df6c9abd8c85d04fb15cd1c7d0c) NSArray: Implement IList<NSObject> - [`2bacfb7`](https://github.com/claunia/plist-cil/commit/2bacfb7037b30dc8b2483e72f1bcac09fd01ec2d) Update the parsing code to match to work with the new NSArray class ### 📊 Changes **9 files changed** (+255 additions, -36 deletions) <details> <summary>View changed files</summary> ➕ `plist-cil.test/NSArrayTests.cs` (+73 -0) 📝 `plist-cil.test/ParseTest.cs` (+1 -1) 📝 `plist-cil.test/plist-cil.test.csproj` (+4 -2) 📝 `plist-cil/BinaryPropertyListParser.cs` (+1 -1) ➕ `plist-cil/NSArray.IList.cs` (+139 -0) 📝 `plist-cil/NSArray.cs` (+28 -24) 📝 `plist-cil/NSObject.cs` (+7 -7) 📝 `plist-cil/XmlPropertyListParser.cs` (+1 -1) 📝 `plist-cil/plist-cil.csproj` (+1 -0) </details> ### 📄 Description This PR makes `NSArray` implement `IList<NSObject>`, just like `NSDictionary` implements `IDictionary<string, NSObject>`. It also changes the underlying storage from an array to a `List<NSObject>`, which makes operations like resizing the array more transparent. Feedback is welcome! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-30 21:26:51 +00:00

claunia referenced this issue

2026-01-30 21:26:57 +00:00

[PR #35] [MERGED] Fix build warnings #55

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: claunia/plist-cil#35