[PR #2] Minor enhancements to plist-cil #38

New Issue

claunia · 2026-01-30T21:26:51Z

claunia commented

2026-01-30 21:26:51 +00:00

Original Pull Request: https://github.com/claunia/plist-cil/pull/2

State: closed
Merged: Yes

Hi,

I used plist-cil and encoutered some minor issues; so here is a pull request which should address them:

An empty array (of size 0) could not be serialized using the BinaryPropertyListWriter because there was a check for a 0-integer value. I changed it to check for negative values; the code now passes.
The order in which IDs are generated differs from the way the Apple libraries generate IDs (they generate IDs first for the keys and then for the values). I updated the code so that it follows the same pattern as Apple's code - ensuring binary compatibility.
plist-cil was not strong named; my assembly was; so I added a strong name to the plist-cil project

**Original Pull Request:** https://github.com/claunia/plist-cil/pull/2 **State:** closed **Merged:** Yes --- Hi, I used plist-cil and encoutered some minor issues; so here is a pull request which should address them: - An empty array (of size 0) could not be serialized using the `BinaryPropertyListWriter` because there was a check for a 0-integer value. I changed it to check for negative values; the code now passes. - The order in which IDs are generated differs from the way the Apple libraries generate IDs (they generate IDs first for the keys and then for the values). I updated the code so that it follows the same pattern as Apple's code - ensuring binary compatibility. - plist-cil was not strong named; my assembly was; so I added a strong name to the plist-cil project

claunia added the pull-request label 2026-01-30 21:26:51 +00:00

claunia referenced this issue

2026-01-30 21:26:59 +00:00

[PR #39] Add unit tests for BinaryPropertyListParser, UID classes #64

claunia referenced this issue

2026-01-30 21:26:59 +00:00

[PR #38] Reduce allocations in BinaryPropertyListParser #66

Sign in to join this conversation.