[PR #32] [MERGED] Fix XML serialization of binary values #56

New Issue

claunia · 2026-01-30T21:26:57Z

claunia commented

2026-01-30 21:26:57 +00:00

📋 Pull Request Information

Original PR: https://github.com/claunia/plist-cil/pull/32
Author: @qmfrederik
Created: 5/22/2018
Status: ✅ Merged
Merged: 5/23/2018
Merged by: @claunia

Base: master ← Head: fixes/xml-binary

📝 Commits (4)

274ab51 Correctly roundtrip long binary values
5bb8322 Update csproj file
835656b Fix path
5cc5100 Fix indentation, add unit test

📊 Changes

5 files changed (+67 additions, -3 deletions)

View changed files

📝 plist-cil.test/IssueTest.cs (+28 -0)
📝 plist-cil.test/plist-cil.test.csproj (+9 -0)
➕ plist-cil.test/test-files/RoundtripBinary.plist (+9 -0)
➕ plist-cil.test/test-files/RoundtripBinaryIndentation.plist (+12 -0)
📝 plist-cil/NSData.cs (+9 -3)

📄 Description

When serializing binary data to XML property lists, the base64 representation of the data is split across multiple lines, like this:

<data>
MjAxMy0wMi0wMiAyMDoxNjo0MiBHTVQ6IGhhbmRsZV9tZXNzYWdlOiBBbmQgeW91IHdp
bGwga25vdyBteSBuYW1lIGlzIHRoZSBMb3JkIHdoZW4gSSBsYXkgbXkgdmVuZ2VhbmNl
IHVwb24gdGhlZS4=
</data>

This PR makes plist-cil behave the same way.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/claunia/plist-cil/pull/32 **Author:** [@qmfrederik](https://github.com/qmfrederik) **Created:** 5/22/2018 **Status:** ✅ Merged **Merged:** 5/23/2018 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `master` ← **Head:** `fixes/xml-binary` --- ### 📝 Commits (4) - [`274ab51`](https://github.com/claunia/plist-cil/commit/274ab519e7f69b6934ef473eb69b82b588cc428a) Correctly roundtrip long binary values - [`5bb8322`](https://github.com/claunia/plist-cil/commit/5bb8322610dea5b71bcec37fdb2283008f00e9b1) Update csproj file - [`835656b`](https://github.com/claunia/plist-cil/commit/835656b73393cdce05146a637c062ed96c97e51b) Fix path - [`5cc5100`](https://github.com/claunia/plist-cil/commit/5cc5100df99af1471feb5f7f2782a5c4378396c8) Fix indentation, add unit test ### 📊 Changes **5 files changed** (+67 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `plist-cil.test/IssueTest.cs` (+28 -0) 📝 `plist-cil.test/plist-cil.test.csproj` (+9 -0) ➕ `plist-cil.test/test-files/RoundtripBinary.plist` (+9 -0) ➕ `plist-cil.test/test-files/RoundtripBinaryIndentation.plist` (+12 -0) 📝 `plist-cil/NSData.cs` (+9 -3) </details> ### 📄 Description When serializing binary data to XML property lists, the base64 representation of the data is split across multiple lines, like this: ```xml <data> MjAxMy0wMi0wMiAyMDoxNjo0MiBHTVQ6IGhhbmRsZV9tZXNzYWdlOiBBbmQgeW91IHdp bGwga25vdyBteSBuYW1lIGlzIHRoZSBMb3JkIHdoZW4gSSBsYXkgbXkgdmVuZ2VhbmNl IHVwb24gdGhlZS4= </data> ``` This PR makes plist-cil behave the same way. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-30 21:26:57 +00:00

claunia referenced this issue

2026-01-30 21:27:04 +00:00

[PR #56] NSNumber: support some exotic formats #90

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: claunia/plist-cil#56