[PR #30] [MERGED] Fix building plist-cil #59

New Issue

claunia · 2026-01-30T21:26:57Z

claunia commented

2026-01-30 21:26:57 +00:00

📋 Pull Request Information

Original PR: https://github.com/claunia/plist-cil/pull/30
Author: @qmfrederik
Created: 5/22/2018
Status: ✅ Merged
Merged: 5/22/2018
Merged by: @claunia

Base: master ← Head: fixes/build

📝 Commits (8)

5be1901 Fix building plist-cil
b76cda7 Fix AppVeyor build script
c6a5be0 Support netcoreapp2.0 and netstandard2.0
2e2bd54 Fix .NET Core version number in Travis
674d57e Skip test for scenario which is not implemented
32da65a Test on mono 5.0.0
7241b5d Don't build net45, net40 on Linux
22b977b Fix paths

📊 Changes

8 files changed (+73 additions, -50 deletions)

View changed files

📝 .travis.yml (+6 -12)
📝 appveyor.yml (+4 -10)
📝 plist-cil.test/IssueTest.cs (+3 -3)
➖ plist-cil.test/packages.config (+0 -4)
📝 plist-cil.test/plist-cil.test.csproj (+4 -5)
📝 plist-cil/NSArray.IList.cs (+0 -1)
📝 plist-cil/UID.cs (+48 -12)
📝 plist-cil/plist-cil.csproj (+8 -3)

📄 Description

I got a couple of errors when building from source, and this PR tries to address them:

To get System.Linq on .NET 4.0 and .NET 4.5, you need to add a reference to `System.Core. This PR adds that reference
I got a couple of errors because BitConverter.GetBytes(x).Reverse().ToArray() was being used. This PR changes that to be: this.bytes = BitConverter.GetBytes(x); Array.Reverse(this.bytes). This has the advantage of using Array.Reverse, which should be a bit more performant too (as no new array is being allocated).
The AppVeyor script was slightly outdated, this fixes that.
Add support for netcoreapp2.0 and netstandard2.0
Skip the TestIssue30 test (see 3breadt/dd-plist@e6cc1a0a17) as thsi functionality is not yet implemented
The new csproj file format is supported by Mono 5.x and newer, so update the .travis-ci.yml file to reflect that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/claunia/plist-cil/pull/30 **Author:** [@qmfrederik](https://github.com/qmfrederik) **Created:** 5/22/2018 **Status:** ✅ Merged **Merged:** 5/22/2018 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `master` ← **Head:** `fixes/build` --- ### 📝 Commits (8) - [`5be1901`](https://github.com/claunia/plist-cil/commit/5be1901bdbb2e7540d98952b4934ddfd2cc1517f) Fix building plist-cil - [`b76cda7`](https://github.com/claunia/plist-cil/commit/b76cda7532c2e4c0618a64c14c65059290f1c24e) Fix AppVeyor build script - [`c6a5be0`](https://github.com/claunia/plist-cil/commit/c6a5be0f620e050b676a3b00e3d348fca7e965ad) Support netcoreapp2.0 and netstandard2.0 - [`2e2bd54`](https://github.com/claunia/plist-cil/commit/2e2bd54f8f438ede8de3f8319bded11b6b98ce9c) Fix .NET Core version number in Travis - [`674d57e`](https://github.com/claunia/plist-cil/commit/674d57ea07cffb96266a10ca11811454ec051703) Skip test for scenario which is not implemented - [`32da65a`](https://github.com/claunia/plist-cil/commit/32da65ab055b12a00f31ac042523fdcb9cc9bf39) Test on mono 5.0.0 - [`7241b5d`](https://github.com/claunia/plist-cil/commit/7241b5d202f0765b527c722d6086ec5f56925fae) Don't build net45, net40 on Linux - [`22b977b`](https://github.com/claunia/plist-cil/commit/22b977bb20911572ab48f93667fb1188c5f20079) Fix paths ### 📊 Changes **8 files changed** (+73 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+6 -12) 📝 `appveyor.yml` (+4 -10) 📝 `plist-cil.test/IssueTest.cs` (+3 -3) ➖ `plist-cil.test/packages.config` (+0 -4) 📝 `plist-cil.test/plist-cil.test.csproj` (+4 -5) 📝 `plist-cil/NSArray.IList.cs` (+0 -1) 📝 `plist-cil/UID.cs` (+48 -12) 📝 `plist-cil/plist-cil.csproj` (+8 -3) </details> ### 📄 Description I got a couple of errors when building from source, and this PR tries to address them: 1. To get `System.Linq` on .NET 4.0 and .NET 4.5, you need to add a reference to `System.Core. This PR adds that reference 2. I got a couple of errors because `BitConverter.GetBytes(x).Reverse().ToArray()` was being used. This PR changes that to be: `this.bytes = BitConverter.GetBytes(x); Array.Reverse(this.bytes)`. This has the advantage of using `Array.Reverse`, which should be a bit more performant too (as no new array is being allocated). 3. The AppVeyor script was slightly outdated, this fixes that. 4. Add support for `netcoreapp2.0` and `netstandard2.0` 5. Skip the `TestIssue30` test (see 3breadt/dd-plist@e6cc1a0a171ed49577254a2dcd3c9d52aa0253ea) as thsi functionality is not yet implemented 6. The new `csproj` file format is supported by Mono 5.x and newer, so update the `.travis-ci.yml` file to reflect that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-30 21:26:57 +00:00

claunia closed this issue

2026-01-30 21:26:58 +00:00

claunia referenced this issue

2026-01-30 21:27:06 +00:00

[PR #59] [MERGED] Use 1 << exp instead of Math.Pow(2, exp) #97

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: claunia/plist-cil#59