claunia/plist-cil
1
0
Fork 0
mirror of https://github.com/claunia/plist-cil.git synced 2026-02-04 05:34:41 +00:00
Code Issues 71 Packages Projects Releases 3 Wiki Activity

[PR #42] [MERGED] Use cached values for ASCII, UTF8 and UTF16 encoding #71

New Issue
Open
opened 2026-01-30 21:27:00 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 21:27:00 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/claunia/plist-cil/pull/42
Author: @qmfrederik
Created: 6/19/2018
Status: ✅ Merged
Merged: 6/22/2018
Merged by: @claunia

Base: master ← Head: fixes/cache-encoding

📝 Commits (1)

📊 Changes

2 files changed (+19 additions, -7 deletions)

View changed files

📝 plist-cil/BinaryPropertyListParser.cs (+6 -4)
📝 plist-cil/NSString.cs (+13 -3)

📄 Description

Calling Encoding.GetEncoding is surprisingly expensive, so use cached properties instead. 11.8% improvement on Windows and 22% improvement on Linux.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/claunia/plist-cil/pull/42 **Author:** [@qmfrederik](https://github.com/qmfrederik) **Created:** 6/19/2018 **Status:** ✅ Merged **Merged:** 6/22/2018 **Merged by:** [@claunia](https://github.com/claunia) **Base:** `master` ← **Head:** `fixes/cache-encoding` --- ### 📝 Commits (1) - [`23c72a6`](https://github.com/claunia/plist-cil/commit/23c72a676a7b7dc20b0be4e8c0bfde1c7e0019a7) Use cached encodings ### 📊 Changes **2 files changed** (+19 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `plist-cil/BinaryPropertyListParser.cs` (+6 -4) 📝 `plist-cil/NSString.cs` (+13 -3) </details> ### 📄 Description Calling `Encoding.GetEncoding` is surprisingly expensive, so use cached properties instead. 11.8% improvement on Windows and 22% improvement on Linux. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-30 21:27:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
bug
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: claunia/plist-cil#71
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?