mirror of
https://github.com/claunia/plist-cil.git
synced 2026-02-04 05:34:41 +00:00
[PR #45] Improve BinaryPropertyListWriter performance #73
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/claunia/plist-cil/pull/45
State: closed
Merged: Yes
This PR improves the performance of the BinaryPropertyListWriter by using a
Dictionary<NSObject, int>to store the indices of binary objects instead of aCollection<NSObject>. It removes the need to do anIndexOf, which scans the entire list. That is a very expensive O(N) operation.This results in a 97% performance improvement on Windows (i.e. 30 times as fast) and a 98% performance improvement on Linux.