\n";
/* Match specific license? */
-$sLicense = version::checkLicense($aClean['sLicense']);
+$sLicenseString = isset($aClean['sLicense']) ? $aClean['sLicense'] : '';
+$sLicense = version::checkLicense( $sLicenseString );
/* Set default values */
-if(!$aClean['iNumVersions'] || $aClean['iNumVersions'] > 200 || $aClean['iNumVersions'] < 0)
+if(!isset($aClean['iNumVersions']) || $aClean['iNumVersions'] > 200 || $aClean['iNumVersions'] < 0)
$aClean['iNumVersions'] = 25;
-if(!$aClean['iPage'])
+if( !isset($aClean['iPage']) )
$aClean['iPage'] = 1;
/* Count the possible matches */
@@ -39,7 +40,7 @@ else
if($hResult && mysql_num_rows($hResult))
$num = mysql_num_rows($hResult);
-$iNumPages = ceil($num / $aClean['iNumVersions']);
+$iNumPages = isset($num) ? ceil($num/$aClean['iNumVersions']) : 0;
/* Check page logic */
$aClean['iPage'] = min($aClean['iPage'], $iNumPages);
@@ -50,9 +51,11 @@ $iLimitLower = ($aClean['iPage'] - 1) * $aClean['iNumVersions'];
/* Page selection */
echo "
\n";
echo "Page ".$aClean['iPage']." of $iNumPages
\n";
+// $iPageRange is non-existent here? creating it
+$iPageRange = 10;
display_page_range($aClean['iPage'], $iPageRange, $iNumPages,
$_SERVER['PHP_SELF']."?iNumVersions=".$aClean['iNumVersions']."&sLicense=".
- $aClean['sLicense']);
+ $sLicenseString);
/* Selector for how many versions to display */
echo "
\n
\n";
-if(!$num)
+if(!isset($num))
{
echo "
No matches found
\n";
echo html_frame_end(" ");
diff --git a/help/index.php b/help/index.php
index 0db00f4..f366671 100644
--- a/help/index.php
+++ b/help/index.php
@@ -8,7 +8,7 @@ require(BASE."include/"."incl.php");
$help_path = BASE."/help";
-if($aClean['sTopic'])
+if(isset($aClean['sTopic']))
{
display_help($aClean['sTopic']);
} else {
diff --git a/include/appData.php b/include/appData.php
index 85a22ee..6279224 100644
--- a/include/appData.php
+++ b/include/appData.php
@@ -258,6 +258,8 @@ class appData
{
if($sQueued == "true" || $sQueued == "false")
$sAppDataQueued = " AND appData.queued = '$sQueued'";
+ else
+ $sAppDataQueued = '';
if($sType)
$sSelectType = " AND type = '?'";
diff --git a/include/application.php b/include/application.php
index aaf9ceb..88cb918 100644
--- a/include/application.php
+++ b/include/application.php
@@ -878,8 +878,8 @@ class Application {
{
if($_SESSION['current']->hasPriv("admin"))
return TRUE;
-
- if(is_object($this) && $this->iAppId)
+
+ if(isset($this) && is_object($this) && $this->iAppId)
{
if(maintainer::isUserSuperMaintainer($_SESSION['current'],
$this->iAppId))
diff --git a/include/comment.php b/include/comment.php
index 69e06f5..1144b5d 100644
--- a/include/comment.php
+++ b/include/comment.php
@@ -435,7 +435,7 @@ class Comment {
else
$mode = "threaded"; /* default non-logged in users to threaded comment display mode */
- if ($aClean['sMode']=="nested")
+ if ( isset($aClean['sMode']) && $aClean['sMode']=="nested")
$mode = "nested";
switch ($mode)
diff --git a/include/downloadurl.php b/include/downloadurl.php
index 6a9da21..8e8a3f6 100644
--- a/include/downloadurl.php
+++ b/include/downloadurl.php
@@ -50,6 +50,8 @@ class downloadurl
if(!($hResult = appData::getData($iVersionId, "downloadurl")))
return FALSE;
+ // we're appending, so initialize it
+ $sReturn = '';
for($i = 0; $oRow = mysql_fetch_object($hResult); $i++)
{
$sReturn .= html_tr(array(
diff --git a/include/error_log.php b/include/error_log.php
index abb312a..18799a3 100644
--- a/include/error_log.php
+++ b/include/error_log.php
@@ -22,9 +22,10 @@ class error_log
$sQuery = 'INSERT INTO error_log (submitTime, userid, type, log_text, request_text, deleted) '.
"VALUES(?, '?', '?', '?', '?', '?')";
+ $iUser = (isset($_SESSION['current']) ? $_SESSION['current']->iUserId : 0);
$hResult = query_parameters($sQuery,
"NOW()",
- $_SESSION['current']->iUserId,
+ $iUser,
$sErrorType,
$sLogText,
$sRequestText,
diff --git a/include/form_login.php b/include/form_login.php
index 169ec2f..2bdae6a 100644
--- a/include/form_login.php
+++ b/include/form_login.php
@@ -9,7 +9,7 @@ echo '