Display a note when viewiing old test results
This commit is contained in:
committed by
Chris Morgan
parent
587c866e16
commit
058eba4b4f
@@ -1214,6 +1214,15 @@ class testData{
|
|||||||
return TRUE;
|
return TRUE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public function isOld()
|
||||||
|
{
|
||||||
|
/* If no id is defined that means the test report is not in the database, which means it can't be old */
|
||||||
|
if(!$this->iTestingId)
|
||||||
|
return false;
|
||||||
|
|
||||||
|
return ((mktime() - mysqltimestamp_to_unixtimestamp($this->sSubmitTime)) > (60 * 60 * 24 * 175));
|
||||||
|
}
|
||||||
|
|
||||||
function objectGetChildren($bIncludeDeleted = false)
|
function objectGetChildren($bIncludeDeleted = false)
|
||||||
{
|
{
|
||||||
/* We have none */
|
/* We have none */
|
||||||
|
|||||||
@@ -1038,13 +1038,15 @@ class version {
|
|||||||
//////////////////////
|
//////////////////////
|
||||||
// Show test data
|
// Show test data
|
||||||
|
|
||||||
|
$iNewestId = 0;
|
||||||
|
|
||||||
/* Set if the use chose to display a particular test report */
|
/* Set if the use chose to display a particular test report */
|
||||||
if($iTestingId)
|
if($iTestingId)
|
||||||
$oTest = new testData($iTestingId);
|
$oTest = new testData($iTestingId);
|
||||||
else if($this->iVersionId) /* Let's query for the latest rest report */
|
else if($this->iVersionId) /* Let's query for the latest rest report */
|
||||||
{
|
{
|
||||||
$iTestingId = testData::getNewestTestIdFromVersionId($this->iVersionId);
|
$iNewestId = testData::getNewestTestIdFromVersionId($this->iVersionId);
|
||||||
|
$iTestingId = $iNewestId;
|
||||||
|
|
||||||
if($iTestingId) /* We want all entries to have test data, but old versions might lack
|
if($iTestingId) /* We want all entries to have test data, but old versions might lack
|
||||||
it, or data may have been deleted */
|
it, or data may have been deleted */
|
||||||
@@ -1059,6 +1061,19 @@ class version {
|
|||||||
|
|
||||||
if($oTest)
|
if($oTest)
|
||||||
{
|
{
|
||||||
|
if($oTest->isOld())
|
||||||
|
{
|
||||||
|
if($iNewestId != $oTest->objectGetId())
|
||||||
|
{
|
||||||
|
$sWarnOldText = 'The test results you have selected are very old and may not represent the current state of Wine.';
|
||||||
|
} else
|
||||||
|
{
|
||||||
|
$sWarnOldText = 'The test results for this version are very old, and as such they may not represent '.
|
||||||
|
'the current state of Wine. Please consider submitting a new test report.';
|
||||||
|
}
|
||||||
|
echo html_note('Old test results', $sWarnOldText);
|
||||||
|
}
|
||||||
|
|
||||||
echo "<div class='info_container'>\n";
|
echo "<div class='info_container'>\n";
|
||||||
|
|
||||||
echo "\t<div class='title_class'>\n";
|
echo "\t<div class='title_class'>\n";
|
||||||
|
|||||||
Reference in New Issue
Block a user