From 07e2dab8f8189326fa152bb29fcaf179f34a4220 Mon Sep 17 00:00:00 2001
From: Chris Morgan <cmorgan@alum.wpi.edu>
Date: Sat, 8 Jul 2006 22:10:56 +0000
Subject: [PATCH] Pass $iTestingId into Version::display() instead of reading
 it from $_REQUEST.  We don't want classes to depend on $_REQUEST if possible

---
 appview.php         | 3 ++-
 include/version.php | 8 ++------
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/appview.php b/appview.php
index bedb79d..089504a 100644
--- a/appview.php
+++ b/appview.php
@@ -33,6 +33,7 @@ $aClean['iAppId'] = makeSafe($_REQUEST['iAppId']);
 $aClean['iVersionId'] = makeSafe($_REQUEST['iVersionId']);
 $aClean['sSub'] = makeSafe($_REQUEST['sSub']);
 $aClean['iBuglinkId'] = makeSafe($_REQUEST['iBuglinkId']);
+$aClean['iTestingId'] = makeSafe($_REQUEST['iTestingId']);
 
 $oApp = new Application($aClean['iAppId']);
 $oVersion = new Version($aClean['iVersionId']);
@@ -157,7 +158,7 @@ if($aClean['iAppId'])
 } else if($aClean['iVersionId']) // We want to see a particular version.
 {
     $oVersion = new Version($aClean['iVersionId']);
-    $oVersion->display();
+    $oVersion->display($aClean['iTestingId']);
 } else
 {
     // Oops! Called with no params, bad llamah!
diff --git a/include/version.php b/include/version.php
index 6cbacde..2dbd83b 100644
--- a/include/version.php
+++ b/include/version.php
@@ -603,12 +603,8 @@ class Version {
         $this->sTestedRelease = $aValues['sMaintainerRelease'];
     }
 
-    function display()
+    function display($iTestingId)
     {
-        $aClean = array(); //array of filtered user input
-        $aClean['iTestingId'] = makeSafe($_REQUEST['iTestingId']);
-	
-
         /* is this user supposed to view this version? */
         if(!$_SESSION['current']->canViewVersion($this))
             util_show_error_page_and_exit("Something went wrong with the application or version id");
@@ -786,7 +782,7 @@ class Version {
         echo $this->sDescription;
 
         // Show testing data
-        $oTest = new TestData($aClean['iTestingId']);
+        $oTest = new TestData($iTestingId);
         $iCurrentTest = $oTest->ShowTestResult($oTest->iTestingId, $this->iVersionId);
         if($iCurrentTest)
         {