claunia/qemudb
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Better checking on user input

Browse Source
This commit is contained in:
Paul van Schayck
2004-12-27 05:18:41 +00:00
committed by WineHQ
parent 0f0e1c5425
commit 28c0894766
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
appview.php
View File

@@ -24,7 +24,7 @@ require(BASE."include/"."maintainer.php");
function admin_menu() function admin_menu()
{ {
$m = new htmlmenu("Admin"); $m = new htmlmenu("Admin");
if($_REQUEST['versionId']) { if(isset($_REQUEST['versionId'])) {
$m->add("Add Note", BASE."admin/addAppNote.php?appId=$appId&versionId=".$_REQUEST['versionId']); $m->add("Add Note", BASE."admin/addAppNote.php?appId=$appId&versionId=".$_REQUEST['versionId']);
$m->addmisc(" "); $m->addmisc(" ");
@@ -204,18 +204,26 @@ function display_versions($appId, $versions)
} }
$appId = $_REQUEST['appId'];
$versionId = $_REQUEST['versionId'];
/** /**
* We want to see an application family (=no version) * We want to see an application family (=no version)
*/ */
if(!is_numeric($appId)) if(!is_numeric($_REQUEST['appId']))
{ {
errorpage("Something went wrong with the IDs"); errorpage("Something went wrong with the application ID");
exit; exit;
} }
$appId = $_REQUEST['appId'];
if(!empty($_REQUEST['versionId']) AND !is_numeric($_REQUEST['versionId']))
{
errorpage("Something went wrong with the version ID");
exit;
}
$versionId = $_REQUEST['versionId'];
if($appId && !$versionId) if($appId && !$versionId)
{ {
$app = new Application($appId); $app = new Application($appId);